This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 162660 - [regression] No more shell/bat support in IDE
Summary: [regression] No more shell/bat support in IDE
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jan Jancura
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2009-04-15 03:39 UTC by Vladimir Voskresensky
Modified: 2009-04-16 19:16 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Voskresensky 2009-04-15 03:39:50 UTC
C++ cluster depended on existing support for Shell and Bat files:
- mime resolver
- editor
C++ reused existing support while providing own DataObject for shell files.

Now IDE doesn't have such support and C++ is broken as well.
Looks like incompatible change
Comment 1 Jan Jancura 2009-04-15 09:12:59 UTC
Sorry, I thought that you have your own lexer for that types.
Comment 2 Vladimir Voskresensky 2009-04-15 09:19:48 UTC
there was one long time ago, but then lang.sh and lang.bat appeared which caused some races between C++ only and full
IDE, so we were forced to remove our support ( our icon,  mime-resolving and editor) and we only provide own DataObject,
because we put ExecCookie into ShellDataObject to support execution of scripts in IDE.

Btw, what do you plan to do? 
And what should be specified on C++ side to prevent such situation in the future?
Comment 3 Jan Jancura 2009-04-15 11:46:38 UTC
I will fix it asap. (return lexers back)
missing coloring in sh and bat looks like P2 for me.
Comment 4 Vladimir Voskresensky 2009-04-15 11:56:09 UTC
if only coloring is missed I agree to have as P2, 
but
declared mime-resolvers were removed as well => files are no more recognized as with mime-type text/x-sh and text/x-bat 
=> our DataLoader is not called => ShellDataObjects are not created (no corresponding primary files with needed mime
types), so should be P1. what do you think?
Comment 5 Jan Jancura 2009-04-15 12:08:29 UTC
I have to fix it today anyway.
We are branching beta...

Comment 6 Vladimir Voskresensky 2009-04-15 12:14:18 UTC
great! thank you
Comment 7 Jan Jancura 2009-04-15 16:32:59 UTC
should be fixed in #2b9a78b78092
Comment 8 Jan Jancura 2009-04-15 16:35:55 UTC
I moved sh and bat lexers to cnd.lexer, and fixed some data objects.
Comment 9 Quality Engineering 2009-04-16 19:16:54 UTC
Integrated into 'main-golden', will be available in build *200904161401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/2b9a78b78092
User: Jan Jancura <jjancura@netbeans.org>
Log: #162660: [regression] No more shell bat support in IDE