This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 160663 - wrong appearance of the search results window on Mac L&F
Summary: wrong appearance of the search results window on Mac L&F
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 6.x
Hardware: Macintosh All
: P4 blocker (vote)
Assignee: Andrey Yamkovoy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-19 15:42 UTC by Ondrej Langr
Modified: 2009-05-20 07:20 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Current appearance of the search results window with the white background , too dark grey around and improper appearance of the buttons on the left (42.80 KB, image/png)
2009-03-19 15:43 UTC, Ondrej Langr
Details
Suggested appearance (illustrated by the tasks window) (15.80 KB, image/png)
2009-03-19 15:44 UTC, Ondrej Langr
Details
inconsistent background of the empty window (346.21 KB, image/png)
2009-03-20 11:34 UTC, Ondrej Langr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Langr 2009-03-19 15:42:22 UTC
On the new Mac L&F, all windows around the main area should use consistent background color. Several windows, including
the search results window use hard-coded background color. This applies both when the window us empty (dark grey color)
and when the window is filled with results (white). 

Please use the following code (provided by saubrecht) to adjust background for mac l&f:

        if( "Aqua".equals( UIManager.getLookAndFeel().getID() ) ) {
            setBackground(UIManager.getColor("NbExplorerView.background")); //NOI18N
        }

The color used for the border around the white area (see the attached screenshot) should be set to standard background
color of all windows in new mac L&F.

Further, the search results window has wrong appearance of the control element on the left side of it and annoying
frames around it. See the attached screenshot of the task window for correct appearance.

(I'm unsure of the correct component, please reassign if necessary)
Comment 1 Ondrej Langr 2009-03-19 15:43:26 UTC
Created attachment 78464 [details]
Current appearance of the search results window with the white background , too dark grey around and improper appearance of the buttons on the left
Comment 2 Ondrej Langr 2009-03-19 15:44:00 UTC
Created attachment 78465 [details]
Suggested appearance (illustrated by the tasks window)
Comment 3 Andrey Yamkovoy 2009-03-20 10:36:18 UTC
The font and background colors are not hardcoded for the Search Results window. But there is a problem with colors when
changing OS L&F. Looks like it's a duplicate of issue 159165.

As for the wrong appearance of the control element I am not understand you idea. I don't see problems with that on your
screenshot. Could you please file another issue for this problem and provide additional details what is wrong in your
opinion.

*** This issue has been marked as a duplicate of 159165 ***
Comment 4 Ondrej Langr 2009-03-20 11:24:54 UTC
This issue is not about switching L&Fs at runtime, but about the appearance of the window on one specific L&F - Mac L&F.
I presume some of the problems with the appearance (e.g. icons lacking transparency) will cause problems in other L&Fs
too, but I didn't investigate. 

Reopening the issue and attaching screenshots with more detailed explanation of the problems.
Comment 5 Ondrej Langr 2009-03-20 11:34:45 UTC
Created attachment 78505 [details]
inconsistent background of the empty window
Comment 6 Andrey Yamkovoy 2009-03-20 15:48:23 UTC
L&F problem was fixed in the trunk.
Comment 7 Andrey Yamkovoy 2009-03-20 16:10:57 UTC
The buttons looks fine for me now. Please verify.
Comment 8 Quality Engineering 2009-03-23 10:01:55 UTC
Integrated into 'main-golden', will be available in build *200903230201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/c09c8968c6b2
User: Andrey Yamkovoy <kaktus@netbeans.org>
Log: Fix for #160663 - Fixed LaF for Mac
Comment 9 Ondrej Langr 2009-04-03 13:30:26 UTC
Yes, both the buttons and the background are OK. However, there should be a gray border between the two areas on mac L&F
(color: #8C8C8C). Again, see the tasks window for an example.

Re-opening this to fix this minor issue .. and making it a P4 .. since this change is rather minor.
Comment 10 Stanislav Aubrecht 2009-04-03 13:45:18 UTC
there should be some border or separator on the toolbar - the issue applies to all look and feels, it's just more
visible on mac
Comment 11 Andrey Yamkovoy 2009-05-19 11:20:30 UTC
Separators for toolbar and buttons panel were added.
Comment 12 Quality Engineering 2009-05-20 07:20:55 UTC
Integrated into 'main-golden', will be available in build *200905200201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/9779003d9085
User: Andrey Yamkovoy <kaktus@netbeans.org>
Log: Fix for #160663 - wrong appearance of the search results window on Mac L&F