This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 160554 - NbModuleSuite.Configuration.failOn* failures report unexpected test name
Summary: NbModuleSuite.Configuration.failOn* failures report unexpected test name
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: NB JUnit (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: Jaroslav Tulach
URL: http://deadlock.netbeans.org/hudson/j...
Keywords:
Depends on:
Blocks: 155444
  Show dependency tree
 
Reported: 2009-03-18 14:46 UTC by Jesse Glick
Modified: 2009-09-29 22:20 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2009-03-18 14:46:59 UTC 
Note URL. Header says

"Failed  org.netbeans.junit.NbModuleLogHandler.unknown (from org.netbeans.test.ide.IDECommitValidationTest)"

Would be better to make the URL be from IDECommitValidationTest, e.g.

http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2297/testReport/org.netbeans.test.ide.IDECommitValidationTest/warningsOrErrors

or even the exact test name if this is possible.

The problem is "res.addFailure(this, ..." in NbModuleLogHandler. Perhaps registerBuffer should take toRun as an arg, and
use that as the arg to addFailure later.
Comment 1 Jaroslav Tulach 2009-03-18 16:29:48 UTC 
core-main#90330f5f7670
Comment 3 Quality Engineering 2009-03-19 20:34:19 UTC 
Integrated into 'main-golden', will be available in build *200903191401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/90330f5f7670
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #160554: Moving the handler class outside of public packages and making sure it subclasses TestCase
Comment 4 Jaroslav Tulach 2009-03-20 13:47:25 UTC 
Jesse: What is not working? There is no longer "unknown" in the test name.
Comment 5 Jesse Glick 2009-03-20 14:40:23 UTC 
I was not complaing about the word "unknown". The test "name" does not mention the actual test being run at all. Please
reread the original comment.
Comment 6 Jaroslav Tulach 2009-04-16 21:29:40 UTC 
I guess the problem is not that critical. Especially because the commit validation does not generate these errors 
anymore.
Comment 7 Jesse Glick 2009-04-17 17:33:56 UTC 
Though these calls should probably be readded to C/V, especially now that it is not blocking changeset propagation any
more; a good way to find out about random exceptions early before they hit users.
Comment 8 Jaroslav Tulach 2009-09-21 15:32:32 UTC 
ergonomics#cca0f9a5753a
Comment 9 Quality Engineering 2009-09-27 22:34:01 UTC 
Integrated into 'main-golden', will be available in build *200909270201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/cca0f9a5753a
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #160554: Assign failures from failOnXYZ to appropriate testcases