This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 160415 - Stabilize Search API
Summary: Stabilize Search API
Status: VERIFIED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 6.x
Hardware: Macintosh All
: P3 blocker (vote)
Assignee: Jaroslav Havlin
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2009-03-16 23:12 UTC by maxnitribitt
Modified: 2013-03-15 09:15 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
Proposed Patch (29.13 KB, patch)
2013-02-27 15:56 UTC, Jaroslav Havlin
Details | Diff
Proposed Patch v2 (29.39 KB, patch)
2013-02-28 07:51 UTC, Jaroslav Havlin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description maxnitribitt 2009-03-16 23:12:53 UTC
Many developers use or intend to use search functionality for extending NetBeans or in RCP applications. Such a basic
functionality should provide a stable API/SPI.
Comment 1 Jaroslav Havlin 2012-02-09 08:14:22 UTC
We are now considering deprecating current Search API (org.openidex.search) and creating a new one, that could be stabilized in the near future.

What do you think the API should offer? Could you please provide us with some use cases?

See bug 207436.
Comment 2 Jaroslav Havlin 2013-02-27 15:56:33 UTC
Created attachment 131975 [details]
Proposed Patch
Comment 3 Jaroslav Havlin 2013-02-27 16:05:00 UTC
Excerpt from email written by Jaroslav Tulach:

= %< ================================

I'd like to propose a bit of cleanup.

1. Rename "openidex.search" to "Deprecated, old search API".

2. Rename "api.search" to "Search API" (it does not seem to have project 
dependency anyway)

3. List the api.search among stable APIs

In addition to that I'd suggest a bit of javadoc polishing. Each package 
should have package.html description. Usecases should use <a 
href="@TOP@/fqn/Cls.html">Cls</a> to link to real classes.

================================ >% =

Fixed in attached patch.

Is it OK to keep API SearchProviderUIAPI in category Under Development?
(Other APIs in module api.search were marked as Stable.)

Is API review needed before making the API stable?

Thank you.
Comment 4 Jaroslav Havlin 2013-02-28 07:51:37 UTC
Created attachment 131993 [details]
Proposed Patch v2

> Is it OK to keep API SearchProviderUIAPI in category Under Development?
> (Other APIs in module api.search were marked as Stable.)
I've marked SearchProviderUIAPI as Stable, too.
Comment 5 Jaroslav Havlin 2013-02-28 07:54:27 UTC
> Is API review needed before making the API stable?
I'm starting a fast API review, just to be sure that the stabilization is OK.
Comment 6 Jaroslav Tulach 2013-02-28 08:37:45 UTC
> > Is it OK to keep API SearchProviderUIAPI in category Under Development?
> > (Other APIs in module api.search were marked as Stable.)
> I've marked SearchProviderUIAPI as Stable, too.

That is simpler. When there are two independently stable APIs in one module, there is a problem with versioning. When only one of the APIs changes incompatibly, should the version change incompatibly or not? Jesse proposed a solution[1] based on proximity[2], but we don't have such system in place (except producing OSGi bundle and using what is in OSGi currently).

[1] http://wiki.netbeans.org/NbmPackageStability
[2] http://wiki.apidesign.org/wiki/Proximity
Comment 7 Jaroslav Havlin 2013-03-07 12:16:30 UTC
If there are no objections, I'll integrate tomorrow.
Thank you.
Comment 8 Jaroslav Havlin 2013-03-08 14:49:57 UTC
Integrated as http://hg.netbeans.org/core-main/rev/20ed82f5d7d0
Comment 9 Quality Engineering 2013-03-10 01:49:20 UTC
Integrated into 'main-golden', will be available in build *201303092300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/20ed82f5d7d0
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #160415: Stabilize Search API
Comment 10 Quality Engineering 2013-03-12 02:05:24 UTC
Integrated into 'main-golden', will be available in build *201303112300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/0a92d7174d7a
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #160415: Moving links in package.html to second paragraph

 (Not to break relative paths in overview-summary.html)
Comment 11 Jaroslav Tulach 2013-03-15 09:15:18 UTC
I can see proper javadoc at http://bits.netbeans.org/dev/javadoc/ marking verified.