The MetadataElementHandle doesn't support Value type.
Sorry, I don't understand this. Can you provide some more background to help me understand? Thanks.
MetadataElementHandle is missing code for resolving Value handles. There is no "Kind" for
So, for instance, I can't create a handle to the Value instance I get back from calling
OK, got it, thanks.
Created attachment 126262 [details]
proposed patch v1
The attached bug fixes this problem at the cost of an api breach.
I was not able to create a procedure in derby that returns a value, so I looked at functions, which by definition return a value. I extended the metadata to include functions and added a resolve-method for functions and returnvalues to the MetadataElementHandle.
I extended the unittest to verify resolving handles for parameters, functions, procedures and returnValues.
Please have a look at it (i wouldn't consider it for 7.3!)
Created attachment 131279 [details]
Proposed Patch v2
Updating Matthias's patch (increased version number, added @since tags).
Thank you very much for providing the patch.
Please review changes in module db.metadata.model.
The module API is not public (friend private), so the API review
is not mandatory, but if you are interested, please check it.
API Changes (under org.netbeans.modules.db.metadata.model):
Changed methods (incompatible API changes):
(return type changed from api.Procedure to api.MetadataElement)
Y01a If the change is incompatible, it is better to increase the major version (the one after /). That will prevent linkage errors (old client w/ new API).
Y01b Alternatively consider keeping compatibility by adding new method getEnclosingElement() and deprecating getParent (while keeping its behavior in previously existing situations).
Created attachment 131302 [details]
Proposed Patch v3
Y01 - I think a) is fine in this case. Specification version changed to 1.0.
Unless there are any objections, I'll integrate tomorrow.
Integrated as http://hg.netbeans.org/core-main/rev/2dad0543da3a
Integrated into 'main-golden', will be available in build *201302222300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
User: Jaroslav Havlin <firstname.lastname@example.org>
Log: #156304: MetadataElementHandle doesn't support Value type