This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 153889 - C/V test failed. testBinariesAreUnique
Summary: C/V test failed. testBinariesAreUnique
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Struts (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: _ potingwu
URL:
Keywords: TEST
Depends on:
Blocks:
 
Reported: 2008-11-25 20:05 UTC by Ivan Sidorkin
Modified: 2009-02-19 23:27 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Sidorkin 2008-11-25 20:05:23 UTC
Some binaries are duplicated
enterprise5/modules/ext/struts/oro-2.0.8.jar and ide10/modules/ext/jakarta-oro-2.0.8.jar are identical
enterprise5/modules/ext/struts/bsf-2.3.0.jar and ruby2/jruby-1.1.4/lib/bsf.jar are identical
Comment 1 _ potingwu 2008-11-25 20:24:41 UTC
From your list, the names are not identical. They are bundled by using the official Struts release which should be
together for well maintained and assure the compatibility issue.

I don't think it's a good idea to force Struts framework use Ruby framework's components. If users decide to remove or
disable Ruby from their IDE, then Struts will suddenly fail.

Please fix your test to skip these 2 files.

BTW, why is this P1? It will not cause any issue, even performance.
Comment 2 Jesse Glick 2008-11-25 20:52:17 UTC
It's a test failure which blocks production builds until fixed.

The proper solution is to factor out the common libraries into library wrapper modules which would be shared.

Failing that, an entry may be added to nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binary-overlaps to exclude
particular JARs from the test, with a comment explaining why sharing the libraries is impractical.
Comment 3 Jesse Glick 2008-11-25 22:16:23 UTC
Each line needs to list _both_ binaries which are duplicates of one another.
Comment 4 _ potingwu 2008-11-26 17:17:38 UTC
I have fixed this by updating ignored-binary-overlaps. The reason is we want to bundle the whole 'official Struts
release libraries' together not just for well maintained but also assure users' web application can be fully compatible
that users can trust.

Thanks jglick's helpful hints for fixing this issue!
Comment 5 Quality Engineering 2008-11-27 05:33:47 UTC
Integrated into 'main-golden', will be available in build *200811270201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/530095eb2828
User: potingwu@netbeans.org
Log: Fix Issue#153889, C/V test failed. testBinariesAreUnique
Comment 6 Ivan Sidorkin 2008-12-01 13:30:16 UTC
verified