This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 153839 - Deactived visual web still among other web frameworks
Summary: Deactived visual web still among other web frameworks
Status: RESOLVED WONTFIX
Alias: None
Product: platform
Classification: Unclassified
Component: Plugin Manager (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-25 09:45 UTC by Tomas Mysik
Modified: 2010-10-29 20:43 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Log of 1st start when uninstalling visualweb.kit (44.79 KB, text/plain)
2008-12-15 19:21 UTC, Peter Zavadsky
Details
Log of 2nd start (restart) after unistalling visualweb.kit, still lot of visualweb modules present (41.21 KB, text/plain)
2008-12-15 19:22 UTC, Peter Zavadsky
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Mysik 2008-11-25 09:45:44 UTC
Steps to reproduce:
- have IDE with visual web enabled
- Tools -> Plugins -> deactivate Visual JSF => restart IDE
- create a new Web application -> visual web framework still visible among other web frameworks

Reproduced in the latest daily build of NB 6.5 (from smetiste):
Product Version: NetBeans IDE Dev (Build 200810150101)
Java: 1.6.0_10; Java HotSpot(TM) Client VM 11.0-b15
System: Linux version 2.6.27-gentoo-r4 running on i386; UTF-8; cs_CZ (nb)
Comment 1 Tomas Mysik 2008-11-25 16:56:18 UTC
It seems to work in FoD builds, so feel free to close this issue if it's not reproducible for you. Anyway, downgrading 
to P3.
Comment 2 Peter Zavadsky 2008-12-01 19:11:23 UTC
The framework should go away, since that one is specified in the project module, which seems goes away.

However you are right, that there are other visual web modules, which still stay around. It seems it is too complex
issue, and it needs to be correctly resolved following the autoupdate spec.

I've spent some time already with that, it seems it is very time consuming.
Since there is a plan to move the modules to autoupdate anyway, I'll postpone this until there is a time left for that.
Comment 3 Peter Zavadsky 2008-12-12 20:57:26 UTC
I added missing AutoUpdate-Show-In-Client flags to the module manifests, also added missing dependencies to
visualweb.kit module (see the changeset).
However it still seems to not work, and a lot of modules (no all) are getting loaded after unistalling of the visualweb.kit.

I pass this to autoupdate temporarily.
Please, could there be a problem in autoupdate? It seems I added all dependencies to the visualweb.kit module, made all
of the modules to be AutoUpdate-Show-In-Client: false, and some of them still get loaded.

Also how could I debug the module loading? I.e. I would need to find out why particular module (which has
AutoUpdate-Show-In-Client: false) got loaded (whether there is some some missed dependency or so).
Thanks.

changeset:   111509:7ff03b2515e5
tag:         tip
user:        Peter Zavadsky <pzavadsky@netbeans.org>
date:        Fri Dec 12 12:52:13 2008 -0800
summary:     #153839 Trying to fix the loading of modules after uninstalling the kit module.
Comment 4 dlipin 2008-12-13 15:48:16 UTC
please attach ~/.netbeans/<version>/var/log/messages.log* files.

Please note that module loading is out of control of AU - it is the functionality of the module system.
Having AutoUpdate-Show-In-Client flag set to false means that this module will not be visible in the Plugin Manager.
It has no effect on whether the module is loaded or not.
Comment 5 Quality Engineering 2008-12-13 17:02:28 UTC
Integrated into 'main-golden', will be available in build *200812131401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/7ff03b2515e5
User: Peter Zavadsky <pzavadsky@netbeans.org>
Log: #153839 Trying to fix the loading of modules after uninstalling the kit module.
It still seems to not fully work.
Comment 6 Peter Zavadsky 2008-12-15 19:21:44 UTC
Created attachment 74976 [details]
Log of 1st start when uninstalling visualweb.kit
Comment 7 Peter Zavadsky 2008-12-15 19:22:36 UTC
Created attachment 74977 [details]
Log of 2nd start (restart) after unistalling visualweb.kit, still lot of visualweb modules present
Comment 8 Peter Zavadsky 2008-12-15 19:27:12 UTC
I attached the logs:
1) messages.log.1  - log after 1st start (clean userdir) and unistalling of visualweb.kit (the kit module for visual web),
2) messages.log - log after restart, the visualweb.kit module got unistalled, also some other visualweb modules, but
still a lot of visualweb modules got loaded.

As I understand the deal with the autoupdate visibility and loading, I assume that module shouldn't be loaded when its
kit module is not loaded and there is no non-kit module which depends on such module.
That should be true for all of the visualweb modules, but they still get loaded. I can't detect which, non-visualweb
module keeps them loaded, or whether it is an issue of the module loading, or whether I missed something with the kit
module functionality.

I bump up the priority, because this seems to be breaking the assumed functionality for us. Also, please, assign it to
the appropriate module, if that belongs somewhere else. Thanks.
Comment 9 dlipin 2008-12-16 15:17:46 UTC
I really doubt that visualweb.kit can be a friend of any other module.
What is the purpose for doing that? 

I speak about the following line(s) added in the changeset #7ff03b2515e5:
<friend>org.netbeans.modules.visualweb.kit</friend>

From the other side, I can`t say for sure whether having this line can cause this issue or not.
Comment 10 Peter Zavadsky 2008-12-16 18:21:34 UTC
I added the kit module as a friend to some of the visualweb modules, so the kit module can depend on them, in order to
force their uninstall when unistalling the kit itself.
Those modules don't have public API's, so there is no other way to depend on them, only via friend dependency.

I am checking if all those modules have indirect dependencies to kit module via some other modules having public API's.
Comment 11 Peter Zavadsky 2008-12-16 20:56:25 UTC
OK, it seems all those modules, the kit has friend dependency on, have indirect dependency on kit anyway, so I am gonna
remove those.
Comment 12 Peter Zavadsky 2008-12-17 19:09:27 UTC
Removed the friend deps (see the changeset). However it still seem not to help, still the modules get loaded, even they
have direct or indirect deps on the kit module only, which gets uninstalled.
Those modules should get uninstalled as well, but they do not, from unknown reasons.

changeset:   112104:c04efd533f4f
tag:         tip
user:        Peter Zavadsky <pzavadsky@netbeans.org>
date:        Wed Dec 17 11:05:18 2008 -0800
summary:     #153839 Removing redundant friend dependencies.

Comment 13 Peter Zavadsky 2008-12-19 22:24:07 UTC
The friend dependencies shouldn't matter, otherwise one wouldn't be able to add such module into kit, unless it depends
on some public module (which is not always the case).
Comment 14 Quality Engineering 2008-12-22 15:25:12 UTC
Integrated into 'main-golden', will be available in build *200812221122* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/c04efd533f4f
User: Peter Zavadsky <pzavadsky@netbeans.org>
Log: #153839 Removing redundant friend dependencies.
Comment 15 dlipin 2008-12-24 12:34:51 UTC
In fact, deactivation of Visual JSF deactivates only the following modules/kits:
org-netbeans-modules-visualweb-complib
org-netbeans-modules-visualweb-dataconnectivity-designtime
org-netbeans-modules-visualweb-dataprovider-designtime
org-netbeans-modules-visualweb-ejb
org-netbeans-modules-visualweb-errorhandler-client
org-netbeans-modules-visualweb-j2ee14classloaderprovider
org-netbeans-modules-visualweb-j2ee15classloaderprovider
org-netbeans-modules-visualweb-jsfsupport-designtime
org-netbeans-modules-visualweb-jsfsupport-designtime_1_1
org-netbeans-modules-visualweb-jsfsupport-designtime_1_2
org-netbeans-modules-visualweb-kit
org-netbeans-modules-visualweb-palette
org-netbeans-modules-visualweb-project-jsfloader
org-netbeans-modules-visualweb-ravehelp-rave_nbpack
org-netbeans-modules-visualweb-samples-bundled
org-netbeans-modules-visualweb-web-ui-appbase
org-netbeans-modules-visualweb-websvcmgr
org-netbeans-modules-visualweb-webui-jsf-defaulttheme
org-netbeans-modules-visualweb-webui-themes

I`m continue investigations.
Comment 16 dlipin 2008-12-29 15:59:24 UTC
I can`t say that for sure but it looks like something wrong with visualweb.gravy module.

First, some facts (if I got them correctly):
1) It is invisible module
2) It is autoload module
3) It is not included in any of the visible kit(s)
4) It is included in the nb.cluster.visualweb
5) OpenIDE-Module-Display-Category=Testing Tools
6) If I remove visualweb.gravy from nb.cluster.visualweb then deactivation of Visual JSF works pretty fine.
7) It depends on a bunch of other visualweb modules (visualweb.{dataconnectivity,designer,designer.html, 
designer.jsf,designtime,insync,navigation,outline,xhtml})
8) No other module has the module-dependency on this module, only test-dependency

Jesse, Jirka, is it a valid module configuration?
Comment 17 Jesse Glick 2009-01-06 01:57:18 UTC
If it is only used in tests, and we have no reason to ship it, probably it can just be removed from the visualweb
cluster. But I don't know why it would be causing any problems if it is indeed autoload.
Comment 18 dlipin 2009-02-02 12:17:12 UTC
Since visualweb was moved to UC, it is not ncluded in any existing standard distributions. 
Due to that and all other facts, gravy will not be present on the system when user installs VisualWeb.
In other words, Visual JSF would be deactivated correctly.
Downgrading the priority to P4 and I`ll investigate it in the future when the time permits.
Comment 19 Jaroslav Tulach 2010-10-29 20:43:54 UTC
Who cares?