This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
using pseudo localized nb and fx modules some words not from bundle file or if in bundle file perhaps not coming from pseudo localized one 1. Design Preview window title 2. in fx editor, the word profiling in java project, this word is coming from a bundle file ** please look at all msgs and labels to make sure all are coming from a bundle file; this is really a usual part of coding and design review recommendations and requirements. sometimes there are labels and words that are common to different project types, but need to be implemeted/put in bundle per project type - perhaps the word profiling is one of them. BTW I think in previous issue mentioned about the names of some pallette categories not being in or coming from bundle file.
Ken, unfortunately we did not run the scripts that check for I18N strings in our modules. I am putting Martin on Cc:. The question is for both: do we need to fix this now? We are past code freeze for most of the things. Also is the list of what is missing for I18N definitive, Ken did you run some script to verify whether these are all that are missing?
David, I wish I knew of a definitive and easy to use such script; there is an older one that is still found in nbbuild section of repos but results can show a lot of false positives since almost every string with quotes would be shown, and that is a lot and in past has been a blocker for dev to go thru the results. also, its hard for such a general script to know module specific things to skip, some api that use strings that are not meant to be translated could be skipped but still there will be lots of false positives if you have any ideas about improving this kind of missing msg/label detection, lets talk in separate mail. What about in code review or in looking at the ui design and code - is there some other way dev can review to see a. some string/label/msg that is not using the i18n messaging api and/or is not in a bundle file ? b. some string that might be in bu ndle file but is not coded so that it comes from localized bundle file (it happens not as common as a.) as to needing to be fixed now, the question could be - is this meant for 6.5 stable update center ? if so, there are requirements that modules be i18n complete, both as to handling encoding and display of non ascii AND that all messages have been i18n coded ok. but if its not for stable uc then no I don't think there is requirement now about the messages part. as to the other non msg issues, it can be good for them to be fixed since might block any user in other locale from using characters of their language in fx app from nb, regardless if there is translated module or not. but if this release is viewed as an ea release, even that is not real requirement and in any case I realize that need to have it released now can mean these items are not fixed in any case until next release builds or patches. also I think more i18n testing will be needed, and for some functionality that might not be implemented yet or working - like the run in browser or jnlp - but that might be just due to the i18n problems in other issues. NOTE - if its for stable uc, please file the application and note that its not i18n ok yet, then the official stable uc web page can indicate that so its clear that it would not be translated for this release. ken.frank@sun.com
Adam, can you please check?
Created attachment 73573 [details] I18N check log
I've generated I18N check log and attached it. From the log it seems we have about 3465 lines of non-localized code or the code with missing //NOI18N tag. This definitely won't be fixed to 1.0 release. Let's handover this issue from module to module, starting with debugger (first 1964 lines).
finished with debugger, so passing to samples
Fixed in profiler module
Fixed in Preview module.
Fixed samples.
Fixed Project module and annotations part of Source module.
Thanks for generating the report and to team for looking at their areas. if anyone has some feedback on how the checking script could be improved but still valid for all of the product, to produce less output while still finding the needed problems, please let me know, or if any ideas for a different kind of script or approach for checking let me know and I'd try to write such. I'm not aware of any code checking tools out there that even could be customized rules for such checking since I think quoted are used so many places in code but only a few of them are really the quoted strings that might not have api coded to get them or place them in bundle file. ken.frank@sun.com
Created attachment 73768 [details] Updated list - great work, from 3465 there are just 1226 lines remaining.
Adam and all, can you give me some guidelines on, when you look at the list of quoted strings attached, how you analyze and find the ones that represent strings that are not using i18n api and/or that are not in bundle files ? I can then write up some guidelines that could perhaps help other developers look at their similar files more easily, assuming the approaches/guidelines you all use would be similar for other modules, since having the very long files with so many false positives makes it frustrating for many to look at the file and analyze it but yet from the progress of this issue, it seems to be an approach that does find the problems. ken.frank@sun.com
I've just installed Perl, used nbbuild/misc/i18ncheck.pl script and filtered some modules, test roots and Ant source roots out.
Fixed for editor and lexer.
fixed
should be OK. We will file issue if we find missing strings. Marked as Verified.