This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 151748 - Glassfish V2.1 English and ML should be both treated as the same version
Summary: Glassfish V2.1 English and ML should be both treated as the same version
Status: RESOLVED FIXED
Alias: None
Product: installer
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: dlipin
URL:
Keywords:
: 153467 160582 160989 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-29 16:34 UTC by ats37
Modified: 2009-03-24 10:58 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ats37 2008-10-29 16:34:05 UTC
Having had Netbeans 6.1 and 6.5 Beta running quite happily for some time now, this morning I installed RC1 (this is on
Windows XP).
The installer detected the existing glassfish-v2ur2 installation and the Open ESB V2 installation (displays "Already
Installed" on the first page), ignoring the existing glassfish-v3-prelude-b15b installation as it includes a more recent
version, so I just selected to install the IDE modules and the GlassFish v3 Prelude b28.

Then, having only just completed this installation, I saw the news announcment that RC2 was available...

So I uninstalled RC1, selecting to also remove the b28 gf3 installation (but not the other two runtimes).
Then I ran the RC2 installer.  However, this fails to detect the GlassFish 2 UR2 installation, only the Open ESB runtime
line says Already Installed.  Stepping through the wizard, though, when I get to the GlassFish V2 UR2 Installation page,
it has the existing C:\Program Files\glassfish-v2ur2 directory in the installation path by default, and displays an
error down at the bottom saying "The specified installation folder is not empty".  So either I set up a second identical
GF2 installation under a different path, or I can't proceed further with the installation.

Since (judging by the default installation path) it appeared to have been checking in the right location, I thought
perhaps the previous uninstaller had removed something it shouldn't have done such that the installation was no longer
detected.  So I cancelled the RC2 installation and ran the RC1 installer again instead.  To my surprise, that still says
"Already Installed" against the GF2 runtime, so it seems that in fact this is not the case, it's just the detection in
the RC2 installer that is broken...
Comment 1 dlipin 2008-10-29 17:09:52 UTC
GlassFish V2 UR2 in RC2 is different from the one that was in 6.5RC1 and 6.5 Beta (likely in 6.1 as well).
In fact it is ML (multilingual) version - but that differs from the English one (in 6.5RC and Beta).

So I`d say everything is by design. I leave the issue open for future (and make it the enhancement) to treat both En 
and ML versions the same in terms of installation status (installed or not).
Comment 2 ats37 2008-10-29 18:30:05 UTC
Oh, so that's why NB RC2's filename has "-ml" in it.  I did wonder about that.

As an alternative approach, perhaps the installer screen should simply include the "ML" in the GF runtime's version
string on the first page?  That way, even if it still wants to install to the same path by default, I'd have realised it
was different from the existing installation...

In the meantime, and rapidly drifting off topic, does RC2 have any particular dependency on the ML version or should I
be okay in principle to exclude GF2 from the installation and just configure a server entry for the existing
installation once it's done? (obviously, any issues I encounter with that setup I'd raise separately under the Glassfish
module rather than this one)  Given you're suggesting to treat them as equivalent with regard to installed status, I
assume not.
Comment 3 wobster 2008-11-05 15:21:55 UTC
Is the bundled version of Glassfish fully patched as compared to Sun's production version? I'm wondering if developers
need to go grab the production version for the patch fixes or use the NetBeans bundled version. Perhaps the name should
have the build number in it as a default?
Comment 4 dlipin 2008-11-05 16:03:58 UTC
No, it is the FCS version of GlassFish V2 UR2 (b04, not the patch4).
https://glassfish.dev.java.net/downloads/v2ur2-b04.html
Afaik the latest "patch" version of Sun distribution is available only for customers with paid support.
http://blogs.sun.com/theaquarium/entry/gfv2u2_patch_4_now_available
Comment 5 wobster 2008-11-05 16:52:39 UTC
When do the bug fixes in the production release get merged back into the the development version?

Does this b58 version have the patch 4 sets applied:
https://glassfish.dev.java.net/servlets/NewsItemView?newsItemID=6635

Comment 6 dlipin 2008-11-05 19:54:19 UTC
You`d better ask at the glassfish mailing lists than in NetBeans IssueZilla :)
I have an anwser to neither of your two questions, maybe Vince (CC-ed) knows.
Comment 7 Vince Kraemer 2008-11-06 01:24:00 UTC
sorry.  The way fixes flow from the support/sustaining group back to the dev trunk is something I do not track...

The fixes from patch 4 may be in the dev build... but I kind of doubt it...
Comment 8 dlipin 2008-11-19 15:55:03 UTC
*** Issue 153467 has been marked as a duplicate of this issue. ***
Comment 9 dlipin 2009-03-18 19:51:50 UTC
*** Issue 160582 has been marked as a duplicate of this issue. ***
Comment 10 dlipin 2009-03-20 15:12:00 UTC
Should be fixed in 
http://hg.netbeans.org/main/rev/cafb75f70851
Comment 11 dlipin 2009-03-24 10:58:13 UTC
*** Issue 160989 has been marked as a duplicate of this issue. ***