This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 150975 - Rails server usage logging too detailed for GlassFish
Summary: Rails server usage logging too detailed for GlassFish
Status: VERIFIED FIXED
Alias: None
Product: ruby
Classification: Unclassified
Component: Rails (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Erno Mononen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 09:21 UTC by Jan Chalupa
Modified: 2008-10-24 04:13 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Chalupa 2008-10-22 09:21:53 UTC
The information included in the Rails-related usage log events (USG_PROJECT_CREATE_RAILS and USG_PROJECT_CONFIG_RAILS)
is unnecessarily detailed in the case of GlassFish as the deployment target. Only the kind of the rails server should be
logged, which is the case for WEBRICK and MONGREL. For GlassFish, however, the full GF install path is logged. This data
might be considered sensitive by users.
Comment 1 Erno Mononen 2008-10-22 15:41:59 UTC
Increasing the priority, should be fixed for 6.5.
Comment 2 Erno Mononen 2008-10-22 16:25:52 UTC
Fixed in changeset #efc87167153d, will push tomorrow. The server type is now logged as follows (obviously the version 
numbers for GF Gem and Mongrel may differ, but for WEBrick there isn't a version number):

GF V3:
  <param>GlassFish V3 Prelude</param>
GF V3 Gem:
  <param>GlassFish Gem 0.3.1</param>
Webrick:
  <param>WEBrick</param>
Mongrel:
  <param>Mongrel 1.1.5</param>

The code now relies on the display name of the server, which isn't too nice (since there is no contract on what exactly 
the display name should be), but should be an acceptable solution for 6.5, in particular as currently the API doesn't 
offer a clean way for getting the necessary info for all server types. I'm cc'ing Peter, please notify me if you do any 
changes in display names for GF and I'll update the usage logging code accordingly.
Comment 3 Jan Chalupa 2008-10-22 20:43:39 UTC
Thanks. Actually, the display name is fine. We use it in other places for the logging purposes.
Comment 4 Erno Mononen 2008-10-23 13:17:08 UTC
The fix is now integrated in build #4134 -- Honzo, can you please verify?
Comment 5 Jan Chalupa 2008-10-23 15:42:22 UTC
Verified in build #4136.
Comment 6 Quality Engineering 2008-10-24 04:13:50 UTC
Integrated into 'main-golden', will be available in build *200810240201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/efc87167153d
User: Erno Mononen <emononen@netbeans.org>
Log: #150975: Rails server usage logging too detailed for GlassFish