This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 150626 - New testrunner causes transactional rails test to not be transactional
Summary: New testrunner causes transactional rails test to not be transactional
Status: VERIFIED FIXED
Alias: None
Product: ruby
Classification: Unclassified
Component: Testing (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Erno Mononen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-19 04:23 UTC by superchris
Modified: 2008-10-21 14:05 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Fixed version of nb_test_mediator.rb (46 bytes, text/plain)
2008-10-19 04:24 UTC, superchris
Details
nb_test_mediator.rb (8.46 KB, text/plain)
2008-10-20 15:40 UTC, superchris
Details

Note You need to log in before you can comment on or make changes to this bug.
Description superchris 2008-10-19 04:23:31 UTC
Running rails tests in the new test runner are not transactional even with use_transactional_fixtures set to true.  The
reason is that code in nb_test_mediator.rb is adds an inherited method to Test::Unit::TestCase without delegating to
super, which causes class_inheritable_attributes to be broken for this class.  Attached is a fixed version.
Comment 1 superchris 2008-10-19 04:24:04 UTC
Created attachment 72205 [details]
Fixed version of nb_test_mediator.rb
Comment 2 Erno Mononen 2008-10-20 09:46:18 UTC
Increasing priority, I think this should be fixed for 6.5. Apparently you attached a wrong file, but based on your blog 
post I assume that the patch added calls to the original inherited method and to super, right? 
Comment 3 Erno Mononen 2008-10-20 09:59:05 UTC
Forgot to actually increase the priority. I think this is a stopper for FCS (probably not for RC1 though).
Comment 4 Petr Blaha 2008-10-20 14:55:45 UTC
Please, go ahead and do the fix in trunk/verification and push the change in release65. Thanks
Comment 5 superchris 2008-10-20 15:40:50 UTC
Created attachment 72277 [details]
nb_test_mediator.rb
Comment 6 Erno Mononen 2008-10-20 16:53:16 UTC
Thanks. I pushed the fix to trunk, changeset http://hg.netbeans.org/main/rev/957d0a695e3a. Marking as fixed, can you 
please verify (i.e. change the resolution to verified) this so that I can transplant the fix to the 6.5 clone?
Comment 7 Quality Engineering 2008-10-21 04:07:05 UTC
Integrated into 'main-golden', will be available in build *200810210201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/957d0a695e3a
User: Erno Mononen <emononen@netbeans.org>
Log: #150626: New testrunner causes transactional rails test to not be transactional
- special thanks to Chris Nelson who provided the patch
Comment 8 Martin Schovanek 2008-10-21 14:05:09 UTC
Verified in #200810210201 trunk build