This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 149737 - low performance of APTFileMacroMap.getMacro()
Summary: low performance of APTFileMacroMap.getMacro()
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Code Model (show other bugs)
Version: 6.x
Hardware: Sun All
: P2 blocker (vote)
Assignee: Alexander Simon
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2008-10-10 11:50 UTC by Alexander Simon
Modified: 2008-10-21 04:07 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Simon 2008-10-10 11:50:59 UTC
At parsing time method APTFileMacroMap.getMacro() is a hot spot.
For example:
- core of opensolaris 34%
- boost 22%
Improve the method performance.
Comment 1 Vladimir Voskresensky 2008-10-10 14:15:00 UTC
For me it is more P2 about responsiveness, than P4 about raw parsing, because APTFileMacroMap.getMacro() affects
responsiveness during editing. Fixing it can give us 3 times faster reparse of currently being edited file.
Please, evaluate once more
Comment 2 Alexander Simon 2008-10-10 14:25:16 UTC
fixed in release65_cnd_freeze, change sets:
http://elif.russia.sun.com/hg/release65_cnd_freeze/rev/dd600aebba33
http://elif.russia.sun.com/hg/release65_cnd_freeze/rev/60f1351129f4
Improved 20% parser performance.
Improved 66% parser performance on huge files (30,000 lines, for example ip.c from opensolaris kernel).
Comment 3 Vladimir Voskresensky 2008-10-13 11:18:25 UTC
fix is safe and correct.
Comment 4 soldatov 2008-10-13 11:23:11 UTC
No new problems in 'Inaccuracy' tests with this fix
Comment 5 Vladimir Voskresensky 2008-10-13 13:05:49 UTC
This bug needs to be integrated into 6.5, because it is base for SunStudio IDE which is the IDE used for big projects
and performance on big files is very critical
Comment 6 Alexander Pepin 2008-10-13 14:20:17 UTC
Performance of parsing gets improved for large projects.   
Comment 7 Alexander Simon 2008-10-13 14:22:04 UTC
fixed in main trunk, change set:
http://hg.netbeans.org/main/rev/8816f16a43ea
Comment 8 Quality Engineering 2008-10-14 05:56:38 UTC
Integrated into 'main-golden', will be available in build *200810140201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/8816f16a43ea
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixed: IZ#149737:low performance of APTFileMacroMap.getMacro()
Comment 9 Alexander Simon 2008-10-20 17:46:35 UTC
additional fix, change set:
http://hg.netbeans.org/main/rev/2f73fea10407
fix improved parsing performance of kernel of opensolaris project on 5%.
Comment 10 Quality Engineering 2008-10-21 04:07:46 UTC
Integrated into 'main-golden', will be available in build *200810210201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/2f73fea10407
User: Alexander Simon <alexvsimon@netbeans.org>
Log: fixed: IZ#149737:low performance of APTFileMacroMap.getMacro()
- additional fix (improve performance on 5%)