This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 149044 - NULL value can't be edit
Summary: NULL value can't be edit
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Show Data (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Shansi 11
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-03 11:08 UTC by Roman Mostyka
Modified: 2008-10-10 05:58 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Mostyka 2008-10-03 11:08:46 UTC
1. Connect to some DB, rightclick some of it's table and choose "View Data".
2. Press "Insert Record" button.
3. Press Ctrl + 0 for field, which can have value NULL.

Result: Text Field for this field becomes uneditable and it has value NULL. It's impossible then change this value, only
if close and then reopen dialog.
Comment 1 jawed 2008-10-03 13:46:08 UTC
We can change the NULL value set in a column by again pressing Ctrl + 0. However when mouse is clicked on that
particular column(NULL) we will not see mouse pointer but that column becomes editable and NULL is removed. You can also
use SHIFT + TAB and TAB key to go back and forth.
Comment 2 Roman Mostyka 2008-10-03 16:30:51 UTC
We can change by pressing Ctrl + 0, but we can't using mouse. It looks like A11Y issue.
Comment 3 jawed 2008-10-06 12:03:31 UTC
When mouse is clicked on a particular column, and then press Ctrl + 0 if the column is already NULL, it is removed.
However you will not see mouse pointer on that column but mouse pointer points to that column only.
Comment 4 Roman Mostyka 2008-10-06 12:09:14 UTC
I meant that it is impossible to change value by double-click, for example.
Comment 5 _ ahimanikya 2008-10-06 12:25:44 UTC
We did not intent to make it editable by double clicking. This feature works as expected.
Comment 6 Roman Mostyka 2008-10-06 15:19:36 UTC
You didn't intend, but it will be better if customer will work with product what customer likes, not we like.
So I think that work will be much easier and faster if we implement all possible ways of work. And also double-click on
cell should make it editable.
Comment 7 _ ahimanikya 2008-10-07 06:11:13 UTC
I don't agree with you, it is not possible and not required to implement all possible way. As long as we have an elegant
way of doing things and we document it properly it will be acceptable to most of the customers. When you are referring
customer please provide pointers. What made you feel that the customer will not like what we have. If you have any
general NB guideline for field editing, send me those pointers.
Comment 8 Roman Mostyka 2008-10-07 07:59:39 UTC
"it is not possible ... to implement all possible way". If way is possible, then we can implement it.
If customers are satisfied with current product does it mean for you that we shouldn't do anything? I don't agree.
It is a common way to work using mouse and keyboard simultaneously, so it is much better to have possibility to change
values by keyboard and mouse. By the way, why <NULL> value becomes uneditable at all? Why we can't just insert NULL
value and leave this field editable?
Comment 9 _ ahimanikya 2008-10-07 08:48:32 UTC
Why do you want to edit if you have mark it as NULL? If you want to edit, Use CTRL+0 to enable the field for editing.
BTW, I am not sure which hypothetical customer you are referring to here. 

I need more justification. Are you saying all editing features have to have a way to edit both by using keyboard and
mouse? If that is true, please provide me a standard guideline that all components in NB adhere to.
Comment 10 Roman Mostyka 2008-10-07 09:19:00 UTC
Why do you want to edit if you have mark it as NULL?
Because customer can mark field by mistake? Do you agree?

If you want to edit, Use CTRL+0 to enable the field for editing.
But if it is more usual and convenient for me to click mouse?
If we think only about how it is easier for us to make things, but not what is better for customers, we will lose
customers. So we have to think about different ways making customer's life easier. If you are interesting only in
standard guideline that all components in NB adhere to, then it is different situation, but my task is help developers
make product better and cooperate with customers to make them happy. And if there is no any guideline, it doesn't mean
that there is no work, at least for me. I have to investigate further anyway and make IDE better.
And why you don't want to fix this issue so much? It is hard to fix? I don't think so.
Comment 11 _ ahimanikya 2008-10-07 10:05:14 UTC
Correct, then use CTRL+0 to enable editing. You will be enabling it to type some text anyway (The intent is not to
eliminate the keyboard and we don't provide a on-screen keyboard)

You are making assumptions, when did I say whether it is difficult to implement or not? I don't agree with your
suggestion in the 1st place. I don't shy away from doing things regardless of how difficult it is to implement, if I am
convinced. You have not convinced me yet.

Its not about making your hypothetical customer life easier, I need to clearly understand why I have to provide both
mouse and keyboard options for all the editing features. 

I completely agree that you are trying to help developers to deliver better product, but that does not mean everything
that say will be accepted without question. Just because its easy to implement, I am not going to jump into it unless
you justify your point with a concrete answer.
Comment 12 Roman Mostyka 2008-10-07 12:45:52 UTC
OK. :) I'll try to convince you. ;)
I didn't make the assumption that it is difficult to implement, I just asked "is it hard to fix?. If yes, then we can
postpone fix of this issue since the fix can be risky.
How much do you use mouse and keyboard? I use a lot. I use keyboard, mouse and shortcuts to make my job faster and
easier. And for me it was much easier to click on field and then edit it, but not press Ctrl+0.
Moreover, as I wrote, I don't understand at all why field with <NULL> value becomes uneditable. Why? It can mislead
customer that this field can't be edited after NULL value is entered. Not all customers will read text at the bottom and
press Ctrl+0, some of them just can start to think that NetBeans doesn't fit for them.
If we have only one way to change NULL value (Ctrl+0) it looks like we think that our way is the best, but not all
customers will agree with us, I heard compliances many times about such situations (not exactly about DB area and of
course not about NULL value ;) ).
So if it isn't difficult to implement, why we can't just implement this and let customers decide how to work themselves?
If pressing Ctrl+0 fits for them, they will use this shortcut, if it doesn't, then will use mouse and keyboard (my case,
since for me it's more convenient to use keyboard and mouse, I found this issue and filed it).
If you still don't agree, please explain me why field with <NULL> value have to be uneditable and why using mouse is
prohibited in this case.
By the way, it really looks like accessibility issue, since there is no way to work with mouse.
Sorry for many letters. :)
Comment 13 _ ahimanikya 2008-10-09 13:27:59 UTC
personally I don't think this was required, but anyway, on double clicked now the field will be enabled for editing.

http://hg.netbeans.org/main/rev/ed8a8d9ad25a
Comment 14 Roman Mostyka 2008-10-09 14:28:25 UTC
Verified with build 081009.
Comment 15 Quality Engineering 2008-10-10 05:58:28 UTC
Integrated into 'main-golden', will be available in build *200810100201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/ed8a8d9ad25a
User: ahimanikya@netbeans.org
Log: Issue #149044  NULL value can't be edit