This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 147843 - AssertionError: SaveCookie must be present on org.netbeans.modules.form.RADComponentNode@cd73af[Name=Form, displayName=[JPanel]]. See http://www.netbeans.org/issues/show_bug.cgi?id=68285 for details o
Summary: AssertionError: SaveCookie must be present on org.netbeans.modules.form.RADCo...
Status: RESOLVED WORKSFORME
Alias: None
Product: webservices
Classification: Unclassified
Component: JAX-WS (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Milan Kuchtiak
URL: http://statistics.netbeans.org/except...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-22 10:34 UTC by xykon
Modified: 2010-10-04 08:12 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter: 151

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xykon 2008-09-22 10:34:48 UTC 
Build: NetBeans IDE 6.5 Beta (Build 200808111757)
VM: Java HotSpot(TM) Client VM, 11.0-b15, Java(TM) SE Runtime Environment, 1.6.0_10-rc2-b31
OS: Windows XP, 5.1, x86

User Comments:
xykon: I saved a newly created Panel with some Swing Controls.

sunbiz: Saving file

kawazu428: added webmethod to a jax-ws service...

ltcmddata: Saving java-code.

xykon: I saved a newly created Panel with some Swing Controls.



Stacktrace: 
java.lang.AssertionError: SaveCookie must be present on org.netbeans.modules.form.RADComponentNode@cd73af[Name=Form, displayName=[JPanel]]. See http://www.netbeans.org/issues/show_bug.cgi?id=68285 for details on overriding org.netbeans.modules.form.RADComponentNode.getCookie correctly.
        at org.openide.actions.SaveAction.performAction(SaveAction.java:76)
        at org.openide.util.actions.NodeAction$DelegateAction$1.run(NodeAction.java:581)
        at org.netbeans.modules.openide.util.ActionsBridge.doPerformAction(ActionsBridge.java:77)
        at org.openide.util.actions.NodeAction$DelegateAction.actionPerformed(NodeAction.java:577)
        at org.openide.windows.TopComponent.processKeyBinding(TopComponent.java:1007)
        at javax.swing.JComponent.processKeyBindings(JComponent.java:2895)
Comment 1 Jiri Rechtacek 2008-09-22 17:42:09 UTC 
Jesse, could you evaluate this? You are author this assertion check. I'm not sure if there is a problem on actions or on
API client side. Thanks
Comment 2 Exceptions Reporter 2008-09-22 22:41:26 UTC 
This issue has already 10 duplicates 
see http://statistics.netbeans.org/exceptions/detail.do?id=151
Comment 3 Jesse Glick 2008-09-22 23:01:54 UTC 
Possibly a race condition, e.g. invoking Save twice in rapid succession? Is it reproducible? I don't remember anything
about it, though issue #68285 has some information. According to that issue, the bug may actually be in the Node impl.
Looking at FormNode (parent of RADComponentNode and FormRootNode), I see that it overrides getCookie; updateCookies
ought to fire a change, but it is not obvious that this is actually called reliably. See issue #77210 regarding the
messiness of SaveCookie.

The bug is also reported in JspNode, JsfJspDataNode, JaxWsDataNode, and PropertiesDataNode. Of these, only JaxWsDataNode
overrides getCookie, so the problem cannot be limited to faulty DataNode subclasses.
Comment 4 Jiri Rechtacek 2008-09-23 09:10:42 UTC 
Please, review your FormNode.getCookie impl which probably cause many of duplicates at 
http://statistics.netbeans.org/exceptions/detail.do?id=151 and then reassign to JaxWsDataNode to solve rest of them.
Comment 5 Jesse Glick 2008-09-23 18:43:56 UTC 
As I said before, some reports show this problem associated with subclasses such as JspNode which do not do anything
special with cookies, so the problem cannot be solely the fault of DataObject subclasses - though there may (or may not)
be anything wrong in FormNode and/or JaxWsDataNode as well.
Comment 6 Tomas Pavek 2008-09-24 10:41:33 UTC 
Form editor fired the cookie change on the node asynchronously (invoked later on EDT). This could be the problem. I've
changed that to fire immediately when notified from data object.

http://hg.netbeans.org/main/rev/7fe0e573ba2a

I've also looked at PropertiesDataNode and it does not do anything with cookies - so nothing to do here.

Reassigning to JaxWsDataNode.
Comment 7 Quality Engineering 2008-09-24 17:31:59 UTC 
Integrated into 'main-golden', will be available in build *200809241401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/7fe0e573ba2a
User: Tomas Pavek <tpavek@netbeans.org>
Log: #147843: fire cookie change on selected node immediately
Comment 8 Denis Anisimov 2010-10-04 08:12:25 UTC 
No problem with web service now.