This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 145670 - Toggle comment not available
Summary: Toggle comment not available
Status: RESOLVED WONTFIX
Alias: None
Product: editor
Classification: Unclassified
Component: Actions/Menu/Toolbar (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Miloslav Metelka
URL:
Keywords: RANDOM
Depends on:
Blocks:
 
Reported: 2008-08-30 09:19 UTC by nigel_bris
Modified: 2014-03-01 06:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screenshot showing the diff pane and disabled 'Toggle Comment' action (444.56 KB, image/png)
2008-10-01 08:12 UTC, Vitezslav Stejskal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nigel_bris 2008-08-30 09:19:20 UTC
When in the difference view you can edit text but cannot use the toggle comment (cmd+/). This sometimes can be useful... 

Environment: RUBY IDE
Comment 1 nigel_bris 2008-09-01 09:22:21 UTC
Just noticed that this feature works on version 6.1
Comment 2 Maros Sandor 2008-09-01 09:28:07 UTC
It works for me in java, ruby please evaluate.
Comment 3 Torbjorn Norbye 2008-09-30 03:40:45 UTC
I tried this with 6.5 daily build and it works -- I tested both a Ruby file and an ERB file, and the version control I
was using (for the diff view) was Mercurial.

Is this still broken for you? If so, which version control system, and what does the file you're attempting to toggle
comment in look like?
Comment 4 nigel_bris 2008-09-30 04:35:00 UTC
Just downloaded the latest 20080930010732... Version control is subversion

cmd+/ does not appear to work in .rb and .rhtml files

The view I am in the_file_name.rb[diff]

In the "Source" drop down menu "Toggle Comment" is greyed out...
Have attached screen screen grab showing this

Hope this helps
Comment 5 Torbjorn Norbye 2008-09-30 17:14:57 UTC
I tried again - and this time it didn't work for me either.

There is something weird going on about the Toggle Comment action. We've had many bugs in the past where people said it
didn't work. I would confirm that it didn't work. Then it started working again. Then it stopped working.  Perhaps there
is some magic involved with Toggle Comment because it superceded the Comment and Uncomment actions and might have some
special logic to delegate to these.

In any case, I don't think there is anything special about Ruby for this. The action works in plain files, so if there's
something funky going on with diff views, I think it must either be with the way the diff view sets up a new pane, or
the editor action itself. I'm reassigning to the editor to evaluate further.

By the way, it looks like the screenshot itself got added to issue 145706 instead of this one, so next evaluator, look
there instead.
Comment 6 Vitezslav Stejskal 2008-10-01 08:12:50 UTC
Created attachment 70948 [details]
Screenshot showing the diff pane and disabled 'Toggle Comment' action
Comment 7 Vitezslav Stejskal 2008-10-01 08:18:24 UTC
Thanks for the evaluation. I attached the screenshot here. I think we'll have to have a closer look to understand what's
wrong. The action itself is not special, but the diff pane is and the way how it propagates keymap is likely to be as
well, which can obviously result in both the action not functioning and being grayed out in the main menu.
Comment 8 Sergey Petrov 2009-04-29 13:32:11 UTC
It seems initialy issue was filed for collapse folds action (ctrl - minus) and not about toggle comment action
(ctrl-shift-c and source|toggle comment).
can't reproduce a problem with last action but first one do not work in diff panel and may not work by design.
Comment 9 Miloslav Metelka 2012-09-19 13:27:38 UTC
Unfortunately Ruby IDE is no longer maintained -> wontfix.
Comment 10 Quality Engineering 2014-03-01 06:14:24 UTC
Integrated into 'main-silver', will be available in build *201403010001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/c331f7933e20
User: Emmanuel Hugonnet <ehsavoie@netbeans.org>
Log: Fixing bug #145670 adding missing resource bundle key.
Downgrading version for Databse Explorer so it is compatible with Netbeans 8.0 RC1