This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 143507 - Get rid of deprecated org.netbeans.modules.editor.deprecated.pre61settings
Summary: Get rid of deprecated org.netbeans.modules.editor.deprecated.pre61settings
Status: RESOLVED WORKSFORME
Alias: None
Product: cnd
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: Sun All
: P4 blocker (vote)
Assignee: Vladimir Kvashin
URL:
Keywords:
Depends on:
Blocks: 143506
  Show dependency tree
 
Reported: 2008-08-11 17:36 UTC by Vladimir Kvashin
Modified: 2008-11-21 11:29 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Kvashin 2008-08-11 17:36:03 UTC
Now 10 cnd modules refer to the org.netbeans.modules.editor.deprecated.pre61settings module, which is deprecated.
This module corresponds to advanced options that is dropped now.
Comment 1 Vladimir Kvashin 2008-08-11 17:36:57 UTC
The negative consequences of such situation is

1) There are startup warnings in console.

2) Cnd unit tests run extremely slow now - see
http://www.netbeans.org/issues/show_bug.cgi?id=143506

Profiler shows that about 90% of time is spent in 
org.netbeans.modules.editor.settings.storage.Utils.load(FileObject, StorageReader, boolean)

which is in turn called from two methods:

org.netbeans.modules.editor.deprecated.pre61settings.EditorPreferencesInjector.propertyChange(PropertyChangeEvent)
org.netbeans.modules.editor.deprecated.pre61settings.KeybindingsInjector.access$000(KeybindingsInjector)

I don't think it's reasonable to ask somebody making this calls faster (I just don't believe anybody will speed up
deprecated stuff). I think fixing this issue will speed up cnd unit tests about 10 times.
Comment 2 Vladimir Kvashin 2008-08-13 12:59:32 UTC
Fixed for o.n.m.cnd.completion module
http://hg.netbeans.org/main/rev/03847633bfde

Note that as soon it is fixed for all modules, 
the following temporary fixup should be undone
http://hg.netbeans.org/main/rev/919d54961b38
Comment 3 Vladimir Kvashin 2008-09-16 16:51:24 UTC
After partial fix I don't see any really negative end user effect of this issue. 
Downgrading to P4.

Comment 4 Vladimir Kvashin 2008-11-21 11:29:48 UTC
already fixed