This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 142592 - Signature test fails
Summary: Signature test fails
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords: TEST
Depends on:
Blocks:
 
Reported: 2008-08-01 15:46 UTC by Andrei Badea
Modified: 2008-09-05 09:37 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Badea 2008-08-01 15:46:34 UTC
After changeset 41b7892a3129, the signature test fails with no visible reason. A final class (Quoter) which the client
cannot instantiate was turned into an abstract one, which the client still cannot instantiate. There doesn't seem to be
any incompatibility as far as the client is concerned.

APIChangeTest Report

Base version:   1.24.1
Tested version: 1.25.0

Missing Classes
---------------

org.netbeans.api.db.sql.support.SQLIdentifiers$Quoter:      class public static
org.netbeans.api.db.sql.support.SQLIdentifiers$Quoter

Incompatible change: Class is not protected in the new implementation
---------------------------------------------------------------------

org.netbeans.api.db.sql.support.SQLIdentifiers$Quoter:      class public static
org.netbeans.api.db.sql.support.SQLIdentifiers$Quoter
org.netbeans.api.db.sql.support.SQLIdentifiers$Quoter:      class public static abstract
org.netbeans.api.db.sql.support.SQLIdentifiers$Quoter

Incompatible change: Class is interface in the new implementation
-----------------------------------------------------------------

org.netbeans.api.db.sql.support.SQLIdentifiers$Quoter:      method public final java.lang.String
org.netbeans.api.db.sql.support.SQLIdentifiers$Quoter.quoteIfNeeded(java.lang.String)
Comment 1 Ivan Sidorkin 2008-08-01 16:14:00 UTC

*** This issue has been marked as a duplicate of 142588 ***
Comment 2 Andrei Badea 2008-08-01 16:42:16 UTC
Issue is still valid, because I only disabled the test.
Comment 3 Quality Engineering 2008-08-02 15:57:01 UTC
Integrated into 'main-golden', available in build *200808021401* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/17dfb1b81097
User: Andrei Badea <abadea@netbeans.org>
Log: #142592: Signature test fails: temporarily disabling the test
Comment 4 Andrei Badea 2008-08-05 16:17:14 UTC
I hope I understood correctly that Yarda is going to fix the testing infrastructure. Please reassing back so that I can
re-enable the test.
Comment 5 Jaroslav Tulach 2008-08-07 10:45:50 UTC
I am trying to write a test. So far unsuccessfully:
http://hg.netbeans.org/apitest/rev/224474408faa
Comment 6 Jaroslav Tulach 2008-08-28 10:34:58 UTC
Finally the test fails in fabf8512ec0b
Comment 7 Jaroslav Tulach 2008-08-29 10:03:32 UTC
apitest is fixed in http://hg.netbeans.org/apitest/rev/f313efa02a93
now I need to integrate the binary to trunk.
Comment 8 Jaroslav Tulach 2008-08-29 13:54:41 UTC
ffebdf4a6c4b
Comment 9 Quality Engineering 2008-08-30 05:39:19 UTC
Integrated into 'main-golden', available in build *200808300201* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/ffebdf4a6c4b
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #142592: Signature tests in db module work. We support additions of abstract methods to non-subclassable classes.
Comment 10 Andrei Badea 2008-09-05 09:37:23 UTC
Thank you.