This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 142175 - ESC no longer closes sliding windows
Summary: ESC no longer closes sliding windows
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords: REGRESSION
: 142055 142228 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-07-30 01:50 UTC by Jesse Glick
Modified: 2008-12-22 14:57 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2008-07-30 01:50:28 UTC 
In 080728 (but not 080725), the ESC key no longer causes sliding windows to be slid back in. P2 since it is a regression
and affects everyday keyboard usage. Not sure what caused it since updating to 080725's version (#85d0fe23718b) and
building core.windows does not fix the problem.
Comment 1 Jesse Glick 2008-07-30 02:06:18 UTC 
Finally found it using

hg log -v -p -P 85d0fe23718b -M {core.*,o.n.core,o.n.bootstrap,openide.*}/src

changeset:   92054:3ac5c8119d58
user:        Jaroslav Tulach <jtulach@netbeans.org>
date:        Fri Jul 25 11:14:56 2008 +0200
files:       openide.explorer/src/org/openide/explorer/view/TreeView.java
openide.explorer/test/unit/src/org/openide/explorer/view/NavigationTreeViewTest.java
description:
Fixing TreeView to not call default action after pressing Enter with readAccess, but without it.

Reverting this patch fixes the problem. In fact the problem affects Projects but not Output Window. I guess the code

for (Object key : getActionMap().allKeys()) {
    Action a = getActionMap().get(key);
    if (a.getClass().getName().contains("TreeUI")) {
        getActionMap().put(key, new GuardedActions(99, a));
    }
}

is breaking the binding of ESC.
Comment 2 Jiri Rechtacek 2008-07-30 10:03:43 UTC 
*** Issue 142055 has been marked as a duplicate of this issue. ***
Comment 3 Antonin Nebuzelsky 2008-07-30 10:30:11 UTC 
Jarda on vacation this week. Stando, take care of that.
Comment 4 Stanislav Aubrecht 2008-07-30 14:23:49 UTC 
taken care of as ordered: 7956ca72143e

in fact, it's more like a hotfix than a proper fix, jarda should review it when he gets back from holidays.
btw, jarda's patch breaks ESC key handling for all sliding views as long as a treeview component has input focus
Comment 5 Quality Engineering 2008-07-31 04:19:23 UTC 
Integrated into 'main-golden', available in build *200807310201* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/7956ca72143e
User: S. Aubrecht <saubrecht@netbeans.org>
Log: #142175 - ESC no longer closes sliding windows
Comment 6 Jiri Rechtacek 2008-08-01 11:44:50 UTC 
*** Issue 142228 has been marked as a duplicate of this issue. ***
Comment 7 Petr Chytil 2008-09-30 10:24:10 UTC 
Verified in:
Product Version: NetBeans IDE Dev (Build 200809300201)
Java: 1.5.0_16; Java HotSpot(TM) Client VM 1.5.0_16-133
System: Mac OS X version 10.5.5 running on i386; MacCentralEurope; cs_CZ (nb)
Userdir: /Users/petr/.netbeans/dev