This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 141943 - I18N - some words in diagram options widget names not from bundle file
Summary: I18N - some words in diagram options widget names not from bundle file
Status: VERIFIED FIXED
Alias: None
Product: uml
Classification: Unclassified
Component: General (show other bugs)
Version: 6.x
Hardware: Sun All
: P2 blocker (vote)
Assignee: Trey Spiva
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2008-07-28 20:08 UTC by Ken Frank
Modified: 2008-08-18 21:32 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2008-07-28 20:08:06 UTC
in uml options for diagrams tab, the widgets section on right has
names of them; some are not from bundle file; this list not meant to
cover all - please check code

Default
Actor Figure
Lifeline Box
Lifeline line
interaction operation
Extension Point Line
Comment 1 Trey Spiva 2008-08-04 17:58:30 UTC
Fixed

http://hg.netbeans.org/uml-main/rev/76a5ebfccf31
Comment 2 Trey Spiva 2008-08-04 18:40:59 UTC
Reviewed- Please let us know of any other strings.
Comment 3 Ken Frank 2008-08-15 07:04:08 UTC
using 0810 uml zip from trunk build of nb on smetiste.

besides the word Diagram, I don't see these words coming from bundle file
or if in bundle from pseudo localized.

what product jar and bundle within it has these words shown on options
section ? I can recheck. 

will reopen for now.
Comment 4 Ken Frank 2008-08-15 07:15:08 UTC
I think options tabs have changed since this was filed ?
I now see on the fonts and colors tabs, on right side
the names of widgets, which do come from bundle
and see on left side, the items under Type: dropdown,
that the items don't come from bundle except for word Diagram
yet on pallette, these words seem to come from bundle,

yet I think before, sometimes the names like AliasedType etc need
to stay in english due to uml spec.

so perhaps this was reopened not correctly, but I am not sure
of where original issue was seen, since dont see a Diagrams tab in the options.

please advise what options area relates to this fix and I can rechcek.

also, should the dropdown items in Type of fonts and colors tab 
be translatable ?

ken.frank@sun.com
Comment 5 Trey Spiva 2008-08-15 14:58:58 UTC
The items in the combo box are retrieved from a layer file.  So, we could certainly put the names in a bundle file.  However like you said, except for 
"Diagram" the others are really UML names.  Therefore they should not be translated.  However it would be nice to have "Derivation Classifier" instead of 
"DerivationClassifier".  So it would be best to put at least some of the names in the the bundle file and mark them as #NOI18N.

As for the original issues it was talking about the strings in the "Widgets" list box.

Since all but the names in the combo box, except for "Diagram", are not to be translated I am going to mark this issue as fixed.
Comment 6 Ken Frank 2008-08-15 16:13:28 UTC
this makes sense.

am reopening however since found some more items
in the widget list that not from bundle - if better
to have new issue that is ok too

Extension Point Label
interaction operator
Actor figure
Lifeline Box
Lifeline Box name and classifier
Lifeline line
Comment 7 Trey Spiva 2008-08-15 17:26:00 UTC
It appears that you build is old, because these have been in bundles for a week or two now.

I just tested it by changing the bundle values and making sure the UI represented the change.
Comment 8 Ken Frank 2008-08-15 17:30:04 UTC
am using 0810 nb trunk build; I install it then get from the
zip/modulecluseters dir, the uml zip and unzip
which saves time not needing to do uc install each day.

could it be that trunk build does not get the most current uml source
each day ?
Comment 9 Trey Spiva 2008-08-15 17:38:29 UTC
The following bundle files are the files that contain these keys.

uml.diagrams/src/org/netbeans/modules/uml/diagrams/actions/sqd/Bundle.properties
uml.diagrams/src/org/netbeans/modules/uml/diagrams/nodes/sqd/Bundle.properties
uml.diagrams/src/org/netbeans/modules/uml/diagrams/nodes/usecase/Bundle.properties
Comment 10 Trey Spiva 2008-08-15 17:50:03 UTC
I should have been in the trunk for at least a few days.
Comment 11 Ken Frank 2008-08-15 18:07:54 UTC
I'll get current trunk this weekend and recheck -
2 of those bundles are in 0810, one is not but
it means even the 2 that are there might not be up do date


but these labels are in 0814 trunk diagrams jar bundle files so am sure it will be ok.
Comment 12 Ken Frank 2008-08-18 21:32:44 UTC
all things mentioned under widgets list come from bundle except
Transition Label

but am confused since many of the items on left side under the type:
dropdown now come from bundle, but i thought those words
were not supposed to be translated as reserved words of uml
and that is ok - thus should some of those words really not
be from bundle file now ? (again its about the left side under
Type: dropdown, not about the subject of this issue which is right side
under Widgets:

will verify this; if Transition Label can be added to bundle that would
be helpful or can file separate issue; whatever is best.

ken.frank@sun.com