This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 14147 - The IDE creates instances all the toolbars regardless of their visibility
Summary: The IDE creates instances all the toolbars regardless of their visibility
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: Petr Nejedly
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2001-08-02 16:53 UTC by Petr Nejedly
Modified: 2008-12-22 16:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nejedly 2001-08-02 16:53:52 UTC
I also found out that the IDE creates *all* toolbars during startup
regardless if they are visible or not.  To avoid creating the palette I
had to go to Options -> Toolbars and delete the Palette folder there.
Just right-click on the main window and hide the Palette does not have
any effect.  Imagine what it means performance-wise for the
Enterprise-type IDEs which have tons of pre-defined toolbars!  We must
fix this performance bug.  The culprit code is in Toolbar.java and
ToolbarPool.java.
Comment 1 Jaroslav Tulach 2001-08-02 17:26:02 UTC
ToolbarPool.createInstance should be rewritten to work with cookies in
a lazy way. Instead of always calling instanceCreate it could use
instanceClass or instanceOf (after casting to InstanceCookie.Of)

That might help. Or the Toolbar class rewritten to just create its
instance and does not search for its content  until needed.
Comment 2 Jan Zajicek 2001-08-03 15:37:11 UTC
just changing subcomponent
Comment 3 _ ttran 2001-10-19 07:32:29 UTC
Petre, please fix this one.  We don't have any permanent owner of
toolbars in core
Comment 4 Petr Nejedly 2001-10-25 13:43:35 UTC
OK, after long faith with FolderInstance, I've found
quite elegant solution in openide part.
I need to test it more before commiting the change.

I'm also thinking about rewriting the storage stuff
in the core to simplify it significantly.
Comment 5 Petr Nejedly 2001-10-26 12:18:56 UTC
The eager creation of Toolbars is fixed.
The toolbars are still created but do not force their full
initialization unless needed, thus the work NOT done now is:
resolve DataObjects, get their cookies, get actions, load images.

The core's way of serializing to XML could still be reworked,
but this is another issue.
Comment 6 Petr Nejedly 2001-10-30 13:47:05 UTC
Verifying for myself ;-)
Comment 7 Quality Engineering 2003-07-01 16:28:18 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.