This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 139273 - Buttons in Insert Record dialog aligned incorrectly
Summary: Buttons in Insert Record dialog aligned incorrectly
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Show Data (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: _ ahimanikya
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-08 15:38 UTC by Andrei Badea
Modified: 2008-07-09 14:37 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Badea 2008-07-08 15:38:39 UTC 
All buttons should be on the right side, as it is common in other NetBeans dialogs. Moreover, the Execute button should
be named OK.

Moreover, you should not create your own JDialog's in NetBeans. Use DialogDescriptor and DialogDisplayer. You should
also not need to set the dialog parent, the NetBeans API's usually do that for you.
Comment 1 Andrei Badea 2008-07-08 16:30:21 UTC 
Same for ShowSQLDialog. There the OK button isn't even centered! Please move it to the right, and rename it to Close.
Comment 2 _ ahimanikya 2008-07-08 21:28:14 UTC 
Fixed.
http://hg.netbeans.org/dbdataview/rev/341d4b5fe533

Regarding DialogDescriptor and DialogDisplayer, not sure how I use them in Matisse, In fact I was using then for popups,
but there seems to be no easy way to set Cancel button as default. OK or YES get executed when user type escape. There
were some bug filed around this. Anyway, Please don't plug multiple issues into one report. That makes it difficult to
fix and checkin. 

Open a separate issue with some pointer how to use DialogDescriptor and DialogDisplayer, if you think we must follow
that; I also need to know how that will handle "escape"
Comment 3 Roman Mostyka 2008-07-09 14:37:26 UTC 
Verified with build 080709