This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 139248 - Bad UI of the Insert Record dialog
Summary: Bad UI of the Insert Record dialog
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Show Data (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: _ ahimanikya
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-08 13:08 UTC by Andrei Badea
Modified: 2008-07-09 14:50 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Dialog screenshot (6.75 KB, image/png)
2008-07-08 13:12 UTC, Andrei Badea
Details
Dialog screenshot (7.26 KB, image/png)
2008-07-08 15:50 UTC, Andrei Badea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Badea 2008-07-08 13:08:55 UTC
The font of the label at the top is larger than that of the rest of the dialog. Also, the dialog title should be shorter
and use capitalized nouns, like "Insert Record".
Comment 1 Andrei Badea 2008-07-08 13:11:43 UTC
Also, the Show SQL button displays an error message if data for all columns hasn't been entered. That is not the right
way to display an error message. Look at CreateDatabasePanel.java in the derby module for how to do it.

Upping priority to P2 since it makes NetBeans look unpolished.
Comment 2 Andrei Badea 2008-07-08 13:12:17 UTC
Created attachment 64079 [details]
Dialog screenshot
Comment 3 _ ahimanikya 2008-07-08 15:16:39 UTC
We are no longer displaying error messages, we just display info, if you still don't like it please explain with
example, so that I can understand it better.

Have fixed the title and font issues. See -->http://hg.netbeans.org/dbdataview/rev/88b681a87aba
Comment 4 Andrei Badea 2008-07-08 15:32:43 UTC
You should not use OS-specific font names:

+ <Property name="font" type="java.awt.Font" editor="org.netbeans.beaninfo.editors.FontEditor">
+ <Font name="Arial" size="12" style="0"/>
+ </Property> 
Comment 5 _ ahimanikya 2008-07-08 15:43:30 UTC
I am using Matisse. I am not sure how to make it OS Independent. 
Comment 6 Andrei Badea 2008-07-08 15:50:12 UTC
Created attachment 64096 [details]
Dialog screenshot
Comment 7 Andrei Badea 2008-07-08 15:58:34 UTC
See the attached screenshot. There is an error message in the SQL box, which should be displayed in red, like an error.
See how errors are displayed e.g. in the New Project wizard.

Regarding the font name, setting the font to the default value (right click on the font property in the Properties
window) should do.

Comment 8 _ ahimanikya 2008-07-08 16:08:41 UTC
THE QE folks has a different idea, they thought this is an info not error, I can make it as red.
Comment 9 Andrei Badea 2008-07-08 16:24:26 UTC
Actually:

- I used red as an example. It needs to use whatever the error color is. See desc2.
- you also need to display it in a separate label, so that it looks like error messages in other dialogs in NetBeans.

I think this is an error, not an info message. Just as not entering a package name when you create a Java class is an error.
Comment 10 Roman Mostyka 2008-07-08 16:38:15 UTC
Andrei, please read this: http://wiki.netbeans.org/InformationIcons
According to this document, if customer invokes dialog first time there should be prompt string, not error message.
Comment 11 _ ahimanikya 2008-07-08 18:21:12 UTC
So, Whats is the resolution?
Comment 12 Andrei Badea 2008-07-08 18:27:16 UTC
That looks like a proposal more than a specification that is already in effect. I will ask and let you know.
Comment 13 _ ahimanikya 2008-07-08 18:38:18 UTC
Fixed font issues : http://hg.netbeans.org/dbdataview/rev/11c07b392995

Since showing validation information is still under discussion I would like to deal with it separately. Most of the
Insert Record issues has been fixed.
Comment 14 _ ahimanikya 2008-07-08 21:43:22 UTC
Showing err messages in red is a very isolated issue, need to be addressed separately. As far as bad UI is concern, I
think we have all the fixes. Please reopen it you still think the UI still looks bad with steps to reproduce and/or
screenshorts.  
Comment 15 Roman Mostyka 2008-07-09 14:50:03 UTC
Verified with build 080709.