This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 139125 - SQL History: Insert button should be disabled if no statement is selected
Summary: SQL History: Insert button should be disabled if no statement is selected
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: SQL Editor (show other bugs)
Version: 6.x
Hardware: All Windows XP
: P3 blocker (vote)
Assignee: John Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-07 12:23 UTC by Roman Mostyka
Modified: 2008-08-08 15:43 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Mostyka 2008-07-07 12:23:33 UTC 
1. Execute some statements.
2. Open "SQL History" dialog.
3. Click "Insert" button.

Result: Semicolon is inserted. If there is no selected statement, then "Insert" button should be disabled.
Comment 1 John Baker 2008-07-15 02:10:55 UTC 
not a P2, lowering
Comment 2 John Baker 2008-08-04 03:51:59 UTC 
e44111e47a83
Comment 3 John Baker 2008-08-05 08:10:28 UTC 
That's odd.  I committed a fix e44111e47a83 and checked the changesets that are to be pushed e44111e47a83 was to be
included, then pushed, but apparently, this changeset wasn't pushed.
Comment 4 John Baker 2008-08-05 20:50:19 UTC 
remembered to push- should be fixed (in the trunk)
Comment 5 Quality Engineering 2008-08-06 04:26:45 UTC 
Integrated into 'main-golden', available in build *200808060201* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/e44111e47a83
User: John Baker <jbaker@netbeans.org>
Log: #139125 SQL History: Insert button should be disabled if no statement is selected`
Comment 6 Roman Mostyka 2008-08-07 15:34:44 UTC 
I'm still able to reproduce this issue with build 080807.
And I see changes from the changeset. Probably the fix was broken by the fix of another issue.
Comment 7 John Baker 2008-08-07 19:56:28 UTC 
yes, you're right, I had only made sure the button was disabled if no SQL has been saved
Comment 8 John Baker 2008-08-08 08:37:37 UTC 
a7170dc68719
Comment 9 Roman Mostyka 2008-08-08 10:49:46 UTC 
Verified with build 080808.
Comment 10 Quality Engineering 2008-08-08 15:43:51 UTC 
Integrated into 'main-golden', available in build *200808081401* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/a7170dc68719
User: John Baker <jbaker@netbeans.org>
Log: #139125 SQL History: Insert button should be disabled if no statement is selected