This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
1. Open SQL History and set 0 records to save. 2. Execute bunch of statements against different DBs. 3. Open SQL History again and set 10000 records to save. Result: All executed statements are in the list.
Can't reproduce. If you reset to 10000 then execute more statements then there will be > 0 statements appearing
John, as I wrote in steps to reproduce, first set 0, then execute bunch of statements and ONLY THEN set 10000 records to save. That's all. I execute statements with null, but after this, if I set more than 0, all statements, which were executed before this change (set to more than 0) are in the list. There is no need to execute any statement after change of number records to save. If you can't reproduce, try to reopen "SQL History" dialog.
I think it's fixed now http://hg.netbeans.org/main?cmd=changeset;node=16acdbb872cb 138847 is not quite fixed.
I still can reproduce this issue. The situation is better now, because statements appear in the list only after reopening of the "SQL History" dialog, before they appear right after set number to save.
http://hg.netbeans.org/main?cmd=changeset;node=02ff30b5c3b7
Integrated into 'main-golden', available in NB_Trunk_Production #344 build Changeset: http://hg.netbeans.org/main/rev/02ff30b5c3b7 User: John Baker <jbaker@netbeans.org> Log: #138850 SQL History: Not saved statements come back to the list
I still similar behavior. The difference now is that not all executed statements appears in the list, but only (all executed statements - 1). So I think the fix in the right direction. ;)
I see all executed statements listed. You're using the latest trunk build ? I'm not sure the fix went into the nightly build. If so, please provide the steps, thanks
I always use for verification IDE, which I build with fresh sources. I don't use daily builds, which are available on the web. And I see changes from the changeset. Here are the steps (they are almost the same): 1. Execute statement against some DB. 2. Open SQL History and set 0 records to save. 3. Execute bunch of statements against different DBs. 4. Open SQL History again and set 10000 records to save. 5. Close and reopen "SQL History" dialog. Result: All executed statements minus 1 are in the list.
I still can't reproduce. Once save statements is set to 0 , sql_history.xml file is cleared of all statements. Then upon resetting back to 10000 ( I tried typing in the value and clearing ), still no statements appear. At 10000, I executed more statements and the correct number of statements appears in the table.
if the same database is used then SQL is not saved is the limit is 0 Otherwise, if different databases are used then SQL is saved
Should be fixed now. I was removing only one statement when save limit was set to 0 http://hg.netbeans.org/main?cmd=changeset;node=2511874f2e74
Integrated into 'main-golden', available in NB_Trunk_Production #352 build Changeset: http://hg.netbeans.org/main/rev/2511874f2e74 User: John Baker <jbaker@netbeans.org> Log: #138850 SQL History: Not saved statements come back to the list
Verified with build 080729.