This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 13850 - <makenbm> should support OpenIDE-Module-Localizing-Bundle
Summary: <makenbm> should support OpenIDE-Module-Localizing-Bundle
Status: RESOLVED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 3.x
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Michal Zlamal
URL:
Keywords:
: 15222 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-07-23 19:07 UTC by Jesse Glick
Modified: 2001-10-09 10:49 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
Suggested jumbo patch (89.15 KB, patch)
2001-10-01 20:20 UTC, Jesse Glick
Details | Diff
Semicorrected patch (89.15 KB, patch)
2001-10-05 15:32 UTC, Jesse Glick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2001-07-23 19:07:13 UTC
...i.e. translate any manifest keys found in a localizing bundle to regular
manifest main attributes for use by Auto Update. So the task should ask for a
JAR rather than a manifest as it would need to open and scan contained bundles.
Comment 1 Jesse Glick 2001-08-15 23:54:12 UTC
(issues@autoupdate: please add comments if anything specific needs to
be done in order to support localized NBMs)
Comment 2 akemr 2001-08-16 08:56:42 UTC
I'm not sure..
Do you mean in nbm/info will be except of Info.xml Bundle.properties
files? And in Info.xml need to be localized:
-manifest section
-license text

How can AU client get localized texts in such case?
Comment 3 Jesse Glick 2001-08-19 13:16:48 UTC
I was more asking whether there was already some scheme for either
localizing a single NBM (to contain human-readable resources in more
than one locale) or to produce more than one NBM, one for each locale.
If there is such a convention already then I can help make the
<makenbm> task work well with it. Otherwise I would just have it
assume default locale.
Comment 4 Jesse Glick 2001-09-10 19:43:04 UTC
*** Issue 15222 has been marked as a duplicate of this issue. ***
Comment 5 Jesse Glick 2001-10-01 20:19:47 UTC
Since I got no reply on the question re. what to do for localized
NBMs, I will assume there is no convention for doing this and it does
not need to be supported. So just working on making OpenIDE-M-L-B be
understood for the base locale, which currently it is not, meaning
many modules are not including descriptions in their NBMs.

Attaching patch for Michal, which I think should be applied soon
(before branch). It covers:

1. Update to <makenbm>: manifest attr is deprecated in favor of module
attr, which points to a JAR file, which can then be read for a
localizing bundle if necessary.

2. Matching changes to MakeListOfNBM.

3. Bugfix in MakeListOfNBM: when nbm target was called and then
generate list later from same module, bogus file ".xml" added to
update list. Made code more robust.

4. <makenbm> better escapes XML-sensitive data.

5. <makenbm> excludes some useless manifest attributes from the info
file.

6. Removed some dead code in <makenbm> needed only for Ant 1.2.

7. Updates to nbbuild web pages giving new recommendations.

8. Updated every module build script to use module= and not manifest=.

9. Removed <description> from every module build script. Where
necessary, added matching OpenIDE-M-Long-Description to manifest or
localized bundle, if there was no description before.

10. A couple of random fixes to module build scripts.

Michal please review and hopefully apply the patch. I'm not sure if
this would have any effect on FFJ build scripts, hopefully you can
check that too.
Comment 6 Jesse Glick 2001-10-01 20:20:43 UTC
Created attachment 2781 [details]
Suggested jumbo patch
Comment 7 Michal Zlamal 2001-10-02 10:53:15 UTC
I'll go through it today.
Comment 8 Jesse Glick 2001-10-05 15:27:02 UTC
My apologies--the previous patch was not well-formed. Will attach new
(partially) corrected one and you should do this to apply it, I think
(Linux patch):

cd ..../nb_all
patch -u --verbose -p0 -l < /tmp/13850.diff

You can use --dryrun to see if it will succeed before actually doing
it. The critical switch is -l (ignore whitespace), as the patch turned
spaces into tabs (accidentally used cvs diff -t, bad me). Also one
block (for clazz/build.xml) was invalid, corrected in the new patch.
Comment 9 Jesse Glick 2001-10-05 15:32:36 UTC
Created attachment 2876 [details]
Semicorrected patch
Comment 10 Michal Zlamal 2001-10-05 15:52:17 UTC
thanks Jesse, I can apply your patch without any problems now.
If I have no problems I'll commit it into repository at Monday - pressuming Friday is not good day for such a big changes.
Comment 11 Michal Zlamal 2001-10-09 10:49:17 UTC
Patch was applied.