This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 137277 - Fix TreeUtilities according to latest compiler fixes
Summary: Fix TreeUtilities according to latest compiler fixes
Status: VERIFIED FIXED
Alias: None
Product: javafx
Classification: Unclassified
Component: Editor (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: David Strupl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-16 11:38 UTC by Alexey Butenko
Modified: 2008-09-09 18:48 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Butenko 2008-06-16 11:38:37 UTC
CB is failing, because of the following issue was fixed in compiler:
http://openjfx.java.sun.com/jira/browse/JFXC-1255

TreeUtilities can not be compiled.
Following fix will solve it:

--- a/javafx.source/src/org/netbeans/api/javafx/source/TreeUtilities.java       Mon Jun 16 08:59:37 2008 +0200
+++ b/javafx.source/src/org/netbeans/api/javafx/source/TreeUtilities.java       Mon Jun 16 14:30:35 2008 +0400
@@ -49,9 +49,9 @@ import com.sun.source.util.TreePath;
 import com.sun.source.util.TreePath;
 import com.sun.tools.javac.code.Symbol;
 import com.sun.tools.javac.code.Type;
-import com.sun.tools.javac.comp.Resolve;
 import com.sun.tools.javac.tree.JCTree;
 import com.sun.tools.javafx.api.JavafxcScope;
+import com.sun.tools.javafx.comp.JavafxResolve;
 import com.sun.tools.javafx.tree.JavafxPretty;
 import java.io.IOException;
 import java.io.StringWriter;
@@ -365,14 +365,15 @@ public final class TreeUtilities {
         if (scope instanceof JavafxcScope 
                 && member instanceof Symbol 
                 && type instanceof Type) {
-            Resolve resolve = Resolve.instance(info.impl.getContext());
+//            Resolve resolve = Resolve.instance(info.impl.getContext());
+            JavafxResolve resolve =JavafxResolve.instance(info.impl.getContext());
            return resolve.isAccessible(((JavafxcScope)scope).getEnv(), (Type) type, (Symbol) member);  
         } else 
             return false;
     }
 
     public boolean isStaticContext(Scope scope) {
-        return Resolve.isStatic(((JavafxcScope)scope).getEnv());
+        return JavafxResolve.isStatic(((JavafxcScope)scope).getEnv());
     }
 
     private static void log(String s) {
@@ -380,4 +381,4 @@ public final class TreeUtilities {
             logger.fine(s);
         }
     }
-}
\ No newline at end of file
+}
Comment 1 Alexey Butenko 2008-06-16 14:11:42 UTC
David ask me to apply the patch by myself.
So it is fixed.
Comment 2 David Strupl 2008-06-20 10:13:31 UTC
The build is still failing when using the correct javafxc.jar ... Reopenning ...
Comment 3 David Strupl 2008-06-20 10:18:07 UTC
Fixed by 687:2da42f0060e5

Alexei please use the following javafxc.jar:

jfxcompiler.jar.url=http://ceres.sfbay/hudson/job/JavaFX1.0/ws/dist/windows-i586/javafx-sdk-image/javafx-sdk1.0/lib/javafxc.jar

(in your nbbuild/user.build.properties) this one is for the preview release that we work on now. You were building
against the trunk version. We will switch to the trunk after the preview release ..
Comment 4 Lark Fitzgerald 2008-09-09 18:48:45 UTC
This is Old.  CB is working.