This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 137105 - Threading issues
Summary: Threading issues
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Show Data (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: _ ahimanikya
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-12 13:35 UTC by Andrei Badea
Modified: 2009-02-13 08:47 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Badea 2008-06-12 13:35:46 UTC 
The threading model of the data view panel is too asynchronous. Multiple actions can be executed in multiple threads at
the same time. Instead, all database work should take place in a single, dedicated thread. Moreover, starting threads
instead of using a thread pool is a NetBeans antipattern.

Some database calls are executed in the AWT event dispatching thread, like in the constructor of DataViewOutputPanel, or
ResultSetTablePanel.executeDeleteRow() or DataViewOutputPanel.insertActionPerformed().
Comment 1 _ ahimanikya 2008-06-22 19:56:23 UTC 
This is fixed. THE UI is also separated cleanly from the logical components. PLease review and let me know if you any
further input.

http://wiki.netbeans.org/attach/DatabaseShowDataModuleReview1/DataViewSuite.zip?version=18
Comment 2 Andrei Badea 2008-06-23 09:19:42 UTC 
Expect this will take me a while, since it's quite a big change to review. Much easier would have been if you had used 
the Hg repository and could point me to specific changesets. Have you?
Comment 3 _ ahimanikya 2008-06-23 09:50:40 UTC 
Sure. I have made some more changes that will be checked in today.

You can see the change set at http://hg.netbeans.org/dbdataview/, but this may not help much...
Comment 4 _ ahimanikya 2008-06-25 06:39:52 UTC 
To most of my knowledge this has been fixed. Let me know if you still see some threading issues.
Comment 5 Andrei Badea 2008-06-25 10:27:28 UTC 
Sure, I plan to look at the threading as part of the code review.
Comment 6 Andrei Badea 2008-06-25 10:28:03 UTC 
BTW, feel free to close if you consider it fixed.
Comment 7 _ ahimanikya 2008-06-25 11:12:53 UTC 
Fixed.  There were multiple checkins so not able to point to exact changeset number.
See  clone for review http://hg.netbeans.org/dbdataview/
Comment 8 mvanek 2009-02-13 08:47:21 UTC 
verified.
NetBeans IDE Dev (Build 200902120201)