This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 136927 - I18N - some OLH, web docs and template descriptors don't have meta charset tag
Summary: I18N - some OLH, web docs and template descriptors don't have meta charset tag
Status: VERIFIED FIXED
Alias: None
Product: usersguide
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: psmejkal
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2008-06-10 15:32 UTC by Ken Frank
Modified: 2008-10-06 17:57 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2008-06-10 15:32:07 UTC
translated docs need meta charset tag in translated documents; they now are able
to use utf-8 as encoding, whereas in past they needed to use a locale specific value;
whereas en documents don't need to have such a tag, although many do, since default
is to iso-8859-1.

However there are some olh, web docs and template descriptor files in various modules
that don't have such a tag, and it is needed.

If there would be different category for web docs and template descriptors,
please advise, but won't be able to analyze or file about template descriptors
for each module; would need some other way to communicate about it.
Comment 1 Patrick Keegan 2008-06-10 16:05:11 UTC
Ken F., I think it's OK if this issue serves as the main tracking mechanism for all of examples. It would be very
helpful if you identified specific templates where it needs to be taken care of.

And just to confirm, do we put in the charset metatag, even for files for which we are not sure of the encoding?
Comment 2 Ken Frank 2008-06-10 19:47:21 UTC
as to specific templates, I'd suggest some other communication from writers org to dev
team writers or those who handle such files, telling them its needed;
don't think each and every template file can be gone thru to analyze if
it has meta tag or not.


as for putting in meta charset tag, the value of encoding does not matter as long
as the tag is there and the encoding value is one known to work for english.

most files that use such tags use iso-8859-1, some use UTF-8, but the main thing
is that nb writers and dev are sure that use of such encoding values for english
is ok; again, not concerned here with encoding value for some other locale.

certainly if UTF-8 can be assured to work for english, then that would be first
choice since its used for other locales, but this can't be an absolute requirement
here.

and also, if use of UTF-8 value can't be assured for 6.5, thenperhaps another initiative/task of docs team could be to 
do what is needed codewise or otherwise so it could be used in the future.

ken.frank@sun.com
of UTF-8
Comment 3 Patrick Keegan 2008-06-17 17:51:39 UTC
Tomas, could you handle this? Please start with the web docs on netbeans.org and then continue with the help.
Comment 4 Tomas Kianicka 2008-06-20 11:55:24 UTC
I hope I can handle it. I'm starting with testwww/www/kb/60 and testwww/www/kb/61.
I'll try to switch all documents to UTF-8 and try to change metatags to be google-friendly.
(http://www.google.com/support/webmasters/bin/answer.py?answer=35264&hl=en#writegooddescriptions)
Comment 5 Ken Frank 2008-07-15 16:17:15 UTC
just checking on this as to prodcuct olh docs - will that be able to be done for 6.5 ?
(since this is about both olh docs and web/testwww docs)

ken.frank@sun.com
Comment 6 Patrick Keegan 2008-07-31 13:47:01 UTC
Petr, can you take this over? I believe Tomas has done the web docs, but he has not done the help.
Comment 7 Patrick Keegan 2008-08-11 19:01:43 UTC
Ken, Petr has started adding the charset tag for the help files. He is specifying UTF-8 in all files. Does it make a
difference if some files were not created in UTF-8. And if they were not created in UTF-8, would they have to be somehow
converted?
Comment 8 Ken Frank 2008-08-11 19:08:58 UTC
Patrick,

I don't know for sure; if its english and basic ascii character set it should
be ok, but for copyright sign or other special characters that might not
be part of basic ascii character set, then not sure.

However, before doing it, especially for those files that now have charset of iso-8859-1
I suggest that writers and/or developers of the different help docs be asked about it to make sure that it is ok
just from an english only/run in english locale point of view.

ken.frank@sun.com

Comment 9 psmejkal 2008-08-13 12:41:47 UTC
Added a charset tag where there wasn't and modified to utf-8 where already was.
Comment 10 Patrick Keegan 2008-08-14 20:22:09 UTC
Thanks for doing all of the help docs, Petr. I'm reopening this because we still haven't done the template descriptions,
sample projects, etc. Petr, I've sent you the list of folder offline to look in
Comment 11 Ken Frank 2008-08-15 02:48:28 UTC
template descriptors - thanks for doing those too.

sample projects - those are not translated and although it seems
utf-8 would be ok, suggest checking with dev teams first
about the html files in those that have no tag or 8859-1 tag
just to make sure its ok.

ken.frank@sun.com
Comment 12 Jesse Glick 2008-08-19 16:37:25 UTC
Adding

  <meta http-equiv="content-type" content="text/html; charset=UTF-8">

to the head of every HTML document used in samples etc. should be fine to my knowledge. But please try to follow
indentation patterns consistent with the rest of the document, particularly for sample *.html which will be copied into
user projects (i.e. templates).
Comment 13 Jesse Glick 2008-08-19 16:41:39 UTC
Also please avoid making gratuitous changes such as this one:

--- a/javahelp/src/org/netbeans/modules/javahelp/resources/notEnabledModule.html
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/notEnabledModule.html
@@ -1,6 +1,6 @@
 <html>
 <head>
-  <meta content="text/html; charset=UTF-8" http-equiv="content-type">
+	<meta http-equiv="content-type" content="text/html; charset=UTF-8">
   <title>Module Not Enabled</title>
   <link rel="StyleSheet" href="nbdocs://org.netbeans.modules.usersguide/org/netbeans/modules/usersguide/ide.css"
type="text/css">
 </head>

If the file already specifies UTF-8 encoding, leave it alone.
Comment 14 psmejkal 2008-08-20 08:43:31 UTC
Yes, sorry for those mistakes, it's hundreds of files, so I was using scripts for putting <html> tags where there
weren't, also <head> tags weren't everywhere, than some files already had charset tags.. I wanted to unite them, so that
I could treat all these files same way, and so first I deleted the old charset tags (only utf-8), then I added the same
tag to all the files, and so on... Sorry for those small mistakes, I was trying to avoid them, but checking every file
would take hours..
Comment 15 Patrick Keegan 2008-08-20 17:28:04 UTC
Marking this as fixed, since I believe Petr has covered all of the html files that are translated. Any files that Petr
changes after this don't necessarily need to be tracked by this issue. Ken, please file issues if you discover a file
during the translation process that doesn't have the charset specified.
Comment 16 Ken Frank 2008-09-09 20:29:31 UTC
if all tags have been added to olh, web docs and template
descriptors, let me know and will mark as verified.

ken.frank@sun.com
Comment 17 Ken Frank 2008-10-06 17:57:50 UTC
assuming it can be verified; please reopen if thats not the case.

ken.frank@sun.com