An API change is required by the debugger redesign phase 1 (see issue #133948).
Created attachment 62131 [details]
The plain API change attached. Working on apichanges description...
Created attachment 62200 [details]
API change in api.debugger.jpda with description in apichanges
Created attachment 62201 [details]
API change in spi.viewmodel with description in apichanges
Requesting a fast API review, API_Prototype_JPDA.txt and API_Prototype_TTV.txt describe the API changes.
Working on tests of the new API, they are going to be attached soon.
Created attachment 62249 [details]
New version of API_Prototype_JPDA.txt, including AttachingDICookie.getProcessID()
I have reviewed the proposed API change. I think, it is OK, I have not found any problems.
Reviewed, just a comment(nitpicking), that method JPDADebugger.getAllThreads() might be redundant because of
JPDADebugger.getThreadsCollector() seems to cover the same.
I do not see any problem with this API, reviewed.
Thanks for the review. We have review of the API change from 3 developers, thus I'm going to push the change shortly...
The new API is pushed to trunk together with the first phase of the debugger UI redesign:
Is there a _verbal_ description of the changes?
It's hard to slog through diffs and XML.
From what I could gather ...
- The addition of EXPANSION_MASK is OK.
- Why is Models.createNodes() public?
My understanding was that viewmodel _completely_ hides Nodes from view.
- What is TreeFeatures?
- I see TreeExpansionMOdelFilter per IZ 79940 (which BTW says WONTFIX:-)
Integrated into 'main-golden', available in NB_Trunk_Production #238 build
Log: #133948 - The first phase of debugger UI redesigned merged from dbg-prototype clon into trunk.
#136099 - APIs extended for the new functionality.
ivan, verbal description is just in the Javadoc and apichanges. :-(
Models.createNodes() is a utility method for specialized views. If a standard view based on TreeTableView, which is
created by Models.createView(), is not sufficient, the new method creates a tree structure, that can be used in any
TreeView. It's currently used by the debugging view, which is somewhat special and does not use TreeTableView.
TreeFeatures class was already a part of the APIs. This class was not used much, I've changed it to an abstract class so
that it's implementation can control node expansions in views.
I've forgot about issue #79940 already. Yes, it was closed as WONTFIX, since there was no real use-case for this filter.
Now there is, thus I'll change the issue to FIXED. Thanks for your remark.
Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier.