This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Steps: 1. Download and install 6.1 ml build 200805120101. 2. Create a new vw project 3. Drag-drop woodstock components onto the page Result: The default captions are not localized. * The woodstock designtime l10n jars in visualweb2/modules/ext/locale are not the latest ones. ** Please also check pt_BR jars in visualweb2/modules/ext/locale. Some are there, webui-jsf-dt_pt_BR.jar and some others are missing.
this question is for nb visualweb team, not translation team could there have been later in 6.1 cycle an update of the en ws jars but that the localized ones of that version were not obtained ? also I changed summary a bit to indicate that this issue is about both - incorrect version of some ws localized jars - some missing ws localized jars for pt_BR ken.frank@sun.com
Ming, can you give 1 or 2 examples and perhaps a gif related to the unlocalized captions; this info can help those working on this issue. Thanks. ken.frank@sun.com
about the missing pt_BR in visualweb2/modules/ext, I do see what I think are the 2 from woodstock but not the ones from netbeans - do we know if nb translation team has put back the translations of pt_BR for visualweb modules in modules or ext ? in ml zip, under visualweb/modules I see only 2 pt_BR jars thus it might be that not all have been putback and looking at hg repos for pt_BR files there are just a few top level dirs that have pt_BR files, and visualweb is not one of them; this is ok since translation is still in progress. NOTE - I'm not saying here that the 2 ws pt_BR files in visualweb2/modules/ext are the correct version or not here, am just commenting about missing pt_BR files comment. ken.frank@sun.com
To respond to Ken's query on Wed May 14 03:27:56 +0000 2008: Drag and drop a button or label component from Woodstock Basic palette to the page, one can see "label" and "button' in English on the page. They should be localized. Compare the webui-jsf-dt_<locale>.jar integrated in NB ml (visualweb2/modules/ext/locale) and those in woodstock download page (http://xdesign.sfbay/people/dspell/ProjectWoodstock/Download.htm). Even the file sizes are different.
webui-jsf-dt_<locale>.jar in nb is from netbeans l10n kit, not delivered to us, as far as I know, and files from it are in nb l10n kit. and the l10n kits are built from the product jars, not from repos source anymore - 1. could it be that not all files from l10n kit have been translated ? 2. to visualweb team - could it be that the en jar of that name is not latest one so that some messages/labels are not in it thus it could mean that l10n kit would not have those labels/msgs also. ken.frank@sun.com
I think we might have missed another to exclude webui-jsf-dt*.jar in nbbuild/l10n.patterns. Also, we need to make some changes to visualweb.woodstock.webui.jsf module's project.properties to include all the needed files. I'll take a look at this issue.
Michal, can you review the patch of my local changeset to fix this issue and let me know what the process is to checkin this fix? I've verified that the correct localized webui-jsf-dt_$locale.jar are copied and the l10n-kit doesn't contain the messages files for these jars. changeset: 77522:44c00b01dce7 tag: tip user: Chau Nguyen <cnguyencasj@netbeans.org> date: Mon May 19 21:04:08 2008 -0700 summary: Fix issue 134912 - Incorrect version of the l10n'ed woodstock designtime jars and some are missing. diff -r f8d282ed3d6f -r 44c00b01dce7 nbbuild/l10n.patterns --- a/nbbuild/l10n.patterns Mon May 19 18:22:40 2008 +0200 +++ b/nbbuild/l10n.patterns Mon May 19 21:04:08 2008 -0700 @@ -30,6 +30,7 @@ exclude **/jsf-impl.jar: exclude **/jsf-impl.jar: exclude **/webui-jsf.jar: exclude **/webui-jsf_*.jar: +exclude **/webui-jsf-dt*.jar: exclude **/webui-jsf-suntheme*.jar: exclude **/Info/info.xml: exclude **/lucene-core-*.jar: diff -r f8d282ed3d6f -r 44c00b01dce7 visualweb.woodstock.webui.jsf/build.xml --- a/visualweb.woodstock.webui.jsf/build.xml Mon May 19 18:22:40 2008 +0200 +++ b/visualweb.woodstock.webui.jsf/build.xml Mon May 19 21:04:08 2008 -0700 @@ -44,41 +44,4 @@ made subject to such option by the copyr <project name="org.netbeans.modules.visualweb.woodstock.webui.jsf" default="netbeans" basedir="."> <description>Builds, tests, and runs the project org.netbeans.modules.visualweb.woodstock.webui.jsf.</description> <import file="../nbbuild/templates/projectized.xml"/> - <property name="nbroot" location="../../.."/> - <property name="translated.src.dir" value="${nbroot}/translatedfiles/src/visualweb/woodstock/components/src"/> - - <target name="check-run-mlbuild" depends="basic-init"> - <available file="${nb_all}/translatedfiles/src/visualweb/woodstock/components" type="dir" property="translated.src.dir.exist"/> - <condition property="locjar.locales" value="${locales}"> - <and> - <isset property="locales" /> - <not> - <isset property="locjar.locales"/> - </not> - </and> - </condition> - <condition property="run.ml.build" value="true"> - <and> - <isset property="translated.src.dir.exist"/> - <isset property="locjar.locales"/> - <length string="${locjar.locales}" when="greater" length="1"/> - </and> - </condition> - </target> - - <target name="netbeans-extra-ml" depends="release-ml" if="locales"/> - - <target name="release-ml" depends="basic-init,check-run-mlbuild" if="run.ml.build"> - <taskdef name="repeat" classname="org.netbeans.nbbuild.Repeat" - classpath="${nbroot}/nbbuild/nbantext.jar"/> - <repeat target="release-one-locale" name="locale" values="${locales}"/> - </target> - - <target name="release-one-locale" if="locale"> - <copy todir="${cluster}"> - <fileset dir="${nb_all}/translatedfiles/src/visualweb/woodstock/components/release"> - <include name="**/*_${locale}.jar"/> - </fileset> - </copy> - </target> </project> diff -r f8d282ed3d6f -r 44c00b01dce7 visualweb.woodstock.webui.jsf/nbproject/project.properties --- a/visualweb.woodstock.webui.jsf/nbproject/project.properties Mon May 19 18:22:40 2008 +0200 +++ b/visualweb.woodstock.webui.jsf/nbproject/project.properties Mon May 19 21:04:08 2008 -0700 @@ -52,6 +52,9 @@ release.external/woodstock-components-4. release.external/woodstock-components-4.2.zip!/jsf-extensions-dynamic-faces-0.1.jar=modules/ext/jsf-extensions-dynamic-faces-0.1.jar release.external/woodstock-components-4.2.zip!/json-2.jar=modules/ext/json-2.jar release.external/woodstock-components-4.2.zip!/webui-jsf-dt.jar=modules/ext/webui-jsf-dt.jar +release.external/woodstock-components-4.2.zip!/webui-jsf-dt_ja.jar=modules/ext/locale/webui-jsf-dt_ja.jar +release.external/woodstock-components-4.2.zip!/webui-jsf-dt_pt_BR.jar=modules/ext/locale/webui-jsf-dt_pt_BR.jar +release.external/woodstock-components-4.2.zip!/webui-jsf-dt_zh_CN.jar=modules/ext/locale/webui-jsf-dt_zh_CN.jar release.external/woodstock-components-4.2.zip!/webui-jsf.jar=modules/ext/webui-jsf.jar release.external/woodstock-components-4.2.zip!/webui-jsf-doc.zip=docs/webui-jsf-doc.zip release.external/woodstock-components-4.2.zip!/webui-jsf-src.zip=docs/webui-jsf-src.zip
Does anyone know what the process of checking something into release61 branch now?
The patch seems correct to me. The better way would be to integrate the ML jars to l10n repository (right now main/l10n). But this should do the job as well. The only issue could be the ML NBM, but this is wouldn't be P1.
Thanks a lot Michal! The changes have been pushed: http://hg.netbeans.org/release61/rev/44c00b01dce7 Team, please verify in the next ml build.
BTW, the woodstock G10n team / Mary, please follow Michal's suggestion on a more efficient approach for this.
This bug has been fixed, verified in NetBeans nightly build 200805210103. * The version of Design Time jar files for zh_CN and ja are correct. The contents are from Woodstock 4.2 B5( Mar 20th). * Design Time jar file for pt_BR is there with correct version.
cnguyencasj, l10n-kit has been updated and the following files are removed now. So, I understand we should remove the localized files from our source tree, right? < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/Bundle.properties < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/component/Bundle-DT.properties < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/component/customizers/Bundle-DT.properties < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/component/propertyeditors/Bundle-DT.properties < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/component/table/Bundle.properties < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/component/util/Bundle-DT.properties < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/component/vforms/Bundle.properties < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/design/Bundle.properties < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/design/resources/AnchorIcon.gif < ./vw2/vw-woodstock-webui-jsf/ext/webui-jsf-dt/com/sun/webui/jsf/renderkit/html/Bundle-DT.properties