This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 133116 - Low performance of Code Completion REGRESSION
Summary: Low performance of Code Completion REGRESSION
Status: RESOLVED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Editor (show other bugs)
Version: 6.x
Hardware: Macintosh All
: P2 blocker (vote)
Assignee: Tomasz Slota
URL:
Keywords:
Depends on:
Blocks: 131609
  Show dependency tree
 
Reported: 2008-04-17 15:41 UTC by kozlov
Modified: 2008-04-17 20:39 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Sample (36.56 KB, application/x-compressed)
2008-04-17 15:48 UTC, kozlov 		Details
The screenshot from profiler (52.25 KB, image/png)
2008-04-17 18:17 UTC, Petr Pisl 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kozlov 2008-04-17 15:41:40 UTC 
Reproduced in build080417 not reproducible in build080415.

Open attached file place cursor;
After <?php and press ctrl + space;
When Code Completion list appears press space.

Wait for 10 seconds while new Code Completion list appears.

Probably this bug appears after implementing of sorting in CC list.
Comment 1 kozlov 2008-04-17 15:48:47 UTC 
Created attachment 60346 [details]
Sample
Comment 2 Petr Jiricka 2008-04-17 17:52:38 UTC 
Hi Tomasz, Petr P says you are looking at this?
Comment 3 Petr Pisl 2008-04-17 18:14:55 UTC 
I was run the code completion under profiler and it looks like method isSmart in PHPCompletionItem is called 74512 times
and it takes almost 5 seconds. I will attach the screenshot.
Comment 4 Petr Pisl 2008-04-17 18:17:56 UTC 
Created attachment 60365 [details]
The screenshot from profiler
Comment 5 Tomasz Slota 2008-04-17 20:21:15 UTC 
The regression was introduced by my change to show the locally defined stuff first, I can always roll it back... I am looking into it now
Comment 6 Tomasz Slota 2008-04-17 20:39:49 UTC 
Fixed without sacrificing any functionality.

http://hg.netbeans.org/release61-php/rev/22b24e79da89
http://hg.netbeans.org/release61-php/rev/3015add9c869