This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 131792 - Portlet related code should be removed from visualweb.project.jsf.action.SetStartPageAction.java
Summary: Portlet related code should be removed from visualweb.project.jsf.action.SetS...
Status: CLOSED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: _ potingwu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-02 08:13 UTC by Satyaranjan D
Modified: 2008-04-09 10:39 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Satyaranjan D 2008-04-02 08:13:50 UTC
Portlet related "Set As Initial" action code should be removed from visualweb.project.jsf.action.SetStartPageAction.java
 
FYI, contrib/portalpack.visualweb module(a NB update center module) is currently supporting JSF Portlet Feature in
NetBeans IDE.
Though core visualweb module doesn't support JSF portlet creation itself, all portlet specific sources are still there
in visualweb module which causes some duplicate functionalities(like duplicate menu items) for JSF Portlet.
For a jsfportlet page when the user right click on a jsf page, he/she can see an item on the pop-up menu as follows

Set As Initial > View Mode Page
               > Edit Mode Page
               > Help Mode Page

The "Set As Initial" feature basically sets the selected jsf page as "view/edit/help" page for the portlet in portlet.xml .

The portlet.xml api currently available in core visualweb is specific to 1.0 (previous portlet spec version) and cannot
handle portlet 2.0 xsd.

But as portalpack.visualweb supports both 1.0 and 2.0 version of portlet spec and as the same feature "Set As Initial"
in the portalpack.visualweb module is implemented in the same way as it is implemented in core visualweb, user sees two 
"Set As Initial" menu item for jsf portlet page. One from core visualweb module and other one is from
portalpack.visualweb module.
As the "Set as Initial" action from core visualweb module doesn't handle portlet 2.0 spec xsd, we need to delete that
action from visualweb module so that only one menu item will be displayed to the user.

To do this the portlet related code should be removed from
visualweb.project.jsf.action.SetStartPageAction.java 

As this is the only constraint for supporting portlet 2.0(JSR 286, recently approved) jsf portlet in NetBeans 6.1, it
should be fixed for 6.1
Comment 1 _ potingwu 2008-04-03 19:25:04 UTC
Satya, please verify it in the trunk and mark it as VERIFIED.

The diff is long but it actually does is just remove portlet related codes:

changeset 33a6152de664 in main
details: http://hg.netbeans.org/main?cmd=changeset;node=33a6152de664

changeset f05927e739a4 in main
details: http://hg.netbeans.org/main?cmd=changeset;node=f05927e739a4
Comment 2 Satyaranjan D 2008-04-04 08:04:46 UTC
Verified with latest trunk build. It's working as expected. 
Comment 3 _ potingwu 2008-04-04 17:27:08 UTC
The fix is now in the release61-beta_base branch:

changeset 0e51218d9d6c in main
details: http://hg.netbeans.org/main?cmd=changeset;node=0e51218d9d6c

changeset 76d4d94c6508 in main
details: http://hg.netbeans.org/main?cmd=changeset;node=76d4d94c6508
Comment 4 _ potingwu 2008-04-04 20:06:10 UTC
Finally the correct fix in release61 is in:

changeset bef566f9ba1c in release61
details: http://hg.netbeans.org/release61?cmd=changeset;node=bef566f9ba1c

changeset 5fb897e6e192 in release61
details: http://hg.netbeans.org/release61?cmd=changeset;node=5fb897e6e192
Comment 5 Martin Schovanek 2008-04-07 14:13:02 UTC
Reverting to Resolved > Fixed. Please mark it as verified after verification in release61.
Comment 6 Martin Schovanek 2008-04-07 14:14:07 UTC
rf.
Comment 7 Martin Schovanek 2008-04-08 09:57:32 UTC
Please verify in release61.
Comment 8 _ potingwu 2008-04-08 20:09:00 UTC
Verified in release61.