This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Project-specific implementations of CreateFromTemplateAttributesProvider are copy-pasted to the Java SE, web and EJB project, and entirely missing from the app client project. The copy-pasted code should be removed and a common implementation added to java.api.common.
Created attachment 58153 [details] Proposed change
Along with project.license, the common implementation also provides the project.encoding attribute suggested in issue 129685.
I have no objections. Another duplicated class removed, thanks Andrei.
[JG01] Why is there a generic-sounding QuerySupport with a createFileEncodingQuery, yet a separate factory class TemplateAttributesSupport?
Seems OK.
Re JG01: QuerySupport creates implementations of *Query. A method like createTemplateAttributeProvider() didn't seem to play well with existing QuerySupport methods. No strong opinion though.
I also got an offline question from tmysik whether the new class could be put in a package more specific than the root one. So I decided to just put the new method in QuerySupport, attaching the new patch. I would like to commit it this week, ideally on Thursday.
Created attachment 58222 [details] Proposed change (update 1)
[JG01 cont'd] It's true that CFTAP does not have "Query" in its name, but it is effectively a kind of query. No strong opinion either.
Agreed, I realized this too, reflected in the updated patch.
Unless there are any more comments, I will commit March 25.
could 127481 be related to this ? ken.frank@sun.com
Unlikely. Had it been related, the file would have had an UTF-8 encoding instead of the project encoding.
f1b5ac5f3859