Bug 129775 - Move *TemplateAttributesProvider to java.api.common
Move *TemplateAttributesProvider to java.api.common
Status: RESOLVED FIXED
Product: java
Classification: Unclassified
Component: Project
6.x
All All
: P2 (vote)
: 6.x
Assigned To: Andrei Badea
issues@java
: API, API_REVIEW_FAST
Depends on:
Blocks: 129685
  Show dependency treegraph
 
Reported: 2008-03-11 14:01 UTC by Andrei Badea
Modified: 2008-03-27 00:33 UTC (History)
5 users (show)

See Also:
Issue Type: ENHANCEMENT
:


Attachments
Proposed change (33.77 KB, text/plain)
2008-03-11 14:03 UTC, Andrei Badea
Details
Proposed change (update 1) (30.36 KB, text/plain)
2008-03-12 12:25 UTC, Andrei Badea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Badea 2008-03-11 14:01:07 UTC
Project-specific implementations of CreateFromTemplateAttributesProvider are copy-pasted to the Java SE, web and EJB
project, and entirely missing from the app client project. The copy-pasted code should be removed and a common
implementation added to java.api.common.
Comment 1 Andrei Badea 2008-03-11 14:03:23 UTC
Created attachment 58153 [details]
Proposed change
Comment 2 Andrei Badea 2008-03-11 14:06:53 UTC
Along with project.license, the common implementation also provides the project.encoding attribute suggested in issue
129685.
Comment 3 Tomas Mysik 2008-03-11 14:25:21 UTC
I have no objections.
Another duplicated class removed, thanks Andrei.
Comment 4 Jesse Glick 2008-03-11 15:46:55 UTC
[JG01] Why is there a generic-sounding QuerySupport with a createFileEncodingQuery, yet a separate factory class
TemplateAttributesSupport?
Comment 5 Tomas Zezula 2008-03-11 16:53:05 UTC
Seems OK.
Comment 6 Andrei Badea 2008-03-11 17:50:24 UTC
Re JG01: QuerySupport creates implementations of *Query. A method like createTemplateAttributeProvider() didn't seem to
play well with existing QuerySupport methods. No strong opinion though.
Comment 7 Andrei Badea 2008-03-12 12:24:02 UTC
I also got an offline question from tmysik whether the new class could be put in a package more specific than the root
one. So I decided to just put the new method in QuerySupport, attaching the new patch. I would like to commit it this
week, ideally on Thursday.
Comment 8 Andrei Badea 2008-03-12 12:25:22 UTC
Created attachment 58222 [details]
Proposed change (update 1)
Comment 9 Jesse Glick 2008-03-14 21:30:03 UTC
[JG01 cont'd] It's true that CFTAP does not have "Query" in its name, but it is effectively a kind of query. No strong
opinion either.
Comment 10 Andrei Badea 2008-03-15 20:36:46 UTC
Agreed, I realized this too, reflected in the updated patch.
Comment 11 Andrei Badea 2008-03-23 15:53:46 UTC
Unless there are any more comments, I will commit March 25.
Comment 12 Ken Frank 2008-03-26 17:37:07 UTC
could 127481 be related to this ?

ken.frank@sun.com
Comment 13 Andrei Badea 2008-03-26 21:31:00 UTC
Unlikely. Had it been related, the file would have had an UTF-8 encoding instead of the project encoding.
Comment 14 Andrei Badea 2008-03-27 00:33:36 UTC
f1b5ac5f3859


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo