This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 129087 - Mercurial main menu is too long.
Summary: Mercurial main menu is too long.
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
: 125371 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-04 09:01 UTC by Peter Pis
Modified: 2008-06-19 14:04 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
main_work_80812_451b918adfc4-context-menu-cleanup.patch (7.88 KB, text/plain)
2008-05-19 16:18 UTC, John Rice
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Pis 2008-03-04 09:01:52 UTC
Product Version: NetBeans IDE 6.1 Beta (Build 200803031027)
Java: 1.6.0_04; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb)
Userdir: D:\ide\61\user

Mercurial main menu is too long. For 800x600 screen resolution it's even trimmed. 

One solution would be to group items (something like for CVS branch). Or removing some actions (Initialize - CVS,
Subversion: don't have it either, more over it's rather it belongs to administrative commands which is not used so often).
Comment 1 Maros Sandor 2008-03-04 09:36:42 UTC
I forgot to tell you several times already, sorry. You should submit your main menu for review, see
http://wiki.netbeans.org/UIReviewProcess
Comment 2 John Rice 2008-03-04 11:30:32 UTC
Maros - is there a way for us to create a sub menu within the Annotator getActions() function? We only seem to be able
to add Actions, I don't see any obvious way to create a submenu.

We could restructure things as follows, if we can add submenus:

Top Level Versioning Menu for Mercurial Repo
=============================================
Initialize Project
------------------
Status
Diff
Update...
Commit...
------------------
Export Diff...
Import patches...
------------------
Clone - <project>
Clone Other...
------------------
Share ->
 Fetch
 Push to default
 Push Other
 Pull to default
 Push Other
------------------
Merge ->
 Merge Changes
 Resolve Conflicts
------------------
Show ->
 Show Annotations
 Show History
 Show Incoming
 Show Out
 View...
------------------
Recover ->
 Revert
 Strip
 Backout
 Rollback
------------------
Toggle Ignore
------------------
Properties
------------------

Mercurial Context Menu for Managed Project
===========================================
Status
Diff
Update...
Commit...
------------------
Clone - <project>
------------------
Share ->
 Fetch
 Push to default
 Pull to default
------------------
Merge ->
 Merge Changes
 Resolve Conflicts
 Mark as Resolved
------------------
Show ->
 Show Annotations
 Show History
 Show Incoming
 Show Out
 View...
------------------
Recover ->
 Revert
 Strip
 Backout
 Rollback
------------------
Toggle Ignore
------------------
Properties
------------------
Comment 3 jrojcek 2008-03-04 14:06:09 UTC
When redesigning the menus, make sure the frequently used actions are at the top level so the user doesn't need to go for them into submenus.
Comment 4 John Rice 2008-03-04 14:53:29 UTC
Promoting a few of the sub-menus as suggested, for more commonly used items:


Top Level Versioning Menu for Mercurial Repo (reduces menu list by 9)
=============================================
Initialize Project
------------------
Status
Diff
Update...
Commit...
------------------
Export Diff...
Import patches...
------------------
Clone - <project>
Clone Other...
------------------
Fetch
Share ->
 Push to default
 Push Other
 Pull to default
 Push Other
------------------
Merge ->
 Merge Changes
 Resolve Conflicts
------------------
Show History
Show ->
 Show Annotations
 Show Incoming
 Show Out
 View...
------------------
Revert
Recover ->
 Strip
 Backout
 Rollback
------------------
Toggle Ignore
------------------
Properties
------------------

Mercurial Context Menu for Managed Project (reduces menu list by 8)
===========================================
Status
Diff
Update...
Commit...
------------------
Clone - <project>
------------------
Fetch
Share ->
 Push to default
 Pull to default
------------------
Merge ->
 Merge Changes
 Resolve Conflicts
 Mark as Resolved
------------------
Show History
Show ->
 Show Annotations
 Show Incoming
 Show Out
 View...
------------------
Revert
Recover ->
 Strip
 Backout
 Rollback
------------------
Toggle Ignore
------------------
Properties
------------------
Comment 5 jrojcek 2008-03-05 15:59:35 UTC
Thanks for updating the menus. I've added the Mercurial menu into the permanent UI spec. I've still tried to eliminate some of the separators as too many of 
them add a visual clutter to the menu. Please let me whether it's okay or not.
http://wiki.netbeans.org/MainMenu

The contextual menu should contain all applicable items in the same order using same names.

Thanks!
Comment 6 John Rice 2008-03-05 19:17:10 UTC
We can only have submenus in the Top level Versioning menu and so I dropped everything from the context menu (except the
Properties) that wasn't context sensitive (refer to #125371)

Top Level Versioning Menu for Mercurial Repo 
=============================================
n Initialize Project
------------------
t Status
D Diff
U Update...
m Commit...
------------------
x Export Diff...
p Import patches...
------------------
o Clone - <project>
h Clone Other...
F Fetch
r Share ->
 Push to default
 Push Other
 Pull to default
 Push Other
g Merge ->
 Merge Changes
 Resolve Conflicts
------------------
H Show History
w Show ->
 Show Annotations
 Show Incoming
 Show Out
 View...
------------------
R Revert
v Recover ->
 Strip
 Backout
 Rollback
I Toggle Ignore
------------------
P Properties
------------------
C CVS
M Mercurial
S Subversion
------------------
L Local History


Mercurial Context Menu for Managed Project 
===========================================
Status
Diff
Update...
Commit...
------------------
Merge Changes
Resolve Conflicts
Mark as Resolved
------------------
Show Annotations
Show History
Show Incoming
Show Out
------------------
Revert
Toggle Ignore
------------------
Properties
------------------


Comment 7 John Rice 2008-03-05 19:43:51 UTC
Menu rework pushed, in sync with http://wiki.netbeans.org/MainMenu UI spec.

Mercurial Push
--------------
INFO Changesets to push:
comparing with https://jrice:****@hg.netbeans.org/main
searching for changes

changeset:   70191:902facc56e0d
user:        jrice@netbeans.org
date:        Wed Mar 05 19:19:26 2008 +0000
files:       mercurial/src/org/netbeans/modules/mercurial/Bundle.properties
mercurial/src/org/netbeans/modules/mercurial/MercurialAnnotator.java
mercurial/src/org/netbeans/modules/mercurial/MergeMenu.java
mercurial/src/org/netbeans/modules/mercurial/RecoverMenu.java
mercurial/src/org/netbeans/modules/mercurial/ShareMenu.java mercurial/src/org/netbeans/modules/mercurial/ShowMenu.java
description:
#129087: rework of menus for Versioning and context in sync with UI spec

Comment 8 John Rice 2008-03-05 19:44:09 UTC
*** Issue 125371 has been marked as a duplicate of this issue. ***
Comment 9 jrojcek 2008-03-10 13:40:44 UTC
Thanks for adding mnemonics. I've updated the spec with them...
http://wiki.netbeans.org/MainMenu
Comment 10 Peter Pis 2008-04-07 15:20:56 UTC
Verified.
Comment 11 John Rice 2008-05-19 16:13:00 UTC
Making further menu changes to reflect which menus act at Repository level and not Context.

Removed Show Out, Show Incoming, Update and Merge as both act on Repository, available in Top Level versioning menu.
Changed Show Out and Show Incoming to give just the Repository in their Tab, not any selected context as they act at the
 repository level.

Mercurial Context Menu for Managed Project 
===========================================
Status
Diff
Commit...
------------------
Resolve Conflicts
Mark as Resolved
------------------
Show Annotations
Show History
------------------
Revert
Toggle Ignore
------------------
Properties
------------------

changeset:   80810:a15d3f26bd5d
tag:         tip
user:        jrice@netbeans.org
date:        Mon May 19 16:08:50 2008 +0100
summary:     #129087: further context menu changes, making sure Reposiotry commands only available in Top Level Menu

Comment 12 John Rice 2008-05-19 16:18:45 UTC
Created attachment 61570 [details]
main_work_80812_451b918adfc4-context-menu-cleanup.patch
Comment 13 John Rice 2008-05-19 16:20:28 UTC
Changes committed to main
Comment 14 Quality Engineering 2008-05-20 05:11:32 UTC
Integrated into 'main-golden', available in NB_Trunk_Production #206 build
Changeset: http://hg.netbeans.org/main/rev/a15d3f26bd5d
User: jrice@netbeans.org
Log: #129087: further context menu changes, making sure Reposiotry commands only available in Top Level Menu
Comment 15 Peter Pis 2008-06-19 14:04:04 UTC
Verified.