This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Right now the only code removing registered server instance is placed in non public RemoveAction. The proposed change will introduce simple method Deployment.removeInstance(String instanceId, boolean stop).
Well for our purposes it would be much better to have it in InstanceProperties providing just the necessary removal without additional steps. Sorry for the confusion. Attaching diff.
Created attachment 57689 [details] patch
Just a nit on the patch -- your removeInstance method uses the parameter name "serverInstanceId" to identify the server. The create...() methods use the name "url". I think the names should be the same to make it clear that the value passed into the create...() routine as the URL field is the same value that should be used when remove...() is called. I know it's not a URL at all (URI instead?), but it's too late to do much about that inconsistency. I just think they should be the same name, otherwise there may be confusion over whether they represent the same value (which they must for the code to work). I would like to rewrite the comments a little, I'll attach a different diff later for that.
I agree, you are definitely right. Thanks for the correction.
Created attachment 57697 [details] New suggested diff for changes to InstanceProperties.java
Created attachment 57698 [details] included changes posted by peter
Please put the label back at the end of the @link I wrote, otherwise it looks bad in the help... e.g. it should be: {@link #createInstancePropertiesWithoutUI(String, String, String, String, Map) createInstancePropertiesWithoutUI} This is recommended in the docs on javadoc -- http://java.sun.com/j2se/1.5.0/docs/tooldocs/windows/javadoc.html#{@link}
Created attachment 57730 [details] fixed link
I agree with the change.
If there is no objections I will integrate this tomorrow.
Fixed in changeset 2abccc63a0ab.
*** Issue 56105 has been marked as a duplicate of this issue. ***