This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 128981 - Bean info editor is not possible to refactore
Summary: Bean info editor is not possible to refactore
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Beans (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jan Pokorsky
URL:
Keywords:
Depends on: 129949
Blocks:
  Show dependency tree
 
Reported: 2008-03-03 10:31 UTC by Jana Maleckova
Modified: 2008-04-01 09:48 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
128981 (1.16 KB, text/plain)
2008-03-03 10:33 UTC, Jana Maleckova
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jana Maleckova 2008-03-03 10:31:45 UTC
Product Version: NetBeans IDE Dev (Build 200803021202)
Java: 1.6.0_04; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb)

Description:
============
Refactoring - rename done on class which has created BeanInfoEditor, doesn't finish successfully.
1. create java class
2. create BeanInfoEditor for this class
3. rename java class => AE error is thrown => finish refactoring
Refactoring fails when it tries to edit guarded block in BeanInfoEditor. Refactoring is not done completely in java
class and it causes that class is not compileable.
Comment 1 Jana Maleckova 2008-03-03 10:32:22 UTC
StackTrace:
===========
java.lang.AssertionError
	at org.netbeans.modules.form.RefactoringInfo.getUpdateForFile(RefactoringInfo.java:149)
	at
org.netbeans.modules.form.GuardedBlockHandlerFactoryImpl$GuardedBlockHandlerImpl.handleChange(GuardedBlockHandlerFactoryImpl.java:98)
	at org.netbeans.modules.refactoring.spi.RefactoringElementsBag.add(RefactoringElementsBag.java:111)
	at org.netbeans.modules.refactoring.java.spi.JavaRefactoringPlugin.createAndAddElements(JavaRefactoringPlugin.java:261)
Comment 2 Jana Maleckova 2008-03-03 10:33:56 UTC
Created attachment 57655 [details]
128981
Comment 3 Jan Becicka 2008-03-03 10:49:10 UTC
Assertion comes from form module. Please evaluate.
Comment 4 Jan Stola 2008-03-03 13:21:09 UTC
I have fixed the assertion error, but the problem with BeanInfo not being refactored still remains. Beans module should 
implement its own GuardedBlockHandler to handle this change => reassigning back to beans module.

Corresponding changeset: http://hg.netbeans.org/main/rev/5ebf3c45309e
Comment 5 Jan Pokorsky 2008-03-15 19:52:23 UTC
fixed as http://hg.netbeans.org/main/rev/f1cd45181c39
Comment 6 Jana Maleckova 2008-03-31 10:37:29 UTC
need reopening

Product Version: NetBeans IDE Dev (Build 200803302302)
Java: 1.6.0_04; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb)

Description:
============
BeanInfo editor could be refactored - guarded blocks are adequately changed and no exception is thrown
But new issue with BeanInfo designer arose.
Designer of BeanInfoEditor is seeking an old name of class for which it was created therefore no output in designer is shown
steps:
1. create e.g. form class
2. create BeanInfoEditor for it
3. rename form class
4. switch to designer of BeanInfoEditor
no output
Comment 7 Jana Maleckova 2008-04-01 09:47:32 UTC
After talking with developer, I will create new issue for the new described problem and this will be marked as verified
Comment 8 Jana Maleckova 2008-04-01 09:48:30 UTC
verified on

Product Version: NetBeans IDE Dev (Build 200803302302)
Java: 1.6.0_04; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb)