This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 12689 - IDE freez after mounting CVS FS
Summary: IDE freez after mounting CVS FS
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: issues@obsolete
URL:
Keywords:
: 12725 (view as bug list)
Depends on:
Blocks: 12690
  Show dependency tree
 
Reported: 2001-06-08 13:39 UTC by dmladek
Modified: 2008-12-23 13:48 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
FTD (13.09 KB, text/plain)
2001-07-20 20:39 UTC, dmladek
Details
FTD II. (13.99 KB, text/plain)
2001-07-20 20:39 UTC, dmladek
Details
Still repeating E.in my IDE.log (3.73 KB, text/plain)
2001-07-20 20:39 UTC, dmladek
Details
E. in RequedProccessor (4.75 KB, text/plain)
2001-07-20 20:39 UTC, dmladek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dmladek 2001-06-08 13:39:08 UTC
[NBdev-206]+ settings[NBdev-201]
rh70, jdk1.3.1
================================

Probably occures only on linux.

If I mount CVS FS and press finish button of Mounting Wizard (choosing
comand-line client support) IDE freez.
Martin Entlicher says:
"Probably problem of core - Repository
collision of JAva parsing and add filesystem in core"

I'm attaching FTD
Comment 1 dmladek 2001-06-08 13:40:17 UTC
Created attachment 1516 [details]
FTD
Comment 2 dmladek 2001-06-08 13:42:01 UTC
Maybe the issue #12690 occures of this bug
Comment 3 dmladek 2001-06-08 14:02:01 UTC
Downgrading the priority because it is not fully reproductable.
Comment 4 Jan Zajicek 2001-06-08 14:44:15 UTC
JavaParser is waiting in AWT thread for something, so assigning to java module.
But I am not sure so feel free to reassign.
Comment 5 Svata Dedic 2001-06-08 15:44:03 UTC
"Java source parsing" daemon prio=1 tid=0x4cbb9280 nid=0x3316 waiting for
monitor entry [0xbcbff000..0xbcbff8b0]
	at org.openide.filesystems.Repository.getFileSystems(Repository.java:263)
	at org.openide.filesystems.Repository.fileSystems(Repository.java:271)
	at
org.openide.filesystems.FileSystemCapability.fileSystems(FileSystemCapability.java:70)

---- at
org.netbeans.modules.debugger.support.LineBreakpointEvent.access$100(LineBreakpointEvent.java:61)
	at
org.netbeans.modules.debugger.support.LineBreakpointEvent$FileSystemRepositoryListener.fileSystemAddedOrRemoved(LineBreakpointEvent.java:132)
	at
org.netbeans.modules.debugger.support.LineBreakpointEvent$FileSystemRepositoryListener.fileSystemRemoved(LineBreakpointEvent.java:113)
	at org.openide.util.WeakListener$Repository.fileSystemRemoved(WeakListener.java:481)
	at org.openide.filesystems.Repository.fireFileSystem(Repository.java:466)

----
It seems that the event is dispatched while holding lock on the Repository
object. The parser then cannot enumerate filesystems to obtain classpath for the
project and the debugger (AWT thread which holds the filesystems lock) waits for
the parser.
"AWT-EventQueue-0" prio=1 tid=0x81cbc88 nid=0x3303 waiting on monitor
[0xbe7fe000..0xbe7ff8b0]
[snip]


Comment 6 Svata Dedic 2001-06-08 15:48:52 UTC
Update: The repository object is quite innocent :-)

 at
org.netbeans.modules.vcscore.wizard.mountcvs.CvsMountFS.addNotify(CvsMountFS.java:80)
	at org.openide.filesystems.Repository.addFileSystem(Repository.java:170)


addNotify is called while holding the lock. addNotify calls removeFileSystem,
which is probably a bad thing. What do you think ?
Comment 7 dmladek 2001-06-08 18:10:40 UTC
Adding developer of CVS to CC of this bug
Comment 8 rmatous 2001-06-11 15:06:43 UTC
fireFileSystem is called from removeFileSystem that holds lock. There already 
once was intention to prevent fire events without locks from removeFileSystem. 
But by mistake on line 202 stayed original firing of event. Sorry for that. So 
I`m assigning bug on me.
Comment 9 Martin Entlicher 2001-06-11 15:58:59 UTC
Yes, this will solve the deadlock. However in the mean time I have changed
CvsMountFS.addNotify(CvsMountFS.java:80) to remove itself later in a request
processor. This should also fix this deadlock.
Comment 10 rmatous 2001-06-11 17:34:38 UTC
Fixed in main trunk. Method removeFileSystem fires event outside of 
synchronized block.
Comment 11 dmladek 2001-06-12 07:36:49 UTC
In which build number? I hope it is in [NBdev-208]
Comment 12 dmladek 2001-06-12 08:09:13 UTC
if it is in build no. #208 I must reopen this bug.

Ide freez ater I finish mounting wizard and try to start some work.
It is hard to reproduce and I don't know if it isn't a coincidence.
Because .... I give you my procedure of steps.

My work procedure:
==================
1.take [NBdev-208] build and unzip it and run it.
  I ran it with my previous settings from NBdev branche.
  Tha last run build was [NBdev-207] with this settings
2. I open some files in editor (new 1 + 10 has been opened atomaticaly form my
settings)
3. In the newly opened file I set a few breakpoints
4. Tools->Option-Editor->Java editor
   I customize color of the editor
5. File->Mount FS-> another type -> CVS and close this dialog

!!!.In this time I recognice a dialog with Exception occured in Request
Proccessor !!!

   a CVS wizard was started
6. I went trought this wizard, selected empty working and select
   local repository and Finsih it.
7. Seems that FS was mounted, but I'm not sure, cause the dialog with E
hided my Explorer. And If I press Show detail on it. Its window has been resized
but NO details has been shown. And an attempt to move with this window
discovered that ide freez.

I created another FuulThreadDump for you and also attach E. in Requered
Proccessor (if it was stored in ide.log)
Comment 13 dmladek 2001-06-12 08:12:24 UTC
Created attachment 1547 [details]
FTD II.
Comment 14 dmladek 2001-06-12 08:18:21 UTC
Created attachment 1548 [details]
Still repeating E.in my IDE.log
Comment 15 dmladek 2001-06-12 08:26:31 UTC
Because NPE, which was cyclable writting to my ide.log make's  my HDD full.
I must increase the priority to P1

Maybe it isn't related to this issue and more over there was an issue #10723
that if you try mount CVS FS via File->Mount Filesystm...
the E. was repeatedly written to your ide.log and made your HDD full and cause
crash of your all apps. and OS.
Comment 16 rmatous 2001-06-12 09:04:22 UTC
At first glance there seems to be problem outside of filesystems. Perhaps in 
implemenattion of children in VcsFileSystem. Reassigned to vcscore.
Comment 17 dmladek 2001-06-12 09:15:55 UTC
Reproduction of an E. in Request Proccessor is quite easy even on windows 2000.
I'm attaching it.

IMHO, It seems that NPE which filled my ide.log & HDD is some individual issue:-/
So, what's your suggestion?
Comment 18 dmladek 2001-06-12 09:18:39 UTC
Created attachment 1550 [details]
E. in RequedProccessor
Comment 19 Milos Kleint 2001-06-12 13:19:24 UTC
ok. I fixed the last NPE. it was caused by the code in CvsMountFs. This
filesystem (which is used just to mount javacvsfs or cvsfs) did not implement
the AbstractFileSystem's info, change, attr interfaces. now it does (in a
trivial way, just to prevent the NPE.)
Comment 20 dmladek 2001-06-12 13:41:34 UTC
ehmm... The one befor last Exception which caused overflow of my HDD isn't
fixed,yet? am I right?

pls, include the fix of NPE (under attachment named"Still repeating E.in my
IDE.log   (text/plain)")

thanks


P.S.
sorry for confusing you with this lots of attachment which they aren't under any
relationship.
But all happend to me at once acction:-]
Comment 21 dmladek 2001-06-12 13:43:25 UTC
one more stuff:
mind the second attachment "FTD II" where is FullThreadDump
when ide freez. Probably caused  by overloading ide.log and my HDD.
Comment 22 Martin Entlicher 2001-06-13 16:36:46 UTC
I fixed the NullPointerException in VcsFileSystem (attachment id=1548: "Still
repeating E.in my IDE.log"). Fixed in dev build #210.

This should finally fix the whole issue => marking as fixed.
Comment 23 Jan Zajicek 2001-06-14 07:57:02 UTC
The fix in Repository class i verified in the trunk rev 1.32.
Comment 24 Jan Pokorsky 2001-06-15 11:07:57 UTC
*** Issue 12725 has been marked as a duplicate of this issue. ***
Comment 25 dmladek 2001-06-15 14:10:27 UTC
OK on [NBdev-211]
Comment 26 Quality Engineering 2003-07-01 16:15:58 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.