This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 123115 - URLDataObjects do not have FileEncoding implemented
Summary: URLDataObjects do not have FileEncoding implemented
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: URL (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Marian Petras
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-30 10:40 UTC by Marian Petras
Modified: 2008-01-23 22:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
source code patch (7.50 KB, patch)
2008-01-16 14:05 UTC, Marian Petras 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Petras 2007-11-30 10:40:59 UTC 
URLDataObjects do not have encoding defined so the project's encoding is used for them.

This is not good - ISO Latin 1 (ISO-8859-1) encoding should be used for all URL objects.
Comment 1 Ken Frank 2007-11-30 18:33:41 UTC 
what is the user scenario for this that problems might be seen ?

(want to see if this is related to some other things seen and to know for testing this when its fixed.


since iso-8859-1 needs to be used, does it mean that file names or paths with non ascii cannot be used
in nb, for things that would become a url that is based on those file names or paths ?

ken.frank@sun.com
Comment 2 Jesse Glick 2007-11-30 20:06:04 UTC 
Probably UTF-8 should be used in all cases for these. They are not edited as text, they are not part of projects, they
are just used for menu registration from module XML layers.
Comment 3 Marian Petras 2008-01-15 13:56:29 UTC 
I agree. I will setup the URL DataObjects to always use UTF-8.
Comment 4 Marian Petras 2008-01-16 13:59:26 UTC 
I will add it to Milestone 2 of NB 6.1.
Comment 5 Marian Petras 2008-01-16 14:05:55 UTC 
Created attachment 55141 [details]
source code patch
Comment 6 Marian Petras 2008-01-23 22:56:29 UTC 
Fixed in the trunk.

All URLDataObjects now have a simple implementation of FileEncodingQueryImplementation in their lookup. This
implementation returns encoding UTF-8 for any file.