I'm trying to eliminate non-read/write locked access to certain TokenHierarchy's methods. Currently I use the
but as Tor and Marek suggested I will possibly migrate to do an assert for this instead of a logged exception warning.
Once implemented all the non-read/write locked accesses of TH would fail with AssertionError so I would like to
eliminate them all first. For lexer I need to fix most of the tests (relevant for other modules too imho). Although I
could make a property to ignore the locking for tests it's imo not a good practice since someone might copy code from
the tests so I would rather fix the tests.
Some initial fixes. Owners please review whether you want a different granularity, thanks.
Checking in editor/indent/src/org/netbeans/modules/editor/indent/IndentImpl.java;
/cvs/editor/indent/src/org/netbeans/modules/editor/indent/IndentImpl.java,v <-- IndentImpl.java
new revision: 1.16; previous revision: 1.15
Checking in editor/indent/src/org/netbeans/modules/editor/indent/TaskHandler.java;
/cvs/editor/indent/src/org/netbeans/modules/editor/indent/TaskHandler.java,v <-- TaskHandler.java
new revision: 1.19; previous revision: 1.18
Checking in ruby/gsf/src/org/netbeans/modules/gsf/AbstractCamelCasePosition.java;
/cvs/ruby/gsf/src/org/netbeans/modules/gsf/AbstractCamelCasePosition.java,v <-- AbstractCamelCasePosition.java
new revision: 1.3; previous revision: 1.2
Checking in ruby/editing/src/org/netbeans/modules/ruby/CodeCompleter.java;
/cvs/ruby/editing/src/org/netbeans/modules/ruby/CodeCompleter.java,v <-- CodeCompleter.java
new revision: 1.36; previous revision: 1.35
Checking in ruby/gsf/src/org/netbeans/modules/gsfret/editor/completion/GsfCompletionProvider.java;
new revision: 1.4; previous revision: 1.3
Checking in java/editor/src/org/netbeans/modules/editor/java/Utilities.java;
/cvs/java/editor/src/org/netbeans/modules/editor/java/Utilities.java,v <-- Utilities.java
new revision: 1.34; previous revision: 1.33