This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 122737 - I18N: need to include localized swing-l10n jar file for 6.0
Summary: I18N: need to include localized swing-l10n jar file for 6.0
Status: VERIFIED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: nbbuild-issues@ide
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2007-11-26 06:20 UTC by Masaki Katakai
Modified: 2008-01-15 08:43 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
Commit log from translation files reorganization in translatedfiles/src/swing/src/(plus one more time "swing/src/") (5.54 KB, text/plain)
2008-01-14 10:07 UTC, rbalada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2007-11-26 06:20:51 UTC
In NetBeans 5.x, we provided localized jar file for Swing UI (filechooser, colorchooser and etc)
for non-localized language (e.g. pt_BR and ru) of JDK as

./platform6/lib/locale/swing-l10n_pt_BR.jar

Will you add this to NetBeans 6.0 too? translatedfiles/build.xml of release551 branch
contains the code to build and include it. The files for pt_BR are already in
release60 branch.

If it would be complicated, I understand that we don't need to compile
them at build time so it's OK if we could integrate swing-l10n_pt_BR.jar
into some place so that build system can just pick up it.
Comment 1 Ken Frank 2007-11-26 13:35:15 UTC
please give some more information on this file and what it does. Since nb6 could be different
we need to make sure the msgs in this file are found when needed and don't conflict with
other things. 

Why is this file needed ? It is true that jdk is translated just for a few locales and if
not in those locales, the msgs will be in english; its same as other modules in ext dirs
that are either not translated or translated just for some locales.

Does it work for pt_BR in nb6 if this file is in that location mentioned ?
And is expectation that community would each create and add such a file also ?

I don't think its good just to add file separately either than have build do it.

ken.frank@sun.com
Comment 2 Ken Frank 2007-11-26 13:54:53 UTC
please give some more information on this file and what it does. Since nb6 could be different
we need to make sure the msgs in this file are found when needed and don't conflict with
other things. 

Why is this file needed ? It is true that jdk is translated just for a few locales and if
not in those locales, the msgs will be in english; its same as other modules in ext dirs
that are either not translated or translated just for some locales.

Does it work for pt_BR in nb6 if this file is in that location mentioned ?
And is expectation that community would each create and add such a file also ?

I don't think its good just to add file separately either than have build do it.

ken.frank@sun.com
Comment 3 rbalada 2007-12-13 10:10:23 UTC
I'll update nb_all/core/build.xml to enable this build for 6.0 ML build.
Comment 4 rbalada 2007-12-13 13:40:20 UTC
I've updated the build to produce the requested swing-l10n.jar file.

Checking in build.xml;
/cvs/core/build.xml,v  <--  build.xml
new revision: 1.97.6.1; previous revision: 1.97
done
Comment 5 Masaki Katakai 2007-12-25 04:11:56 UTC
Thank you very much Rudolf.

It seems that path is not correct so pt_BR messages are not localized now.

% jar tvf ./platform7/lib/locale/swing-l10n_pt_BR.jar
...
swing/src/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties
swing/src/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties
swing/src/com/sun/swing/internal/plaf/synth/resources/synth_pt_BR.properties
...

"swing/src/" is not needed. Could you please update build.xml again
so that these .properties are included from "com/sun/..." ?
Comment 6 rbalada 2008-01-14 09:39:46 UTC
Accepted.
Comment 7 rbalada 2008-01-14 10:07:23 UTC
Created attachment 55020 [details]
Commit log from translation files reorganization in translatedfiles/src/swing/src/(plus one more time "swing/src/")
Comment 8 rbalada 2008-01-14 10:18:25 UTC
Masaki,
the problem was in incorrectly checked-in translation files, which were for some reason in
translatedfiles/src/swing/src/swing/src (see two times "swing/src/") and directory translatedfiles/src/swing/src is root
for taking classes and property files into localization jarfiles for swing-l10n. That's why it was incorrectly placed in
localization jarfile.
Comment 9 Masaki Katakai 2008-01-15 08:43:16 UTC
Thank you very much Rudolf,

I verified the fix is working fine on 2008-01-15_01-16-45 build. Great!