This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
java.util.ConcurrentModificationException at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:449) at java.util.AbstractList$Itr.next(AbstractList.java:420) at org.netbeans.modules.vmd.midp.java.JavaClassNameResolver.fireResolveFinished(JavaClassNameResolver.java:205) at org.netbeans.modules.vmd.midp.java.JavaClassNameResolver.run(JavaClassNameResolver.java:154) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:561) at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:986) Seems to be thrown in maybe 20% of commit validation runs.
fixed in main trunk Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGMenuProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGMenuProducer.java,v <-- SVGMenuProducer.java new revision: 1.10; previous revision: 1.9 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGSplashScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGSplashScreenProducer.java,v <-- SVGSplashScreenProducer.java new revision: 1.9; previous revision: 1.8 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/FileBrowserProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/FileBrowserProducer.java,v <-- FileBrowserProducer.java new revision: 1.8; previous revision: 1.7 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGMenuElementEventSourceProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGMenuElementEventSourceProducer.java,v <-- SVGMenuElementEventSourceProducer.java new revision: 1.8; previous revision: 1.7 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SMSComposerProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SMSComposerProducer.java,v <-- SMSComposerProducer.java new revision: 1.12; previous revision: 1.11 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/WaitScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/WaitScreenProducer.java,v <-- WaitScreenProducer.java new revision: 1.14; previous revision: 1.13 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGWaitScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGWaitScreenProducer.java,v <-- SVGWaitScreenProducer.java new revision: 1.11; previous revision: 1.10 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/CustomComponentProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/CustomComponentProducer.java,v <-- CustomComponentProducer.java new revision: 1.23; previous revision: 1.22 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SplashScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SplashScreenProducer.java,v <-- SplashScreenProducer.java new revision: 1.9; previous revision: 1.8 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/PIMBrowserProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/PIMBrowserProducer.java,v <-- PIMBrowserProducer.java new revision: 1.8; previous revision: 1.7 done Checking in designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/LoginScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/LoginScreenProducer.java,v <-- LoginScreenProducer.java new revision: 1.13; previous revision: 1.12 done Checking in designer2/midp/src/org/netbeans/modules/vmd/midp/serialization/MidpProducerDeserializer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/serialization/MidpProducerDeserializer.java,v <-- MidpProducerDeserializer.java new revision: 1.5; previous revision: 1.4 done Checking in designer2/midp/src/org/netbeans/modules/vmd/midp/java/MidpJavaSupport.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/MidpJavaSupport.java,v <-- MidpJavaSupport.java new revision: 1.2; previous revision: 1.1 done Removing designer2/midp/src/org/netbeans/modules/vmd/midp/java/JavaClassNameResolver.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/JavaClassNameResolver.java,v <-- JavaClassNameResolver.java new revision: delete; previous revision: 1.2 done Removing designer2/midp/src/org/netbeans/modules/vmd/midp/java/ResolveListener.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/ResolveListener.java,v <-- ResolveListener.java new revision: delete; previous revision: 1.2 done Checking in designer2/midp/src/org/netbeans/modules/vmd/midp/producers/EntryPointProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/EntryPointProducer.java,v <-- EntryPointProducer.java new revision: 1.7; previous revision: 1.6 done Checking in designer2/midp/src/org/netbeans/modules/vmd/midp/producers/ChoiceElementProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/ChoiceElementProducer.java,v <-- ChoiceElementProducer.java new revision: 1.7; previous revision: 1.6 done Checking in designer2/midp/src/org/netbeans/modules/vmd/midp/producers/IfPointProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/IfPointProducer.java,v <-- IfPointProducer.java new revision: 1.4; previous revision: 1.3 done Checking in designer2/midp/src/org/netbeans/modules/vmd/midp/producers/CommandProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/CommandProducer.java,v <-- CommandProducer.java new revision: 1.7; previous revision: 1.6 done Checking in designer2/midp/src/org/netbeans/modules/vmd/midp/producers/MidpComponentProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/MidpComponentProducer.java,v <-- MidpComponentProducer.java new revision: 1.9; previous revision: 1.8 done Checking in designer2/midp/src/org/netbeans/modules/vmd/midp/producers/ListElementEventSourceProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/ListElementEventSourceProducer.java,v <-- ListElementEventSourceProducer.java new revision: 1.8; previous revision: 1.7 done Checking in designer2/palette/src/org/netbeans/modules/vmd/palette/PaletteKit.java; /cvs/mobility/designer2/palette/src/org/netbeans/modules/vmd/palette/PaletteKit.java,v <-- PaletteKit.java new revision: 1.29; previous revision: 1.28 done Checking in designer2/palette/src/org/netbeans/modules/vmd/palette/PaletteMap.java; /cvs/mobility/designer2/palette/src/org/netbeans/modules/vmd/palette/PaletteMap.java,v <-- PaletteMap.java new revision: 1.20; previous revision: 1.19 done Checking in designer2/model/src/org/netbeans/modules/vmd/model/XMLComponentProducer.java; /cvs/mobility/designer2/model/src/org/netbeans/modules/vmd/model/XMLComponentProducer.java,v <-- XMLComponentProducer.java new revision: 1.9; previous revision: 1.8 done Checking in designer2/model/src/org/netbeans/modules/vmd/api/model/ComponentProducer.java; /cvs/mobility/designer2/model/src/org/netbeans/modules/vmd/api/model/ComponentProducer.java,v <-- ComponentProducer.java new revision: 1.6; previous revision: 1.5 done Checking in designer2/palette/src/org/netbeans/modules/vmd/api/palette/PaletteSupport.java; /cvs/mobility/designer2/palette/src/org/netbeans/modules/vmd/api/palette/PaletteSupport.java,v <-- PaletteSupport.java new revision: 1.6; previous revision: 1.5 done Checking in designer2/model/src/org/netbeans/modules/vmd/api/model/presenters/actions/AddActionPresenter.java; /cvs/mobility/designer2/model/src/org/netbeans/modules/vmd/api/model/presenters/actions/AddActionPresenter.java,v <-- AddActionPresenter.java new revision: 1.8; previous revision: 1.7 done
Created attachment 52679 [details] cvs diff
adding small fix of NPE (related issue #121451) Checking in XMLComponentProducer.java; /cvs/mobility/designer2/model/src/org/netbeans/modules/vmd/model/XMLComponentProducer.java,v <-- XMLComponentProducer.java new revision: 1.10; previous revision: 1.9
Adding fix: AddActionPresented should display only resolved actions, it is more safe for user so he will not be able to add unresolved producer to the document. Checking in AddActionPresenter.java; /cvs/mobility/designer2/model/src/org/netbeans/modules/vmd/api/model/presenters/actions/AddActionPresenter.java,v <-- AddActionPresenter.java new revision: 1.9; previous revision: 1.8 done
recent diffs: http://mobility.netbeans.org/source/browse/mobility/designer2/model/src/org/netbeans/modules/vmd/model/XMLComponentProducer.java?r1=1.9&r2=1.10 http://mobility.netbeans.org/source/browse/mobility/designer2/model/src/org/netbeans/modules/vmd/api/model/presenters/actions/AddActionPresenter.java?r1=1.8&r2=1.9
last fix: PaletteKit constructor access has been changed from public to package private Checking in PaletteKit.java; /cvs/mobility/designer2/palette/src/org/netbeans/modules/vmd/palette/PaletteKit.java,v <-- PaletteKit.java new revision: 1.30; previous revision: 1.29 done http://mobility.netbeans.org/source/browse/mobility/designer2/palette/src/org/netbeans/modules/vmd/palette/PaletteKit.java?r1=1.29&r2=1.30
Internal cache updating has been added - usability issue requested by Karol has been fixed. Checking in MidpJavaSupport.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/MidpJavaSupport.java,v <-- MidpJavaSupport.java new revision: 1.3; previous revision: 1.2 done http://mobility.netbeans.org/source/browse/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/MidpJavaSupport.java?r1=1.2&r2=1.3
verified in trunk build 20071109
Created attachment 52802 [details] final diff
Code Review: 1) possible race-condition/NPE in MidpJavaSupport.registerClassPathListener method: store "document.get()" into local variable and use it instead of "get" calls 2) possible race-condition/NPE in MidpJavaSupport.updateCacheImmediately method: store "document.get()" into local variable and use it instead of "get" calls 3) Maybe possible deadlock in MidpValidator.getDefault method The method is synchronized and it invokes a MidpValidator constructor which is MidpJavaSupport.getCache... which is invoking "MidpJavaSupport" constructor which is invoking "registerClassPathListener" which is blocking-invoking "JavaSource...runUserActionTask" .... so there may be a deadlock (but maybe not sure) Rather initiate the "instance" in "static {}" section.
fixed and merged to release60 branch Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SplashScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SplashScreenProducer.java,v <-- SplashScreenProducer.java new revision: 1.8.2.1; previous revision: 1.8 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGSplashScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGSplashScreenProducer.java,v <-- SVGSplashScreenProducer.java new revision: 1.8.2.1; previous revision: 1.8 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/LoginScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/LoginScreenProducer.java,v <-- LoginScreenProducer.java new revision: 1.12.2.1; previous revision: 1.12 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGWaitScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGWaitScreenProducer.java,v <-- SVGWaitScreenProducer.java new revision: 1.10.2.1; previous revision: 1.10 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/WaitScreenProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/WaitScreenProducer.java,v <-- WaitScreenProducer.java new revision: 1.13.2.1; previous revision: 1.13 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGMenuElementEventSourceProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGMenuElementEventSourceProducer.java,v <-- SVGMenuElementEventSourceProducer.java new revision: 1.7.2.1; previous revision: 1.7 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/PIMBrowserProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/PIMBrowserProducer.java,v <-- PIMBrowserProducer.java new revision: 1.7.2.1; previous revision: 1.7 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/FileBrowserProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/FileBrowserProducer.java,v <-- FileBrowserProducer.java new revision: 1.7.2.1; previous revision: 1.7 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SMSComposerProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SMSComposerProducer.java,v <-- SMSComposerProducer.java new revision: 1.11.2.1; previous revision: 1.11 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGMenuProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/SVGMenuProducer.java,v <-- SVGMenuProducer.java new revision: 1.9.2.1; previous revision: 1.9 done Checking in midpnb/src/org/netbeans/modules/vmd/midpnb/producers/CustomComponentProducer.java; /cvs/mobility/designer2/midpnb/src/org/netbeans/modules/vmd/midpnb/producers/CustomComponentProducer.java,v <-- CustomComponentProducer.java new revision: 1.22.2.1; previous revision: 1.22 done Checking in midp/src/org/netbeans/modules/vmd/midp/producers/MidpComponentProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/MidpComponentProducer.java,v <-- MidpComponentProducer.java new revision: 1.8.2.1; previous revision: 1.8 done Checking in midp/src/org/netbeans/modules/vmd/midp/producers/CommandProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/CommandProducer.java,v <-- CommandProducer.java new revision: 1.6.2.1; previous revision: 1.6 done Checking in midp/src/org/netbeans/modules/vmd/midp/producers/EntryPointProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/EntryPointProducer.java,v <-- EntryPointProducer.java new revision: 1.6.2.1; previous revision: 1.6 done Checking in midp/src/org/netbeans/modules/vmd/midp/producers/ListElementEventSourceProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/ListElementEventSourceProducer.java,v <-- ListElementEventSourceProducer.java new revision: 1.7.2.1; previous revision: 1.7 done Checking in midp/src/org/netbeans/modules/vmd/midp/producers/ChoiceElementProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/ChoiceElementProducer.java,v <-- ChoiceElementProducer.java new revision: 1.6.2.1; previous revision: 1.6 done Checking in midp/src/org/netbeans/modules/vmd/midp/producers/IfPointProducer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/producers/IfPointProducer.java,v <-- IfPointProducer.java new revision: 1.3.2.1; previous revision: 1.3 done Checking in midp/src/org/netbeans/modules/vmd/midp/resources/layer.xml; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/resources/layer.xml,v <-- layer.xml new revision: 1.26.4.1; previous revision: 1.26 done Checking in midp/src/org/netbeans/modules/vmd/midp/java/MidpValidator.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/MidpValidator.java,v <-- MidpValidator.java new revision: 1.1.2.1; previous revision: 1.1 done Removing midp/src/org/netbeans/modules/vmd/midp/java/ResolveListener.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/Attic/ResolveListener.java,v <-- ResolveListener.java new revision: delete; previous revision: 1.2.2 done Removing midp/src/org/netbeans/modules/vmd/midp/java/JavaClassNameResolver.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/Attic/JavaClassNameResolver.java,v <-- JavaClassNameResolver.java new revision: delete; previous revision: 1.2.2 done Checking in midp/src/org/netbeans/modules/vmd/midp/java/MidpJavaSupport.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/MidpJavaSupport.java,v <-- MidpJavaSupport.java new revision: 1.1.2.1; previous revision: 1.1 done Checking in midp/src/org/netbeans/modules/vmd/midp/java/MidpValidatorWarmUp.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/MidpValidatorWarmUp.java,v <-- MidpValidatorWarmUp.java new revision: 1.1.2.1; previous revision: 1.1 done Checking in model/src/org/netbeans/modules/vmd/model/XMLComponentProducer.java; /cvs/mobility/designer2/model/src/org/netbeans/modules/vmd/model/XMLComponentProducer.java,v <-- XMLComponentProducer.java new revision: 1.8.2.1; previous revision: 1.8 done Checking in model/src/org/netbeans/modules/vmd/api/model/presenters/actions/AddActionPresenter.java; /cvs/mobility/designer2/model/src/org/netbeans/modules/vmd/api/model/presenters/actions/AddActionPresenter.java,v <-- AddActionPresenter.java new revision: 1.7.2.1; previous revision: 1.7 done Checking in palette/src/org/netbeans/modules/vmd/api/palette/PaletteSupport.java; /cvs/mobility/designer2/palette/src/org/netbeans/modules/vmd/api/palette/PaletteSupport.java,v <-- PaletteSupport.java new revision: 1.5.2.1; previous revision: 1.5 done Checking in palette/src/org/netbeans/modules/vmd/palette/PaletteMap.java; /cvs/mobility/designer2/palette/src/org/netbeans/modules/vmd/palette/PaletteMap.java,v <-- PaletteMap.java new revision: 1.19.2.1; previous revision: 1.19 done Checking in palette/src/org/netbeans/modules/vmd/palette/PaletteKit.java; /cvs/mobility/designer2/palette/src/org/netbeans/modules/vmd/palette/PaletteKit.java,v <-- PaletteKit.java new revision: 1.28.2.1; previous revision: 1.28 done Checking in midp/src/org/netbeans/modules/vmd/midp/serialization/MidpProducerDeserializer.java; /cvs/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/serialization/MidpProducerDeserializer.java,v <-- MidpProducerDeserializer.java new revision: 1.4.2.1; previous revision: 1.4 done Checking in model/src/org/netbeans/modules/vmd/api/model/ComponentProducer.java; /cvs/mobility/designer2/model/src/org/netbeans/modules/vmd/api/model/ComponentProducer.java,v <-- ComponentProducer.java new revision: 1.5.4.1; previous revision: 1.5 done
last commit - possible NPE/race conditions fixed according to David's code review http://mobility.netbeans.org/source/browse/mobility/designer2/midp/src/org/netbeans/modules/vmd/midp/java/MidpJavaSupport.java?r1=1.4&r2=1.5
Verified in Branch 20071112 6.0RC1 =)
manowar, does it mean this issue is fixed in NB 6.0 ? If so please change the Target Milestone accordingly. Thanks in advance.
Yes. But target milestone was changed by QA.
the process in HR is: 1, Fix/commit the issue into trunk -> TM=Dev 2, wait for reviews, verification, etc. 3, Fix issue in branch -> but now you have to change the TM to 6.0 It has no sense to commit issue into trunk and have the TM=6.0 because it obviously isn't true anymore. Only fixes in the release60 branch will appear in the 6.0 release. I hope that it is more clear now.