This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 120279 - I18N - feature descriptions not from bundle in ja locale
Summary: I18N - feature descriptions not from bundle in ja locale
Status: VERIFIED FIXED
Alias: None
Product: installer
Classification: Unclassified
Component: NBI (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: dlipin
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2007-10-28 05:31 UTC by Ken Frank
Modified: 2007-10-29 22:26 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2007-10-28 05:31:40 UTC 
this has been discussed with Dmitry in other mail

using new ml installer, the customize window feature descriptions
are not from the messages from translated bundle file.

these descriptions are placed into a special xml file by installer
process and its some situation related to that that is the problem;
Dmitry knows about this.
Comment 1 dlipin 2007-10-28 11:27:21 UTC 
The problems is actually that getting the localized message works not as good as expected.
We store the specific localized messages (description, name, some properties) as a hashmap <Locale,String>.
We put them there for each of the bundled locale : 
map.put(default, "default name");
map.put(ja,"ja name");
map.put(zh_CN,"zh_CN name");

When we get the localized messages we just try to do map.get(Locale) : if we are actually in ja_JP locale (not just ja) 
then we receive message from the default locale which is wrong.
Comment 2 dlipin 2007-10-28 12:32:41 UTC 
related problem here:
we put the default message in this map using Locale.getDefault() but we don`t think here that Locale.getDefault() can 
be the same as Locale("zh","CN"). In that case only one message would exist in the map.

Possible the right variant of storing the default message would be using object Locale("","","")...
Comment 3 dlipin 2007-10-29 10:41:49 UTC 
Hope that is fixed now.

Checking in product/components/Group.java;
/cvs/nbi/engine/src/org/netbeans/installer/product/RegistryNode.java,v  <--  RegistryNode.java
new revision: 1.21; previous revision: 1.20
done
Checking in product/components/Group.java;
/cvs/nbi/engine/src/org/netbeans/installer/product/components/Group.java,v  <--  Group.java
new revision: 1.7; previous revision: 1.6
done
Checking in utils/StringUtils.java;
/cvs/nbi/engine/src/org/netbeans/installer/utils/StringUtils.java,v  <--  StringUtils.java
new revision: 1.44; previous revision: 1.43
done
Checking in utils/XMLUtils.java;
/cvs/nbi/engine/src/org/netbeans/installer/utils/XMLUtils.java,v  <--  XMLUtils.java
new revision: 1.47; previous revision: 1.46
done
Checking in utils/helper/Feature.java;
/cvs/nbi/engine/src/org/netbeans/installer/utils/helper/Feature.java,v  <--  Feature.java
new revision: 1.4; previous revision: 1.3
done
Checking in utils/system/shortcut/Shortcut.java;
/cvs/nbi/engine/src/org/netbeans/installer/utils/system/shortcut/Shortcut.java,v  <--  Shortcut.java
new revision: 1.6; previous revision: 1.5
done
Comment 4 Ken Frank 2007-10-29 21:19:18 UTC 
it looks good so far on solaris; will do on windows soon.
will not do on mac now since that will await the separate mac installer.

ken.frank@sun.com
Comment 5 Ken Frank 2007-10-29 22:26:43 UTC 
looks ok on windows in the ja and zh (PRC) regional settings.

will verify.

ken.frank@sun.com