This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 119116 - Tests uncompilable
Summary: Tests uncompilable
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Settings (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Vitezslav Stejskal
URL: http://deadlock.netbeans.org/fisheye/...
Keywords: TEST
Depends on:
Blocks:
 
Reported: 2007-10-16 19:35 UTC by Jesse Glick
Modified: 2007-11-05 13:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2007-10-16 19:35:48 UTC 
http://deadlock.netbeans.org/hudson/job/test-compilation/107/ failed to build because editor/settings/storage now has a
(regular) dep on editor/lib, whereas editor/lib already had a test dep on editor/settings/storage. This is a cyclic
dependency.

Perhaps EditorTestLookup should be moved down to editor/lib? BTW (1) you can use MockLookup now; (2)
Repository.default.defaultFileSystem in unit tests now loads layers from the classpath automatically; (3) you can use
FileUtil methods to load the contents of a ZIP as a FileSystem.
Comment 1 Jesse Glick 2007-10-16 19:51:39 UTC 
After this commit:

Checking in SortSuiteModules.java;
/shared/data/ccvs/repository/nbbuild/antsrc/org/netbeans/nbbuild/SortSuiteModules.java,v  <--  SortSuiteModules.java
new revision: 1.13; previous revision: 1.12
done

running

ant -f nbbuild/build.xml -Dtest.fail.on.error=false build-test-dist

will now fail with a final message:

 Conflict #0: [org.netbeans.modules.editor.lib, org.netbeans.modules.editor.settings.storage]
Comment 2 Vitezslav Stejskal 2007-10-17 09:23:57 UTC 
Ok, I'm looking into it.
Comment 3 Vitezslav Stejskal 2007-10-17 11:37:26 UTC 
Should build fine now.

Checking in editor/util/api/apichanges.xml;
/cvs/editor/util/api/apichanges.xml,v  <--  apichanges.xml
new revision: 1.17; previous revision: 1.16
done
RCS file: /cvs/editor/util/src/org/netbeans/lib/editor/util/CharacterConversions.java,v
done
Checking in editor/util/src/org/netbeans/lib/editor/util/CharacterConversions.java;
/cvs/editor/util/src/org/netbeans/lib/editor/util/CharacterConversions.java,v  <--  CharacterConversions.java
initial revision: 1.1
done
Checking in editor/lib/apichanges.xml;
/cvs/editor/lib/apichanges.xml,v  <--  apichanges.xml
new revision: 1.13; previous revision: 1.12
done
Checking in
editor/settings/storage/src/org/netbeans/modules/editor/settings/storage/codetemplates/CodeTemplatesStorage.java;
/cvs/editor/settings/storage/src/org/netbeans/modules/editor/settings/storage/codetemplates/CodeTemplatesStorage.java,v
 <--  CodeTemplatesStorage.java
new revision: 1.8; previous revision: 1.7
done
Checking in editor/settings/storage/nbproject/project.xml;
/cvs/editor/settings/storage/nbproject/project.xml,v  <--  project.xml
new revision: 1.14; previous revision: 1.13
done
Checking in editor/libsrc/org/netbeans/editor/LineSeparatorConversion.java;
/cvs/editor/libsrc/org/netbeans/editor/LineSeparatorConversion.java,v  <--  LineSeparatorConversion.java
new revision: 1.9; previous revision: 1.8
done
Checking in editor/util/manifest.mf;
/cvs/editor/util/manifest.mf,v  <--  manifest.mf
new revision: 1.23; previous revision: 1.22
done
Checking in editor/lib/nbproject/project.properties;
/cvs/editor/lib/nbproject/project.properties,v  <--  project.properties
new revision: 1.25; previous revision: 1.24
done
Comment 4 Jesse Glick 2007-10-17 19:30:15 UTC 
Yes, back to normal now.