This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 115902 - I18N - regenerate samples so can use the new project/file encoding features
Summary: I18N - regenerate samples so can use the new project/file encoding features
Status: VERIFIED FIXED
Alias: None
Product: webservices
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: Sun All
: P3 blocker (vote)
Assignee: Martin Grebac
URL:
Keywords: I18N
Depends on: 118474 118476
Blocks:
  Show dependency tree
 
Reported: 2007-09-18 18:54 UTC by Ken Frank
Modified: 2008-06-03 17:21 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2007-09-18 18:54:04 UTC
nb6 has concept of project file encoding, which was not there before.
default project encoding is utf-8 until user changes it in some project, then newly created
projects use that encoding and show it in project props.

for web svc samples, the project encoding shown is utf-8 even in cases where the current
global project encoding is something else.

current sample web projects have related issue filed; in their case they use the encoding of locale
user is in for the project encoding, vs utf-8 for these web svc samples.

additional info is below - since other steps might need to be done; contact Tomas Zezula for details:



-- the fix for javadoc has been filed for various  project types; the fix relates
to javadoc.encoding property defined in the project.properties
wasn't used only defined - and regeneration can help avoid issues with javadoc not generating due to encoding problems
 
3. the regeneration of the sample projects for nb6 could help with these
warning since the build-impl.xml
will also be regenerated.   Tomas can provide more information on these topics.
 
4. Also, these samples might have jsp or html files in them and the 
encoding value used in creation of these files is different than in past, and
works with the new project
encoding, so regeneration of the samples might help those files in the samples 
to be compatible with that.

that is, now jsp, html and xml files seed their newly created files with encoding of project, not UTF-8
Comment 1 Ken Frank 2007-10-09 20:13:45 UTC
please fix this soon so we can have uniform behavior of all projects and samples
related to encoding and other things mentioned below.

ken.frank@sun.com
Comment 2 Martin Grebac 2007-10-11 01:24:04 UTC
 I'm not able to regenerate the samples because the build doesn't work - see blocking issues. 

 If I understand it correctly, it's not about regenerating samples. It's about generating them dynamically based on the
current encoding value. That's not the same thing - it's much more than regenerating them. Or do I not understand the
issue correctly?

 Where is a document that describes what has changed and what exactly needs to be done?

 More, I found http://www.netbeans.org/issues/show_bug.cgi?id=108903 filed as a P3, thus decreasing priority to match
priority as these are exactly same issues.

 I'll fix it once I know what exactly needs to be done and once build is working fine.
Comment 3 Martin Grebac 2007-10-11 01:24:28 UTC
 I'm not able to regenerate the samples because the build doesn't work - see blocking issues. 

 If I understand it correctly, it's not about regenerating samples. It's about generating them dynamically based on the
current encoding value. That's not the same thing - it's much more than regenerating them. Or do I not understand the
issue correctly?

 Where is a document that describes what has changed and what exactly needs to be done?

 More, I found http://www.netbeans.org/issues/show_bug.cgi?id=108903 filed as a P3, thus decreasing priority to match
priority as these are exactly same issues.

 I'll fix it once I know what exactly needs to be done and once build is working fine.
Comment 4 Ken Frank 2007-10-11 01:49:33 UTC
The info here is all I know about it; I 'm not a developer; got the info from Tomas Zezula
and he can tell you more. 

It may be that its more than regenration of sample; that seemed to be wording that I saw
and that I've been using for whatever is related to fix the problem described here
and other things feq and eencoding wise that might not work well if the additonal steps and regeneration
is not done.

It looks like I either did file others at p3 vs p2 or those were changed to p3 but in any case, I do belive
its needed to be fixed so consistent as to feq with other project types and so not to have incorrect
effect on feq also; looks like just web, j2ee and this one are not yet done on this topic.

ken.frank@sun.com
Comment 5 Martin Grebac 2007-10-11 06:00:49 UTC
OK, I asked Tomas for more info.
Comment 6 Martin Grebac 2007-10-11 16:16:14 UTC
I got info from Tomas. I will regenerate the samples, but I'll do it after Beta2 as I see move still in the project
build files, definitions, properties, ... so I'd still have to do it after beta2 anyway.
Comment 7 Martin Grebac 2007-10-13 00:10:58 UTC
I regenerated all the samples. Have to say that is a hassle since a lot of things is changing in the meantime.
Comment 8 Ken Frank 2007-10-14 16:32:47 UTC
I do realize it is a hassle, it was filed based on the advice and guidance from development; I did not
just choose to file it for no reason.

as to the changes still happening, does it mean the samples would need to be regenerated
again to fix the things mentioned in this issue ?

ken.frank@sun.com
Comment 9 Martin Grebac 2007-10-15 01:56:32 UTC
It depends whether there will be a bigger changes in the web project layout. They are not expected, because the issues 
I mentioned have been already fixed before I regenerated the samples.
Comment 10 Ken Frank 2007-10-29 22:11:21 UTC
the encoding of the project is still utf-8, regardless of what the current
project encoding value is.

I dont know if its ok for samples or not; that is, other samples are using
current project encoding and thus I don't know if they all need to have consistent
behavior; I think they should at least so user not get confused about what the encoding
is.

when a new project is created, however the utf-8 is not used for that other new
project, if not another ws sample, but the current project encoding is used.

if this is still problem due to other fixes and changes that have happened and are in progres since this last fix was
done, I suggest waiting until after code freeze this week before doing any more
fix on it.

ken.frank@sun.com
Comment 11 kaa 2008-06-03 17:21:47 UTC
verified using trunk build 0529.

Samples encoding looks always UTF-8. it seems decided that it is ok.
Project encoding doesn't depend on this. I created a project using win-31j then created a sample (utf-8) and after this
created another one new project. It had win-31j.