This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 114588 - Use EntityManager action should not use FQNs
Summary: Use EntityManager action should not use FQNs
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Persistence (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: Andrei Badea
URL:
Keywords:
Depends on: 114623
Blocks:
  Show dependency tree
 
Reported: 2007-09-04 10:03 UTC by Erno Mononen
Modified: 2014-07-09 15:02 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erno Mononen 2007-09-04 10:03:07 UTC
build 0902.

In several contexts the Use EntityManager Action generates code that uses fully qualified names. It should use simple 
names and imports instead.
Comment 1 Erno Mononen 2007-09-04 14:07:38 UTC
Fixed in trunk for the most part, but some FQNs still remain (issue 114623), so I'm leaving this open but lowering to 
P4. 

Also, I unintentionally committed one unrelated fix as a part of this, namely re-enabling of the comment about adding a 
persistence-context-ref to web/ejb.xml, which was still disabled after Retouche migration (in 
ContainerManagedJTANonInjectableInWeb).

Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ContainerManagedJTAInjectableInWebTest/testGenerate.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ContainerManagedJTAInjectableInWebTest/testGenerate.pass,v  <--  testGenerate.pass
new revision: 1.8; previous revision: 1.7
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionNonInjectableInEJBTest/testGenerateWithExistingEMF.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionNonInjectableInEJBTest/testGenerateWithExistingEMF.pass,v  <--  
testGenerateWithExistingEMF.pass
new revision: 1.4; previous revision: 1.3
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionNonInjectableInEJBTest/testGenerate.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionNonInjectableInEJBTest/testGenerate.pass,v  <--  testGenerate.pass
new revision: 1.6; previous revision: 1.5
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ContainerManagedJTAInjectableInWeb.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ContainerManagedJTAInjectableInWeb.java,v  <--  ContainerManagedJTAInjectableInWeb.java
new revision: 1.3; previous revision: 1.2
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
EntityManagerGenerationStrategySupport.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
EntityManagerGenerationStrategySupport.java,v  <--  EntityManagerGenerationStrategySupport.java
new revision: 1.7; previous revision: 1.6
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionInjectableInWeb.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionInjectableInWeb.java,v  <--  
ApplicationManagedResourceTransactionInjectableInWeb.java
new revision: 1.3; previous revision: 1.2
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionNonInjectableInEJB.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionNonInjectableInEJB.java,v  <--  
ApplicationManagedResourceTransactionNonInjectableInEJB.java
new revision: 1.3; previous revision: 1.2
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ContainerManagedJTAInjectableInEJB.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ContainerManagedJTAInjectableInEJB.java,v  <--  ContainerManagedJTAInjectableInEJB.java
new revision: 1.4; previous revision: 1.3
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionInJ2SE.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionInJ2SE.java,v  <--  ApplicationManagedResourceTransactionInJ2SE.java
new revision: 1.3; previous revision: 1.2
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionInjectableInEJB.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionInjectableInEJB.java,v  <--  
ApplicationManagedResourceTransactionInjectableInEJB.java
new revision: 1.3; previous revision: 1.2
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ContainerManagedJTANonInjectableInWeb.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ContainerManagedJTANonInjectableInWeb.java,v  <--  ContainerManagedJTANonInjectableInWeb.java
new revision: 1.3; previous revision: 1.2
done
Checking in src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionNonInjectableInWeb.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/spi/entitymanagergenerator/
ApplicationManagedResourceTransactionNonInjectableInWeb.java,v  <--  
ApplicationManagedResourceTransactionNonInjectableInWeb.java
new revision: 1.4; previous revision: 1.3
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ContainerManagedJTANonInjectableInWebTest/testGenerateWithExistingEM.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ContainerManagedJTANonInjectableInWebTest/testGenerateWithExistingEM.pass,v  <--  testGenerateWithExistingEM.pass
new revision: 1.4; previous revision: 1.3
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ContainerManagedJTANonInjectableInWebTest/testGenerate.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ContainerManagedJTANonInjectableInWebTest/testGenerate.pass,v  <--  testGenerate.pass
new revision: 1.6; previous revision: 1.5
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionInJ2SETest/testGenerate.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionInJ2SETest/testGenerate.pass,v  <--  testGenerate.pass
new revision: 1.6; previous revision: 1.5
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionInJ2SETest/testGenerateWithExistingEMF.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionInJ2SETest/testGenerateWithExistingEMF.pass,v  <--  
testGenerateWithExistingEMF.pass
new revision: 1.4; previous revision: 1.3
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionNonInjectableInWebTest/testGenerateWithExistingEMF.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionNonInjectableInWebTest/testGenerateWithExistingEMF.pass,v  <--  
testGenerateWithExistingEMF.pass
new revision: 1.4; previous revision: 1.3
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionNonInjectableInWebTest/testGenerate.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionNonInjectableInWebTest/testGenerate.pass,v  <--  testGenerate.pass
new revision: 1.7; previous revision: 1.6
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionInjectableInWebTest/testGenerate.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionInjectableInWebTest/testGenerate.pass,v  <--  testGenerate.pass
new revision: 1.6; previous revision: 1.5
done
Checking in test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionInjectableInWebTest/testGenerateWithExistingEMF.pass;
/cvs/j2ee/persistence/test/unit/data/goldenfiles/org/netbeans/modules/j2ee/persistence/action/
ApplicationManagedResourceTransactionInjectableInWebTest/testGenerateWithExistingEMF.pass,v  <--  
testGenerateWithExistingEMF.pass
new revision: 1.4; previous revision: 1.3
done
Comment 2 Dongmei Cao 2008-07-22 00:11:49 UTC
Since issue 114623 has been fixed. Mark this bug as "FIXED"