This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Ctrl-R (redo in jVi) is not delivered to jVi in the html editor, I also noticed that it is lost in the Jackpot Rules editor. Other control keys are not affected; they get delivered to jVi just fine. Any ideas how I can best track this down?
HTML is Schliemann based, I'm not sure about Jackpot Rules, but it is probably Schliemann based too. Java, properties, plain text are non-schliemann base. Could you please try other schliemann languages, eg. javascript if it works for them or not? Thanks
Seems you are on to something about schliemann involved in the problem Ctrl-R WORKS for plain text, java, xml, properties. Ctrl-R FAILS for java script, html, jackpot rules
Thanks for that. IMO this might be caused by issue #114747, which is caused by broken kitClass -> mime-type translation for schliemann languages (all using LanguagesEditorKit).
What are the chances of this being fixed for the 6.0 release? Can you think of an experiment to check if issue 114747 is indeed related?
It sort of is, but could be remedied. I recall fixing similar problem for ctrl+/, which was hardcoded in LanguagesEditorKit.install() IIRC. I spotted there that LEK also hardcodes ctrl+R for some reason. I'm not sure why, but LEK needs to install its own action for it and this looks like a hack that they needed to do to make it work. IMO a solution would be to: - look to all modules that use ctrl+R and see what action-id they bind it to - unify that, eg if different modules bind it to different names, choose just one - add the binding from the editor module for all languages (Editor/Keybindings/Defaults) and remove the biding from all the other modules. They will still install their own actions for it, which will have to use the unified action-id. - test the change for languages implemented by the affected modules and of course for jVi Ernie, the deadline is Sunday night, if you are around and willing to help please start working on it, assign to yourself and change status to STARTED. Get as far as you can and attach the patch, I'll finish or just review it and commit. Thanks
> add the binding from the editor module for all languages (Editor/Keybindings/Defaults)... I'm assuming this is done by adding the binding to: editor/src/org/netbeans/modules/editor/resources/NetBeans-keybindings.xml and NetBeans55-keybindings.xml already has the binding. Is this the only place it needs to be added? I'm attaching the relevant output from two greps, for key=.D-R in-place-refactoring this info looks like enough to make the change. It looks like everything uses the same action-id, so don't have to worry about that. It shouldn't take too long and I'll do it Sunday morning (GMT-8). It does seem a little funny to add this to any/all editors, its not like a motion command that makes sense no matter what you are editting. I guess if the action isn't defined then the binding does nothing?
Created attachment 52462 [details] grep for in-place-refactoring
Created attachment 52463 [details] grep for key=.D-R
Created attachment 52464 [details] grep for key=.D-R (with correct mime type)
> I'm assuming this is done by adding the binding to: > editor/src/org/netbeans/modules/editor/resources/NetBeans-keybindings.xml >and NetBeans55-keybindings.xml already has the binding. Is this the only place it needs to be added? Yes, it has to be added to these two profiles. There are other keybinding profiles (Emacs, Eclipse) in ide/defaults module. I'm not sure if they define it or actually what shortcut they bind to 'in-place-refactoring'. > It does seem a little funny to add this to any/all editors, its not like a motion command that makes sense no matter > what you are editting. I guess if the action isn't defined then the binding does nothing? Correct, not used bindings do nothing. Adding it for all editors is kind of a hack of course. Thanks for your help Ernie.
Created attachment 52487 [details] patch to consistently make in-place-refactoring a keybinding
In addition to default, the keybinding was added to Emacs and Eclipse (they had no D-R (Ctrl-R) keybinding). Limitted testing. Did not test ruby or ruby's html or java script. Reassigning to Vita to consider patch.
Thanks Ernie, the patch is looking good. I'm going to apply it asap.
Applied and commited. Awesome job Ernie, thanks a lot. Checking in languages/engine/src/org/netbeans/modules/languages/dataobject/LanguagesEditorKit.java; /cvs/languages/engine/src/org/netbeans/modules/languages/dataobject/LanguagesEditorKit.java,v <-- LanguagesEditorKit.java new revision: 1.28; previous revision: 1.27 done Checking in ruby/rhtml/src/org/netbeans/modules/ruby/rhtml/resources/DefaultKeyBindings.xml; /cvs/ruby/rhtml/src/org/netbeans/modules/ruby/rhtml/resources/DefaultKeyBindings.xml,v <-- DefaultKeyBindings.xml new revision: 1.7; previous revision: 1.6 done Checking in cnd/refactoring/src/org/netbeans/modules/cnd/refactoring/DefaultKeyBindings.xml; /cvs/cnd/refactoring/src/org/netbeans/modules/cnd/refactoring/DefaultKeyBindings.xml,v <-- DefaultKeyBindings.xml new revision: 1.2; previous revision: 1.1 done Checking in editor/src/org/netbeans/modules/editor/resources/NetBeans-keybindings.xml; /cvs/editor/src/org/netbeans/modules/editor/resources/NetBeans-keybindings.xml,v <-- NetBeans-keybindings.xml new revision: 1.25; previous revision: 1.24 done Checking in ide/defaults/src/org/netbeans/modules/defaults/Emacs-keybindings.xml; /cvs/ide/defaults/src/org/netbeans/modules/defaults/Emacs-keybindings.xml,v <-- Emacs-keybindings.xml new revision: 1.27; previous revision: 1.26 done Checking in ide/defaults/src/org/netbeans/modules/defaults/Eclipse-keybindings.xml; /cvs/ide/defaults/src/org/netbeans/modules/defaults/Eclipse-keybindings.xml,v <-- Eclipse-keybindings.xml new revision: 1.20; previous revision: 1.19 done Checking in java/editor/src/org/netbeans/modules/java/editor/resources/DefaultKeyBindings.xml; /cvs/java/editor/src/org/netbeans/modules/java/editor/resources/DefaultKeyBindings.xml,v <-- DefaultKeyBindings.xml new revision: 1.21; previous revision: 1.20 done Checking in languages/engine/src/org/netbeans/modules/languages/resources/DefaultKeyBindings.xml; /cvs/languages/engine/src/org/netbeans/modules/languages/resources/DefaultKeyBindings.xml,v <-- DefaultKeyBindings.xml new revision: 1.7; previous revision: 1.6 done Checking in ruby/editing/src/org/netbeans/modules/ruby/DefaultKeyBindings.xml; /cvs/ruby/editing/src/org/netbeans/modules/ruby/DefaultKeyBindings.xml,v <-- DefaultKeyBindings.xml new revision: 1.13; previous revision: 1.12 done