This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 114004 - A11Y issues in Add Server Instance dialogue
Summary: A11Y issues in Add Server Instance dialogue
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 9 (show other bugs)
Version: 6.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: Vince Kraemer
URL:
Keywords: A11Y, I18N
: 127222 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-08-28 14:42 UTC by Marian Petras
Modified: 2008-03-04 20:33 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (17.22 KB, image/gif)
2007-08-28 14:46 UTC, Marian Petras
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marian Petras 2007-08-28 14:42:53 UTC
I have found several UI issues related to font size (see the attached screenshot)
 - the dialogue is too small to fit all UI elements
 - names of the steps are word-wrapped, which is correct, but the order number on the left
   is vertically centred - it should be line-aligned with the first line of the name of the step
Comment 1 Marian Petras 2007-08-28 14:45:12 UTC
System Info: 
  Product Version         = NetBeans IDE Dev (Build 070828)
  Operating System        = Linux version 2.6.14-1.1656_FC4 running on i386
  Java; VM; Vendor        = 1.5.0_12; Java HotSpot(TM) Client VM 1.5.0_12-b04; Sun Microsystems Inc.
  Java Home               = /usr/local/java/jdk1.5.0_12/jre
  System Locale; Encoding = en_US (nb); UTF-8
Comment 2 Marian Petras 2007-08-28 14:46:04 UTC
Created attachment 47616 [details]
screenshot
Comment 3 Vince Kraemer 2007-08-28 17:50:02 UTC
any info you can provide about the font size you were using for this screen shot would be helpful...
Comment 4 Marian Petras 2007-08-28 17:57:54 UTC
I was running NetBeans with parameter --fontsize 17.

At home, I am running using switch --fontsize 20 with which all the imperfections are even more apparent.
Comment 5 Vince Kraemer 2007-08-28 18:50:20 UTC
I did a bit of investigation.

if I start the IDE with fontsize 20, the dialog to register a server instance is almost exactly the same size as it is
when the fontsize is the default (which is 12, right).  The initial dialog was only a couple pixels wider and taller.

I would have expected the dialog to be bigger, since the content is likely to be bigger...

If I selected any of the other server types... the dialog explodes in size... This kind of behavior was considered a p2
bug...

The easiest way to prevent this issue is to make the initial page of the dialog scale relative to the fontsize....  that
first page of the dialog is in the j2eeserver code.
Comment 6 Ken Frank 2007-09-19 15:42:35 UTC
this has been seen related to i18n testing using pseudo localized files; I had thought it was just seen there 
but this confirms it can be seen even without translated msgs.

See issue 109158.

I will change that one to p2 now since IMO it needs to be fixed; it shows at even smaller font sizes when using
the multibyte characters.

ken.frank@sun.com
Comment 7 Petr Hejl 2007-09-26 12:41:44 UTC
The reason why some elements are not visible is that all panels in glassfish plugin has its preferred size manualy set
to 0,0.
- It seems to me like some kind of quick hack - why should be preferred size of panel zero?.
- Why are all sizes of all components null?
- Spacing hack label is not much useful - you should use layout composed of panels.
- Text field height is not consistent with other text fields (because of vertical fill).
- Maybe Free Design (GroupLayout) could be better for layout
- TXT_platformPanelDescription is missing end tag

My opinion is that the dialog (and probably others) should be rewritten in more clean way. After all if you will not be
able to fit all the components to the reasonable size, the wizard dialog will get bigger in runtime - as for other cases
like the "New Project" wizard others.

I filed issue 116794 to get the dialog size behaviour clear (across the whole IDE).
Comment 8 Petr Hejl 2007-09-26 12:43:46 UTC
Reassigning to glassfish.
Comment 9 Vince Kraemer 2007-09-27 01:43:33 UTC
I have no idea how to fix this
Comment 10 Vince Kraemer 2007-09-28 23:47:26 UTC
The requested behavioral change for the add server panels is completely contradictory to issue 105546. the correct fix
from perspective of the filer of issue 105546 would be to resize the initial dialog, so that the server dialog does not
resize as the user pages through it.

The glassfish plugin's dialog panels attempt to fit into the space that they were give by their parent. No more. 

That is their expected behavior.

What is wrong with making the initial dialog larger, based on the default font size?
Comment 11 Petr Hejl 2007-10-01 09:36:33 UTC
I don't think the change is completely contradictory to issue 105546. The filer reported _rapid_ size change. The size
change of the dialog is guarded by the dialog infrastructure and it is the bahaviour that can be observed in every
wizard across the ide. Hacking this behaviour for one single wizard seems quite bad to me.

The other trouble with solution you suggest (we make the initial dialog larger, based on the default font) is: Will it
be large enough? What happens when somebody adds a component? Or when the server plugin we do not control will have a
panel with many components? We change the resizing constant? And if it should be done this way (I doubt) it should be
done across the whole ide.

Afaik the panel of the wizard should have reasonable size (I know it's bad specification, but it's the way how it
works). Wizard infrastructure then takes the actual size of the control font and the preferred size of panel and
computes the size of dialog.

The glassfish panel actually does not made any attempt to fit to dialog - it just set its preferred size to [0,0]. What
is the semantical meaning? It does not require any space? If you leave the default panel size then the dialog is resized
rapidly. But that rapid resizement is caused by overall bad panel layout design.
Comment 12 Marian Petras 2007-10-01 12:57:48 UTC
My reasonings:

1) It is not possible to avoid size change without pre-computation of preferred sizes of all panels that might possibly
appear in the dialogue.
2) Probability and magnitude of the necessary change of size can be reduced by computing a rough estimation of necessary
size. This cannot be done for dynamically plugged wizard panels.
3) No matter how rapid the size change is, it is always better than need for resizing the dialogue manually. Tell it to
your UI engineers and advisers. If they disagree, I am ready to argue about it.
4) I would like to know whether slow size change is acceptable. Has anybody thought about how the slow size change would
work?
Comment 13 Andrei Badea 2007-10-02 12:51:26 UTC
Re mpetras's #3: all wizard panels should be streamlined so that they fit in the wizard with the default font size. If a
panel can't fit, it contains too many components and it needs to be split. There should never be a need to resize the
wizard manually with the default font size. With larger fonts, there is code in WizardDescriptor which makes the wizard
larger. This may cause the wizard to enlarge when displaying subsequent panels, which I agree is a behavior that cannot
be avoided without expensive precomputation.

What is a "rapid" and "slow" size change by the way?
Comment 14 Marian Petras 2007-10-02 16:21:29 UTC
I did not have any concrete font size in my mind when writing my previous post. I do not care about "default font size"
as I always use larger font font size. To make it simple - I am always thinking how to make it working with large fonts
(font size 15, 25, 50... arbitrary), default font size does not matter.

Ad "rapid" and "slow" - I was referring to issue #105546 ("UI problem -> add instance wizard rapidly change its
proporions").
Comment 15 Vince Kraemer 2008-03-04 19:22:52 UTC
*** Issue 127222 has been marked as a duplicate of this issue. ***
Comment 16 Vince Kraemer 2008-03-04 20:33:11 UTC
http://hg.netbeans.org/main/rev/b627b19f9307