This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 112329 - Code Completin doesn't work properly in web.xml editor
Summary: Code Completin doesn't work properly in web.xml editor
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Erno Mononen
URL:
Keywords:
: 113574 (view as bug list)
Depends on:
Blocks: 113664
  Show dependency tree
 
Reported: 2007-08-08 15:33 UTC by Petr Pisl
Modified: 2007-09-03 13:47 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
stacktrace (1.56 KB, text/plain)
2007-08-22 09:45 UTC, Erno Mononen
Details
j2ee/ddloaders diff (614.31 KB, patch)
2007-08-22 09:46 UTC, Erno Mononen
Details | Diff
j2ee/ddloaders diff patch (4.33 KB, application/octet-stream)
2007-09-02 06:56 UTC, Samaresh Panda
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Pisl 2007-08-08 15:33:10 UTC
Open the deployment descriptor editor, open the XML tab and write <jsp-config> tag. Try to invoke code completion after
this tag. There are "No suggestions".
Comment 1 Marek Fukala 2007-08-09 12:45:26 UTC
This looks like a problem in the xml schama based completion. I found that the jsp-config element content specification
is not in the declared 

http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd

schema, but is contained in included jsp_2_0.xsd schema. So it looks like the model doesn't properly reflect the
included schemas content.

Anyway, this is xml module issue so reassigning to the default owner.
Comment 2 Samaresh Panda 2007-08-09 22:27:22 UTC
The problem is that, included and imported schemas are loaded from the relative location as specified in the primary
schema. CC in web.xml uses web-app_2_5.xsd which is available in runtime catalog. This includes, two more schemas:

  <xsd:include schemaLocation="javaee_5.xsd"/>
  <xsd:include schemaLocation="jsp_2_1.xsd"/>

which can not be found/loaded from the same location as the primary and hence the problem. Is there any way we can make
them available there?
Comment 3 Petr Pisl 2007-08-10 09:54:47 UTC
OK, I will add jsp_2_1.xsd to the catalog. Reassigning to me and increasing priority, because for as it's important and
it's regression. Is there any general issue, which describes the problem with imported shemas? 
Comment 4 Erno Mononen 2007-08-13 11:41:15 UTC
So basically this also means that all schemas in j2ee/ddloaders should be in one directory (unless we want to duplicate 
javaee schemas within the module). Currently they are in [app|web|ejb|application].resources folders.
Comment 5 Erno Mononen 2007-08-15 15:56:55 UTC
I can have a look at this since I have been doing some changes in this area lately.
Comment 6 Erno Mononen 2007-08-21 12:27:26 UTC
Working on this now.
Comment 7 Erno Mononen 2007-08-22 09:44:05 UTC
Samaresh, could you please have a look at this? 

I put all included schemas into the same directory, but I'm getting the following AE when invoking code completion in 
web.xml:

java.lang.AssertionError
	at org.netbeans.modules.xml.xam.AbstractModelFactory.getModel(AbstractModelFactory.java:108)
	at org.netbeans.modules.xml.schema.model.SchemaModelFactory.getModel(SchemaModelFactory.java:95)
	at org.netbeans.modules.xml.schema.model.impl.IncludeImpl.resolveReferencedModel(IncludeImpl.java:78)
...

I have sources from 08/20, JDK 1.5 and Linux.

I'm attaching the full stack trace and a patch for the j2ee/ddloaders module that contains the catalog and the schemas. 
I noticed an email about the same excpeption on nbdev that suggested prefixing the included schema with its target 
namespace - tried that, but no dice. I would also be interested to know whether all included schemas need to be 
provided by the same catalog that provides the schema itself? That's what I've done now (since I thought that providing 
included schemas from a different catalog was causing the error), but not sure whether it is really needed. Thanks. 
Comment 8 Erno Mononen 2007-08-22 09:45:31 UTC
Created attachment 47035 [details]
stacktrace
Comment 9 Erno Mononen 2007-08-22 09:46:49 UTC
Created attachment 47036 [details]
j2ee/ddloaders diff
Comment 10 Petr Jiricka 2007-08-24 23:41:45 UTC
Samaresh, any input on this? Assigning to xml.
Comment 11 Samaresh Panda 2007-08-24 23:56:13 UTC
It came to my notice recently. I think imported/included schemas are not getting loaded. I'll look into this and get back.
Comment 12 Samaresh Panda 2007-09-02 06:53:57 UTC
Fix integrated:
/cvs/xml/xdm/src/org/netbeans/modules/xml/xdm/xam/XDMAccessProvider.java,
new revision: 1.3; previous revision: 1.2

Second part of the fix will be:
1. Register the referenced schemas in catalog
2. The reference path should use the system-id.

In web-app_2_5.xsd, the import should be changed as follows:

<xsd:include schemaLocation="http://java.sun.com/xml/ns/javaee/javaee_5.xsd"/>
<xsd:include schemaLocation="http://java.sun.com/xml/ns/javaee/jsp_2_1.xsd"/>

assuming that these two schemas are registered with the above mentioned system-id.

I'm attaching the diff patch for j2ee/ddloaders.
Comment 13 Samaresh Panda 2007-09-02 06:56:23 UTC
Created attachment 47936 [details]
j2ee/ddloaders diff patch
Comment 14 Samaresh Panda 2007-09-02 06:58:41 UTC
Assigning to Petr for the fix in ddloaders.
Comment 15 Samaresh Panda 2007-09-02 17:25:55 UTC
*** Issue 113574 has been marked as a duplicate of this issue. ***
Comment 16 Erno Mononen 2007-09-02 18:48:13 UTC
Thanks Samaresh, I will integrate the patch.
Comment 17 Erno Mononen 2007-09-03 13:47:11 UTC
Fixed in trunk. Note that I didn't really apply the patch as such, but modified the patch I attached here earlier. I 
changed all schemas in ddloaders to be provided by the same catalog, o.n.m.j2ee.ddloaders.catalog.EnterpriseCatalog 
(which I moved there with the needed resources from o.n.m.j2ee.ddloaders.app) mainly to avoid duplicating schemas in 
different catalogs. The commit fixes also issue 113664. 

Removing app/resources/javaee_web_services_1_2.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/resources/javaee_web_services_1_2.xsd,v  <--  
javaee_web_services_1_2.xsd
new revision: delete; previous revision: 1.2
done
Removing app/resources/application_1_4.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/resources/application_1_4.xsd,v  <--  
application_1_4.xsd
new revision: delete; previous revision: 1.2
done
Removing app/resources/j2ee_web_services_client_1_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/resources/j2ee_web_services_client_1_1.xsd,v  <--  
j2ee_web_services_client_1_1.xsd
new revision: delete; previous revision: 1.2
done
Removing app/resources/application_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/resources/application_5.xsd,v  <--  application_5.xsd
new revision: delete; previous revision: 1.2
done
Removing app/resources/connector_1_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/resources/connector_1_5.xsd,v  <--  connector_1_5.xsd
new revision: delete; previous revision: 1.2
done
Removing app/resources/j2ee_web_services_1_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/resources/j2ee_web_services_1_1.xsd,v  <--  
j2ee_web_services_1_1.xsd
new revision: delete; previous revision: 1.2
done
Removing app/resources/javaee_web_services_client_1_2.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/resources/javaee_web_services_client_1_2.xsd,v  <--  
javaee_web_services_client_1_2.xsd
new revision: delete; previous revision: 1.2
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/application-client_1_4.xsd,v
done
Checking in catalog/resources/application-client_1_4.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/application-client_1_4.xsd,v  <--  
application-client_1_4.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/connector_1_5.xsd,v
done
Checking in catalog/resources/connector_1_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/connector_1_5.xsd,v  <--  
connector_1_5.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/jsp_2_0.xsd,v
done
Checking in catalog/resources/jsp_2_0.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/jsp_2_0.xsd,v  <--  jsp_2_0.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/ejb-jar_3_0.xsd,v
done
Checking in catalog/resources/ejb-jar_3_0.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/ejb-jar_3_0.xsd,v  <--  ejb-jar_3_0.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/javaee_web_services_1_2.xsd,v
done
Checking in catalog/resources/javaee_web_services_1_2.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/javaee_web_services_1_2.xsd,v  <--  
javaee_web_services_1_2.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/jsp_2_1.xsd,v
done
Checking in catalog/resources/jsp_2_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/jsp_2_1.xsd,v  <--  jsp_2_1.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_2_3.dtd,v
done
Checking in catalog/resources/web-app_2_3.dtd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_2_3.dtd,v  <--  web-app_2_3.dtd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/javaee_5.xsd,v
done
Checking in catalog/resources/javaee_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/javaee_5.xsd,v  <--  javaee_5.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/application-client_5.xsd,v
done
Checking in catalog/resources/application-client_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/application-client_5.xsd,v  <--  
application-client_5.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_2_2.dtd,v
done
Checking in catalog/resources/web-app_2_2.dtd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_2_2.dtd,v  <--  web-app_2_2.dtd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_2_5.xsd,v
done
Checking in catalog/resources/web-app_2_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_2_5.xsd,v  <--  web-app_2_5.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/ejb-jar_2_1.xsd,v
done
Checking in catalog/resources/ejb-jar_2_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/ejb-jar_2_1.xsd,v  <--  ejb-jar_2_1.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/j2ee_web_services_1_1.xsd,v
done
Checking in catalog/resources/j2ee_web_services_1_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/j2ee_web_services_1_1.xsd,v  <--  
j2ee_web_services_1_1.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_2_4.xsd,v
done
Checking in catalog/resources/web-app_2_4.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/web-app_2_4.xsd,v  <--  web-app_2_4.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/
javaee_web_services_client_1_2.xsd,v
done
Checking in catalog/resources/javaee_web_services_client_1_2.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/javaee_web_services_client_1_2.xsd,v  <-
-  javaee_web_services_client_1_2.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/j2ee_1_4.xsd,v
done
Checking in catalog/resources/j2ee_1_4.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/j2ee_1_4.xsd,v  <--  j2ee_1_4.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/DDCatalog.gif,v
done
Checking in catalog/resources/DDCatalog.gif;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/DDCatalog.gif,v  <--  DDCatalog.gif
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/application_5.xsd,v
done
Checking in catalog/resources/application_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/application_5.xsd,v  <--  
application_5.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/application_1_4.xsd,v
done
Checking in catalog/resources/application_1_4.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/application_1_4.xsd,v  <--  
application_1_4.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/
j2ee_web_services_client_1_1.xsd,v
done
Checking in catalog/resources/j2ee_web_services_client_1_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/resources/j2ee_web_services_client_1_1.xsd,v  <--  
j2ee_web_services_client_1_1.xsd
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/EnterpriseCatalog.java,v
done
Checking in catalog/EnterpriseCatalog.java;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/EnterpriseCatalog.java,v  <--  
EnterpriseCatalog.java
initial revision: 1.1
done
RCS file: /cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/Bundle.properties,v
done
Checking in catalog/Bundle.properties;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/catalog/Bundle.properties,v  <--  Bundle.properties
initial revision: 1.1
done
Removing client/resources/application-client_1_4.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/client/resources/application-client_1_4.xsd,v  <--  
application-client_1_4.xsd
new revision: delete; previous revision: 1.2
done
Removing client/resources/application-client_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/client/resources/application-client_5.xsd,v  <--  
application-client_5.xsd
new revision: delete; previous revision: 1.2
done
Removing web/resources/j2ee_1_4.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/j2ee_1_4.xsd,v  <--  j2ee_1_4.xsd
new revision: delete; previous revision: 1.1
done
Removing web/resources/jsp_2_0.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/jsp_2_0.xsd,v  <--  jsp_2_0.xsd
new revision: delete; previous revision: 1.2
done
Removing web/resources/javaee_web_services_client_1_2.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/javaee_web_services_client_1_2.xsd,v  <--  
javaee_web_services_client_1_2.xsd
new revision: delete; previous revision: 1.2
done
Removing web/resources/jsp_2_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/jsp_2_1.xsd,v  <--  jsp_2_1.xsd
new revision: delete; previous revision: 1.3
done
Removing web/resources/j2ee_web_services_client_1_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/j2ee_web_services_client_1_1.xsd,v  <--  
j2ee_web_services_client_1_1.xsd
new revision: delete; previous revision: 1.1
done
Removing web/resources/web-app_2_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/web-app_2_5.xsd,v  <--  web-app_2_5.xsd
new revision: delete; previous revision: 1.3
done
Removing web/resources/web-app_2_2.dtd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/web-app_2_2.dtd,v  <--  web-app_2_2.dtd
new revision: delete; previous revision: 1.1
done
Removing web/resources/web-app_2_4.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/web-app_2_4.xsd,v  <--  web-app_2_4.xsd
new revision: delete; previous revision: 1.2
done
Removing web/resources/javaee_5.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/javaee_5.xsd,v  <--  javaee_5.xsd
new revision: delete; previous revision: 1.2
done
Removing web/resources/web-app_2_3.dtd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/resources/web-app_2_3.dtd,v  <--  web-app_2_3.dtd
new revision: delete; previous revision: 1.1
done
Removing app/EnterpriseCatalog.java;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/app/EnterpriseCatalog.java,v  <--  EnterpriseCatalog.java
new revision: delete; previous revision: 1.2
done
Removing web/DDGrammarQueryManager.java;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/DDGrammarQueryManager.java,v  <--  
DDGrammarQueryManager.java
new revision: delete; previous revision: 1.4
done
Removing web/DDCatalog.java;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/DDCatalog.java,v  <--  DDCatalog.java
new revision: delete; previous revision: 1.5
done
Checking in web/Bundle.properties;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/web/Bundle.properties,v  <--  Bundle.properties
new revision: 1.4; previous revision: 1.3
done
Removing ejb/resources/ejb-jar_2_1.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/ejb/resources/ejb-jar_2_1.xsd,v  <--  ejb-jar_2_1.xsd
new revision: delete; previous revision: 1.2
done
Removing ejb/resources/ejb-jar_3_0.xsd;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/ejb/resources/ejb-jar_3_0.xsd,v  <--  ejb-jar_3_0.xsd
new revision: delete; previous revision: 1.2
done
Checking in resources/layer.xml;
/cvs/j2ee/ddloaders/src/org/netbeans/modules/j2ee/ddloaders/resources/layer.xml,v  <--  layer.xml
new revision: 1.11; previous revision: 1.10
done