This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 109847 - Allow plugging of custom filesystem for the writable layer of the SFS
Summary: Allow plugging of custom filesystem for the writable layer of the SFS
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: David Strupl
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2007-07-16 16:40 UTC by David Strupl
Modified: 2008-12-22 13:41 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
proposed patch (1.54 KB, patch)
2007-07-16 16:42 UTC, David Strupl 		Details | Diff
new patch for review (2.55 KB, patch)
2007-07-19 11:49 UTC, David Strupl 		Details | Diff
patch with test (5.59 KB, patch)
2007-07-23 12:00 UTC, David Strupl 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Strupl 2007-07-16 16:40:44 UTC 
I know this is again late but I have found out while migrating our contrib/zeroadmin that we are doing really ugly hacks
to get to the writable part of the SFS. I would like to be able to plug in my own filesystem there instead of just the
MemoryFileSystem.

The patch is really simple and I will attach it now. The only additional thing I would do in the final patch is to
update some API changes and the arch descriptoin (which one btw?).

The patch would also allow me to plug in e.g. PreferencesFileSystem or something more exotic instead of the local (or
memory) fs part of the SFS.

Do you have any objections against this for 6.0? Should it go through API Review (fast)? I mean can it still go through
it while after feature freeze?
Comment 1 David Strupl 2007-07-16 16:42:43 UTC 
Created attachment 45147 [details]
proposed patch
Comment 2 Jesse Glick 2007-07-16 20:51:05 UTC 
Definitely would have to go through apireviews. I don't see a particular problem with it being merged after feature
freeze, as it does not change anything visible to IDE users and looks quite safe.
Comment 3 David Strupl 2007-07-19 11:49:32 UTC 
Created attachment 45381 [details]
new patch for review
Comment 4 David Strupl 2007-07-19 11:52:07 UTC 
Please review the patch. If there will be no objections I will apply the patch during the next week.
Comment 5 Jaroslav Tulach 2007-07-20 09:04:38 UTC 
Y01 Write a test.
Comment 6 David Strupl 2007-07-23 12:00:39 UTC 
Created attachment 45505 [details]
patch with test
Comment 7 David Strupl 2007-07-23 12:02:49 UTC 
Y01 should be addressed by the latest patch patch-3-109847.diff. Please review.
Comment 8 David Strupl 2007-07-25 11:59:58 UTC 
Checking in startup/src/org/netbeans/core/startup/layers/SystemFileSystem.java;
/cvs/core/startup/src/org/netbeans/core/startup/layers/SystemFileSystem.java,v  <--  SystemFileSystem.java
new revision: 1.11; previous revision: 1.10
done
RCS file: /cvs/core/startup/test/unit/src/org/netbeans/core/startup/layers/CustomWritableSystemFileSystemTest.java,v
done
Checking in startup/test/unit/src/org/netbeans/core/startup/layers/CustomWritableSystemFileSystemTest.java;
/cvs/core/startup/test/unit/src/org/netbeans/core/startup/layers/CustomWritableSystemFileSystemTest.java,v  <-- 
CustomWritableSystemFileSystemTest.java
initial revision: 1.1
done
Checking in arch/arch-core-launcher.xml;
/cvs/core/arch/arch-core-launcher.xml,v  <--  arch-core-launcher.xml
new revision: 1.53; previous revision: 1.52
done