This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 109750 - change mnemonics handling from 2 key/value to '&' method
Summary: change mnemonics handling from 2 key/value to '&' method
Status: CLOSED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Java (show other bugs)
Version: 6.x
Hardware: Sun All
: P3 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on: 113642
Blocks: 86438
  Show dependency tree
 
Reported: 2007-07-15 20:19 UTC by Ken Frank
Modified: 2010-04-29 09:34 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2007-07-15 20:19:09 UTC
A look at some bundle files of the modules in this category showed that
there were usages of the 2 key/value approach for defining mnemonics, ie
FILE_Mnenonic=F
FILE_Label=File

see umbrella 86438 - direction from nb is to replace usage of
setMnemonic and setDisplayed Mnemonic to org.openide.Mnemonics
such that, instead of bundle file having a separate key/value for
defining the mnemonic key and a separate key/value for the label, that
it all be in the one key/value, for example

FILE=&File

(also, even if the assigned key is the first letter of the label, always
put in the '&')

This issue relates to all usages of the 2 key/value approach in this
category.

A quick way to look in bundle files to see this is
find <path> -name "*.properties" | xargs egrep -i '.*=.$'


If this issue needs to be filed in separate subcategories of this
category, please do so and this one could be used as an umbrella issue
of those.

seen in debuggerjpda and spi-debugger-spi.

I don't know if this is required to be complete for nb6; please check
with your nb team and qe on your team; the goal
is not to destabilize mnemonics since that is part of a11y criteria, but
to make it clearer and smoother for translation
teams;  based on voc and requirements from translation teams, nb team
decided to request to have these changes made.
Comment 1 Martin Entlicher 2007-07-16 16:49:21 UTC
It needs to be fixed in debuggercore UI and debuggerjpda/ui modules.
Comment 2 Martin Entlicher 2007-08-23 16:08:12 UTC
Some unused mnemonics were removed:

/shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/ui/models/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.10; previous revision: 1.9
Comment 3 Martin Entlicher 2007-08-23 16:13:05 UTC
The rest of unused mnemonics are removed:

/shared/data/ccvs/repository/debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/ui/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.35; previous revision: 1.34
Comment 4 Martin Entlicher 2007-08-23 16:30:12 UTC
Oops, the mnemonics were actually used.
Via displayName+"_Mnc", thus I did not find them via grep!

Adding back:
/shared/data/ccvs/repository/debuggercore/src/org/netbeans/modules/debugger/ui/models/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.11; previous revision: 1.10


This will be more complicated to fix, since we have getDisplayedMnemonic() in TreeTableView Model API.
Comment 5 Martin Entlicher 2007-08-23 17:24:58 UTC
I can not change this until issue #113642 is implemented.
Comment 6 Ken Frank 2007-11-04 16:24:39 UTC
does spi-debugger-ui need a separate issue ?

ken.frank@sun.com
Comment 7 Peter Pis 2008-04-10 22:54:29 UTC
Changing TM for open issues.
Comment 8 Martin Entlicher 2008-10-27 18:11:39 UTC
It's fully fixed in changeset:   106693:bc5af04fa69e and 106700:549e5ddaee12

http://hg.netbeans.org/main/rev/bc5af04fa69e
http://hg.netbeans.org/main/rev/549e5ddaee12
Comment 9 Quality Engineering 2008-10-28 05:02:14 UTC
Integrated into 'main-golden', will be available in build *200810280201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/bc5af04fa69e
User: mentlicher@netbeans.org
Log: #109750 - Get rid of special key for mnemonics in table columns. Use an ampersand in the display name of the column.
Comment 10 Quality Engineering 2010-04-29 09:34:08 UTC
Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier.